From a37ef402a9caf91302025fe9124d61713d019eaa Mon Sep 17 00:00:00 2001 From: Martin Geisler Date: Sat, 6 Sep 2025 20:53:23 +0200 Subject: [PATCH] docs: improve language in chromium section (#2889) I asked Gemini to review the English for inconsistencies and grammar mistakes. This is the result and I hope it's useful! As a non-native speaker, it is hard for me to evaluate the finer details, so let me know if you would like to see changes (or even better: make them directly in the PR with the suggestion function). --------- Co-authored-by: Dmitri Gribenko --- src/chromium/cargo.md | 4 ++-- src/chromium/setup.md | 2 +- src/chromium/testing.md | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/chromium/cargo.md b/src/chromium/cargo.md index 793b7d9b..0c9e1ec9 100644 --- a/src/chromium/cargo.md +++ b/src/chromium/cargo.md @@ -60,8 +60,8 @@ may offer an advantage"): - Perhaps surprisingly, Rust is becoming increasingly popular in the industry for writing command line tools. The breadth and ergonomics of libraries is - comparable to Python, while being more robust (thanks to the rich - typesystem) and running faster (as a compiled, rather than interpreted + comparable to Python, while being more robust (thanks to the rich type + system) and running faster (as a compiled, rather than interpreted language). - Participating in the Rust ecosystem requires using standard Rust tools like Cargo. Libraries that want to get external contributions, and want to be diff --git a/src/chromium/setup.md b/src/chromium/setup.md index 19215ef4..8a3bc0a9 100644 --- a/src/chromium/setup.md +++ b/src/chromium/setup.md @@ -22,7 +22,7 @@ It's also recommended that you have Visual Studio code installed. # About the exercises -This part of the course has a series of exercises which build on each other. +This part of the course has a series of exercises that build on each other. We'll be doing them spread throughout the course instead of just at the end. If you don't have time to complete a certain part, don't worry: you can catch up in the next slot. diff --git a/src/chromium/testing.md b/src/chromium/testing.md index a57e236d..8cb0c32c 100644 --- a/src/chromium/testing.md +++ b/src/chromium/testing.md @@ -44,9 +44,9 @@ used: the C++ and the Rust implementation (parameterizing the tests so they enable or disable Rust using a `ScopedFeatureList`). -- Hypothetical/WIP PNG integration may need to implement memory-safe - implementation of pixel transformations that are provided by `libpng` but - missing in the `png` crate - e.g. RGBA => BGRA, or gamma correction. Such - functionality may benefit from separate tests authored in Rust. +- Hypothetical/WIP PNG integration may need memory-safe implementations of pixel + transformations that are provided by `libpng` but missing in the `png` crate - + e.g. RGBA => BGRA, or gamma correction. Such functionality may benefit from + separate tests authored in Rust.