rust/comprehensive-rust
1
0
Fork 0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-03-30 17:28:20 +02:00
Code Issues Releases Activity

Remove trait bound on VerbosityFilter in the generic data types slide (#2603)

Browse Source 
It's generally more idiomatic in Rust to not have trait bounds on the
data type itself. I think we better demonstrate how trait bounds are
used in impl blocks with generic data types in the impl block below the
struct definition. I've also added a speaker note to call this out if
students ask.
This commit is contained in:
Nicole L 2025-02-03 10:57:24 -08:00 committed by GitHub
parent 43e1cd6c49
commit abf9393e60
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/generics/generic-data.md
View File

@ -22,7 +22,7 @@ impl Logger for StderrLogger {
} }
/// Only log messages up to the given verbosity level. /// Only log messages up to the given verbosity level.
struct VerbosityFilter<L: Logger> { struct VerbosityFilter<L> {
max_verbosity: u8, max_verbosity: u8,
inner: L, inner: L,
} }
@ -53,5 +53,8 @@ fn main() {
- `VerbosityFilter` is still generic and you can use `VerbosityFilter<f64>`, - `VerbosityFilter` is still generic and you can use `VerbosityFilter<f64>`,
but methods in this block will only be available for but methods in this block will only be available for
`Point<StderrLogger>`. `Point<StderrLogger>`.
- Note that we don't put a trait bound on the `VerbosityFilter` type itself. You
can put bounds there as well, but generally in Rust we only put the trait
bounds on the impl blocks.
</details> </details>