rust/comprehensive-rust
1
0
Fork 0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-03-22 14:59:37 +02:00
Code Issues Releases Activity
140 Commits 18 Branches 0 Tags
Commit Graph

97 Commits

Author SHA1 Message Date
Martin Geisler
d5359fa92a Add support for speaker notes 
This implements a system for speaker notes via `details` elements and
some JavaScript. The general idea is

1. You add speaker notes to each page by wrapping some Markdown code
   in `<details> … </details>`. This is a standard HTML element for,
   well extra details. Browsers will render the element with a toggle
   control for showing/hiding the content.

2. We inject JavaScript on every page which finds these speaker note
   elements. They’re styled slightly and we keep their open/closed
   state in a browser local storage. This ensures that you can keep
   them open/closed across page loads.

3. We add a link to the speaker notes which will open in a new tab.
   The URL is amended with `#speaker-notes-open`, which we detect in
   the new tab: we hide the other content in this case.
   Simultaneously, we hide the speaker notes in the original window.

4. When navigating to a new page, we signal this to the other window.
   We then navigate to the same page. The logic above kicks in and
   hides the right part of the content. This lets the users page
   through the course using either the regular window or the speaker
   notes — the result is the same and both windows stay in sync.

Tested in both Chrome and Firefox. When using a popup speaker note
window, the content loads more smoothly in Chrome, but it still works
fine in Firefox.

Fixes #53.
 2023-01-05 07:46:18 +01:00
Andrew Walbran
28942d7b9f
Merge pull request #36 from daym/patch-1 
Tuples with "..." make no sense, so don't use them
 2023-01-04 15:42:35 +00:00
Andrew Walbran
9f46beafdb
Merge pull request #105 from Adrian-Samoticha/patch-1 
Fix typo in `modules.md`
 2023-01-04 15:42:07 +00:00
Adrian Samoticha
a0ad1eafa8
Fix typo in visibility.md 2023-01-04 15:58:34 +01:00
Adrian Samoticha
89ad1f6a65
Fix typo in modules.md 2023-01-04 15:44:37 +01:00
Martin Geisler
c2c11531a5
Merge pull request #96 from zhouwfang/simplify-solution-to-prefix-matching 
Simplify the solution to prefix matching
 2023-01-04 09:11:58 +01:00
liao02x
8d36a3bdd3
fix typo in deriving-error-enums.md 2023-01-03 21:18:30 -08:00
Zhou Fang
1fb0b0a46d Simplify solution to prefix matching. 2023-01-03 20:11:20 -08:00
Martin Geisler
b027db0241
Add back links to the Rust Book 
I think it's important that we link the students to the full information about Unsafe Rust.
 2023-01-02 10:30:40 +01:00
MaschitaG
b2ae19b5fd
Update static-and-const.md 2023-01-02 10:25:39 +01:00
MaschitaG
1c1c3d38d8
Unsafe Rust 
Unsafe Rust is mentioned in the course
 2023-01-02 10:12:56 +01:00
Martin Geisler
12c110d172
Merge pull request #93 from Fosco1/patch-1 
Corrected typo on receiver.md
 2023-01-02 10:08:42 +01:00
Fosco1
a4bd084e50
Corrected typo on receiver.md 
https://dictionary.cambridge.org/it/grammatica/grammatica-britannico/it-s-or-its
 2023-01-02 10:04:04 +01:00
MaschitaG
a7461f805a
Update welcome.md 
Make the language more precise
 2023-01-02 10:01:10 +01:00
Seamus Connor
6cb3254cf1
Correct compilation error in unit-tests.md 2023-01-01 13:57:19 -08:00
Martin Geisler
51cbf29d92
Merge pull request #79 from riking/patch-1 
comparison: copyedit 'delays' to 'delayed'
 2022-12-31 12:35:24 +01:00
Martin Geisler
150e78a3f9
Rephrase destructor delays 
After a discussion, it seems singular works well.
 2022-12-31 12:33:57 +01:00
Martin Geisler
8a8f44b568
Merge pull request #89 from jswalden/patch-3 
Typo in "Fearless Concurrency" intro
 2022-12-31 12:27:00 +01:00
Jeff Walden
1ae03443d5
"a classic problem", not "...problems" 2022-12-30 21:54:35 -08:00
Jeff Walden
9def3e371d
Typo in "Fearless Concurrency" intro 
"referred to a _fearless concurrency_" -> "referred to a*s* _fearless concurrency_"
 2022-12-30 20:53:38 -08:00
Martin Geisler
d8fd38b88a
Merge pull request #81 from google/utf-8-encoding 
Mention that strings are UTF-8 encoded
 2022-12-28 20:38:46 +01:00
Martin Geisler
d7a33f24a6
Merge pull request #83 from google/mention-arc 
Mention `Arc` on `Rc` slide
 2022-12-28 20:38:22 +01:00
Martin Geisler
4a0455f5bd
Merge pull request #85 from der3318/update-test-cases-for-polygons 
Better Test Case for Day 2 Polygon Exercise
 2022-12-28 15:46:15 +01:00
Martin Geisler
6851a6b533
Show different tuple sizes 2022-12-28 15:41:08 +01:00
Der Chien
0b77fc6bf3
20221228 revert the points length check 2022-12-28 22:39:52 +08:00
Der Chien
42494f95ab
20221228 add one more point to the polygon 2022-12-28 21:49:01 +08:00
Arman Yessenamanov
8470be86d0
Fix a typo 2022-12-28 18:58:23 +06:00
Martin Geisler
7ee63aced6
Mention Arc on Rc slide 
Fixes #67.
 2022-12-28 10:15:17 +01:00
Martin Geisler
cac0641a54
Mention that strings are UTF-8 encoded 
Technically, it's the Rust source file that is UTF-8 encoded, but in practical terms, this means that the string literals are UTF-8 encoded. It's only if you start using non-ASCII identifiers that you end up with UTF-8 encoded text outside of a string literal.

Fixes #35.
 2022-12-28 09:32:28 +01:00
Martin Geisler
dcf29d4653
Merge pull request #74 from google/try-operator 
More precise phrasing of what ? expands to
 2022-12-28 09:26:18 +01:00
Martin Geisler
94cd8bb592
Link to reference on method receiver types 2022-12-28 09:19:19 +01:00
Kane York
de7d91752f
comparison: copyedit 'delays' to 'delayed' 
This is the correct grammatical form for the bullet point, it expands into "Destructors [of objects are] delayed."
 2022-12-27 14:13:10 -08:00
Martin Geisler
82a2f4c423
Mention that there are other receiver types 2022-12-27 18:16:21 +01:00
Martin Geisler
c15e84f63e
More precise phrasing of what ? expands to 
As per the suggestion from @QuineDot in #65.
 2022-12-27 18:09:54 +01:00
Martin Geisler
c7eff6b85e
Merge pull request #55 from Arthur-Milchior/patch-5 
Fix typo on Send+Sync page
 2022-12-27 17:19:07 +01:00
Martin Geisler
4295b8da5c
Further refine language as per @QuineDot's idea 2022-12-27 17:17:38 +01:00
Martin Geisler
f217cd12a2
Merge pull request #54 from Arthur-Milchior/patch-4 
Typos
 2022-12-27 17:16:13 +01:00
Martin Geisler
cc0c02aa14
Copy-editing on the shared state page 
The access is to the specific `T` value found in the `Mutex<T>`.
 2022-12-27 17:14:45 +01:00
Martin Geisler
d052db8874
Merge pull request #73 from janosh/fix-casing-types-bit-width 
Fix casing in type bit widths
 2022-12-27 16:46:57 +01:00
Martin Geisler
bc37d48cb0
Merge pull request #61 from pdecat/patch-1 
Remove misplaced "calls"
 2022-12-27 16:40:08 +01:00
Janosh Riebesell
cf695a99e3
fix casing in type bit widths 2022-12-26 19:35:09 -08:00
Patrick Decat
b5cbe4896b
Remove misplaced "calls" 2022-12-26 11:22:00 +01:00
Mathias M
fe3651df02
Fixes typo 2022-12-26 09:12:00 +01:00
Tom Niget
f82867b2bb
Precise what the Android parts are about (fixes #56) 2022-12-25 17:12:42 +01:00
Arthur Milchior
2b2e006417 Typo 
Not sure of the intended meaning. At least the sentence is true and gramattically correct here
 2022-12-24 20:39:48 -08:00
Arthur Milchior
94933b43f1
Typos 2022-12-24 20:23:43 -08:00
Jeff Walden
75f6d0b5bd
Insert "a" in a sentence that's missing it 2022-12-23 23:05:21 -08:00
Martin Geisler
0218fdb1f0
Merge pull request #46 from matm/patch-1 
Fixes typo in comment
 2022-12-23 14:26:30 +01:00
Martin Geisler
80edc895db
Merge pull request #42 from reillyeon/patch-2 
Change "semantics is" to "semantics are"
 2022-12-23 12:57:32 +01:00
Martin Geisler
2b91c8c818
Merge pull request #44 from drgnchan/patch-1 
Fix grammer in references-dangling.md
 2022-12-23 12:41:59 +01:00