1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-06-16 06:10:26 +02:00
Commit Graph

662 Commits

Author SHA1 Message Date
476ee283c6 Simplify Vec slide (#313)
The code is probably meant to illustrate the `vec!` macro, but it
feels out of place when teaching: there is already enough material
here to get through.
2023-02-01 10:49:11 +01:00
d6182ea498 Fix missing word (#311) 2023-01-31 20:09:00 +00:00
c6a54ce9a9 Show the pair returned by duplicate (#314)
This makes it easier to talk about the code as you make changes to the
`duplicate` function.
2023-01-31 21:08:09 +01:00
dee5e654c8 Fix order of standard library slides (#310)
The slides now follow the order on the intro slide.
2023-01-31 15:04:17 -05:00
fd65ff0f0c Fix JetBrains capitalization (#305)
* Fix JetBrains capitalization

* Revert change to da.po

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
2023-01-31 19:45:54 +00:00
330d21ef02 Update traits.md 2023-01-31 11:07:24 +00:00
100ee591ed Update unsafe.md (#252)
* Update unsafe.md

Adding a paragraph explaining that unsafe code is not necessary broken or evil, but it is a mode
where compiler safety features are off.

* Move explanation to speaker notes

To avoid slide being too long. Also edited text slightly.

* Remove extra space

---------

Co-authored-by: Andrew Walbran <qwandor@google.com>
2023-01-30 13:12:51 +00:00
efa593e020 Automatically build and test all translations (#298)
This changes the build workflow to first list all available `.po`
files, and then use this information to start parallel jobs which test
each translation.
2023-01-30 13:41:19 +01:00
e847c13fb7 Take out unnecessary watch dir (#303)
The directory is already mentioned in our `book.toml`.
2023-01-30 13:33:04 +01:00
601dc8258b Speaker notes for vec.md (#296)
* Speaker notes for vec.md

* Fix grammar and formatting

* Fix formatting and spelling.

---------

Co-authored-by: Andrew Walbran <qwandor@google.com>
2023-01-30 11:56:30 +00:00
49d24f89cf Speaker notes for while-let-expressions.md (#294)
* Speaker notes for while-let-expressions.md

#274

* Update while-let-expressions.md

---------

Co-authored-by: Andrew Walbran <qwandor@google.com>
2023-01-30 11:47:56 +00:00
1040115d8c Add Korean translation (#300)
* add ko.po

* translate ko(~23.01.19)

* change speaker-note ko

* change id

* translate ko(~23.01.20)

* ~day3 keynote

* draft done to f3446a91

* add @jiyongp comments of upstream PR #276.

* sync & apply review comments(upstream)

sync 585509bb

* After 10000 line apply review comments(upstream)

* chgange build.yml

* Fix the inconsistent newline character problem for the KO translation

If a msgid does not end with the newline character, so should the
msgstr.

Test: msgfmt --statistics -o /dev/null po/ko.po
No error, but shows `1085 translated messages, 675 untranslated
messages.`

---------

Co-authored-by: Evan kim(cli) <keispace.kyj@gmail.com>
2023-01-30 14:12:33 +09:00
31ae4ac56b Rename LICENSE.txt to LICENSE (#293)
* Rename LICENSE.txt to LICENSE

* Update credits.md
2023-01-29 14:20:55 +01:00
43c5344785 Fix typos (#297)
* fix typo in running-the-course.md

* Update modern.md
2023-01-29 11:54:51 +00:00
49e06ffe03 Fix link to solution on Day 3 exercise (#299)
* fix day-3 solutions link

* Fix link description by making it singular

---------

Co-authored-by: Martin Geisler <martin@geisler.net>
2023-01-29 12:52:32 +01:00
690039fd53 Filter out “fuzzy” translations (#212)
When the source text is updated, existing translations become
outdated. The `msgmerge` program will attempt to find a similar source
text among the existing translations and will reuse the translation.
The translation is marked “fuzzy” to signal to the translator that it
needs to be proofread.
2023-01-28 14:36:57 +01:00
27b6165202 Implement Error. 2023-01-27 17:54:37 +00:00
caaca140ca Another note for anyhow. 2023-01-27 17:54:37 +00:00
79f5f0dade Add slide about Box<dyn Error> before introducing anyhow. 2023-01-27 17:54:37 +00:00
e5c97e12cb No need for thiserror as well as anyhow. 2023-01-27 17:54:37 +00:00
9fa0e89e90 It makes no sense to use both return and ?. 2023-01-27 17:54:37 +00:00
52d28b155b Mention std::error::Error in speaker notes, and other useful traits. 2023-01-27 17:54:37 +00:00
5dd87192e8 Mention that Send and Sync are unsafe traits. 2023-01-27 17:34:31 +00:00
81cf02ffbe Fix typos and details. 2023-01-27 17:34:31 +00:00
cc402a7788 Add some speaker notes to concurrency chapter. 2023-01-27 17:34:31 +00:00
ee36ae318f Add an aspect-ratio-helper mdbook preprocessor (#187)
The idea is that this will help us make better slides: we can see at a
glance when the slide becomes too full.
2023-01-27 18:30:37 +01:00
c066ab5664 Mention other ABI options. 2023-01-27 17:17:37 +00:00
95c0447e4b Remove comment inside unsafe block.
Martin thinks the safety comment at the top is enough.
2023-01-27 17:17:37 +00:00
facbac4601 Fix typo, and this is not specific to glibc. 2023-01-27 17:17:37 +00:00
6e7916c29b Add a slide about writing unsafe functions. 2023-01-27 17:17:37 +00:00
3cadad4e0a Add slide for unsafe traits. 2023-01-27 17:17:37 +00:00
8c2b3781bb Move extern functions slide under unsafe functions. 2023-01-27 17:17:37 +00:00
7deb5532ea Add speaker notes for extern functions. 2023-01-27 17:17:37 +00:00
d07171e76d Add safety comment. 2023-01-27 17:17:37 +00:00
47e28e87c0 Add speaker notes for unions. 2023-01-27 17:17:37 +00:00
d7fcf8216a Mutable statics are generally a bad idea. 2023-01-27 17:17:37 +00:00
9bed4fce3c Add speaker notes and safety comment for raw pointers. 2023-01-27 17:17:37 +00:00
062905e7d7 There's no name involved here. 2023-01-27 17:17:37 +00:00
e0cb292624 Put unsafe slides in same order as they are introduced in unsafe.md. 2023-01-27 17:17:37 +00:00
4409f330c5 Move GA code directly into main page (#289)
This replaces a bit of code with the equivalent HTML code.

We also load the script async, which means that the browser won’t
block rendering while waiting for the scripts.
2023-01-27 14:37:17 +01:00
1453e1d5bb Update blocks.md 2023-01-27 12:03:49 +00:00
585509bb0a Update points-polygons.md (#234)
Adding speaker notes with key things that might be present in the solution.
2023-01-26 19:04:03 +01:00
4588d95427 Update match-guards.md 2023-01-26 12:08:21 +00:00
a0a1059c0d Verbose description of Sync-Send relationship
Add a verbose rationale of the statement:
  `T` is `Sync` if and only if `&T` is `Send`
2023-01-26 12:06:54 +00:00
f0310f4f61 Fixed link to IntoIterator for Vec doc 2023-01-26 12:04:58 +00:00
f15fc1a0b8 Add discussion points for traits (#180)
* Some discussion points for traits
* Add answers
2023-01-26 09:14:05 +00:00
ec01563bd6 Propose to use the generic term perimeter instead of circumference for shapes (#281)
* Update unit tests to use generic perimeter

* Update solution to use perimeter

Update solution to use the generic term perimeter instead of circumference
2023-01-26 08:59:13 +00:00
438c16607d Add theme generated with mdbook init --theme (#189)
This will allow us to customize the appearance more easily: we can
move the GA logic into the theme (to reduce load times and to simplify
the JS injection logic). We can also add new elements, which is what I
will do next.

The mdbook theme can be added incrementally: if we don’t add a file to
our theme folder, we will get the corresponding file from mdbook.
2023-01-25 21:31:22 +01:00
4fed580efa Add trailing backslash for multiline command (#277)
There were some backslashed missing in the command to serve the
translated book. Thus the shell would execute the lines one after the
other, instead of as one command.

This lead to the environment variables not actually being set, and thus
the non-translated version was served anyway.
2023-01-25 18:26:58 +01:00
f3446a9176 Speaker notes for methods.md (#202)
* Update methods.md

* Update methods.md

* Update methods.md

* Reword explanation of methods

Co-authored-by: Andrew Walbran <qwandor@google.com>
2023-01-24 10:46:13 -08:00