Publishes the new translations for CR2 (originally from zh-CN-cr2) #1463
which were previously reviewed.
It also removes line numbers (#1753)
#324
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1764 | bat -l patch
```
From @mgeisler PRs (e.g. #1752, #1753)
This is a clean refresh, requires only a syntactic review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1759 | bat -l patch
```
This allows dumping the course content in order, which I've needed
several times to verify whether a concept is used before it is covered
-- for example in #1516 I want to make sure we don't use trait objects
before the Smart Pointers section.
This is a clean refresh, requires only a syntactical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1745 | bat -l patch
```
This is a clean refresh, requires only a syntactical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1737 | bat -l patch
```
This is a clean refresh, requires only a syntactical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1741 | bat -l patch
```
This is a clean refresh, requires only a syntaxtical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1750 | bat -l patch
```
This is a clean refresh, requires only a syntactical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1752 | bat -l patch
```
This is a clean refresh, requires only a syntactical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1740 | bat -l patch
```
Long overdue.
It felt a bit "odd" self-assigning merit, especially because I think I
haven't nearly contributed enough translations. So I looked at the
[history of `it.po` file](https://github.com/google/comprehensive-rust/commits/main/po/it.po)
and identified also @henrythebuilder as the other "owner" of the Italian
translation (definitely, based on number of lines contributed).
@henrythebuilder please confirm you are comfortable with this.
This is a clean refresh, requires only a syntactical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1739 | bat -l patch
```
This is a clean refresh, requires only a syntaxtical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1748 | bat -l patch
```
This is a clean refresh, requires only a syntaxtical review.
You can skim this PR with the [GitHub CLI](https://cli.github.com/):
```
gh pr diff 1749 | bat -l patch
```
IMO it is better to explain to users the common usage / applicability
domain for anyhow and thiserror crates
---------
Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
This should be a bit simpler, and notably
* does not require trait objects, which per #1516 should be moved later
in the course
* does not require a lot of futzing with string formatting
But all that hard work developing the GUI exercise is not for naught: it
remains in the "Modules" segment, where students will get a chance to
read some Rust code and reorganize it a little bit.
Fixes#1617.
R=mgeisler as the original author of the GUI exercise.
Bumps the minor group in /src/exercises/bare-metal/compass with 1
update: [lsm303agr](https://github.com/eldruin/lsm303agr-rs).
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hi, ja translation team (#652 ). Here's an MR for the chapter "Shared
States." Could you review the translations? any feedback would be
appreciated. Thank you 😄
cc: @keiichiw , @chikoski , @HidenoriKobayashi , @ternbusty
(Retrieved translaftion draft #1636 Chapter 60 draft, after recent
`ja.po` file refresh #1676 )
Bumps the patch group with 1 update:
[clap](https://github.com/clap-rs/clap).
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the patch group in /src/exercises/bare-metal/rtc with 1 update:
[bitflags](https://github.com/bitflags/bitflags).
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the patch group in /src/bare-metal/aps/examples with 1 update:
[bitflags](https://github.com/bitflags/bitflags).
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the minor group in /src/bare-metal/microcontrollers/examples with
2 updates: [nrf52833-hal](https://github.com/nrf-rs/nrf-hal) and
[nrf52833-pac](https://github.com/nrf-rs/nrf-pacs).
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the patch group with 1 update:
[tokio-websockets](https://github.com/Gelbpunkt/tokio-websockets).
Updates `tokio-websockets` from 0.5.0 to 0.5.1
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
Without this, several of the formatting directives in our `rustfmt.toml`
file won’t have any effect. This will in turn lead to mismatches between
the formatting done locally and in CI.
This creates a dependency on `rustup`, but I think this is overall
better than silently ignoring the formatting directives.
From the discussion in #1682.
Attempt to address #1677.
Expert review is needed. The new text is my best guess based on the
original text and other explanations I could find online.
A few things to note:
* I'm trying to distinguish the future we return and the future we
await. My assumption is that the stack contents goes to the future the
code returns, not the future the code is awaiting.
* Readers could be worried if they need to pin the code they write. I'm
reassuring them that the borrow checks would normally catch bad
references.
* I'm intentionally avoiding the words that something is unsafe (or
would be unsafe). The async Rust is safe.
* I'm trying to be clear that `Pin` is a protective wrapper around a
pointer, not a mechanism that changes the pointer or the pointed object.
* Likewise, I don't want to give an impression that an unpinned pointer
to a future is inherently unsafe or invalid. It just cannot be used to
poll the future.
* I dropped the vague mention of the "issues", as it probably refers to
the issue with replacing a future (as opposed to resetting it in place).
It's already mentioned in the notes further on this page. It affects
pinning on stack only, `Box::pin()` can be replaced.
Co-authored-by: Martin Geisler <martin@geisler.net>
Bumps the minor group with 1 update:
[googletest](https://github.com/google/googletest-rust).
Updates `googletest` from 0.10.0 to 0.11.0
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The GitHub action added in #1576 fails because it cannot run with the
necessary permissions: it requires write access to be able to post a
comment, but when triggered from a fork, the token is limited to read
access.
The error is from the thollander/actions-comment-pull-request action:
No comment has been found with asked pattern. Creating a new comment.
Error: Resource not accessible by integration
The downgrading of the token is explained on:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication
where “Maximum access for pull requests from public forked repositories”
says that the pull-requests permission is capped at read in the typical
case for us.
I kept the underlying functionality since we might want to use it for
something else (perhaps track the duration in the README).
Fixes the errors seen on the recent PRs: #1693, #1687, and likely
others.
