Arthur Milchior
94933b43f1
Typos
2022-12-24 20:23:43 -08:00
Martin Geisler
8f638d8c4a
Merge pull request #51 from jswalden/patch-1
...
Insert "a" in a sentence that's missing it
2022-12-24 10:17:52 +01:00
Jeff Walden
75f6d0b5bd
Insert "a" in a sentence that's missing it
2022-12-23 23:05:21 -08:00
Ilya Grigoriev
5ce7a08f0e
anyhow: say this example has fewer custom types
2022-12-23 13:35:40 -08:00
Ilya Grigoriev
894e694cdb
anyhow: Remove ReadUsernameError::IoError
...
As far as I understand, the example with the `anyhow` example
does not use its special `IoError` anymore, unlike the previous
example with just `thiserror`.
I think this should be made clear. I considered just adding a
`// Now unused` comment, but I think ti's clearer to just remove
the unused code.
2022-12-23 13:32:03 -08:00
Martin Geisler
0218fdb1f0
Merge pull request #46 from matm/patch-1
...
Fixes typo in comment
2022-12-23 14:26:30 +01:00
Martin Geisler
80edc895db
Merge pull request #42 from reillyeon/patch-2
...
Change "semantics is" to "semantics are"
2022-12-23 12:57:32 +01:00
Martin Geisler
cc6c7e63fe
Merge pull request #47 from google/build-version-numbers
...
Install specific mdbook version in build action
2022-12-23 12:50:48 +01:00
Martin Geisler
a9ca0c860a
Install specific mdbook version in build action
...
Like in #30 , we should install a known-good version of `mdbook` and
`mdbook-svgbob` when testing PRs.
2022-12-23 12:42:55 +01:00
Martin Geisler
2b91c8c818
Merge pull request #44 from drgnchan/patch-1
...
Fix grammer in references-dangling.md
2022-12-23 12:41:59 +01:00
Mathias M
69cd18f12a
Fixes typo in comment
2022-12-23 12:03:03 +01:00
Martin Geisler
61aa12e3f3
Merge pull request #27 from taufik-rama/docs/rustup-installation
...
Mention rustup.rs on the installation page
Fixes #19 .
2022-12-23 11:41:30 +01:00
Martin Geisler
1b59aa5d71
Merge pull request #45 from Arthur-Milchior/patch-3
...
Makes ownership of `self` more accurate
2022-12-23 11:39:08 +01:00
Martin Geisler
952e778527
Merge pull request #43 from reillyeon/patch-3
...
Grammar fix in ownership/lifetimes-function-calls.md
2022-12-23 11:34:51 +01:00
Martin Geisler
21a2bb235f
Merge pull request #41 from reillyeon/patch-1
...
Fix C array syntax in memory-management/manual.md
2022-12-23 11:27:15 +01:00
Martin Geisler
71caeae674
Merge pull request #39 from dzvon/patch-1
...
Fix a typo
2022-12-23 11:25:00 +01:00
Martin Geisler
bbc98a44ec
Merge pull request #25 from kianmeng/misc-doc-fixes
...
Misc doc fixes
2022-12-23 11:19:45 +01:00
Taufik Rama
b9085905f1
Simplifies rustup
2022-12-23 17:11:24 +07:00
Arthur Milchior
3631117446
Makes ownership of self more accurate
...
It’s entirely possible that a method gives ownership of self to another object, or return `self`.
For example
```
fn id(self) -> Self {
return self;
}
```
or more realistically
```
fn or(self, other) -> Self {
if (self.isValid()) { return self;}
return other;
}
```
2022-12-23 00:16:42 -08:00
drgnchan
73e9a0b854
Update references-dangling.md
2022-12-23 15:41:41 +08:00
Reilly Grant
9464def62e
Grammar fix in ownership/lifetimes-function-calls.md
2022-12-22 22:09:17 -08:00
Reilly Grant
5223ef8f25
Change "semantics is" to "semantics are"
...
Subject-verb agreement.
2022-12-22 22:05:38 -08:00
Reilly Grant
16d4d2c92f
Fix C array syntax in memory-management/manual.md
...
Heap-allocated arrays in C use `int*` instead of `int[]`.
2022-12-22 21:58:08 -08:00
Kian-Meng Ang
54adbe7f55
Misc doc fixes
...
List of changes:
- fix typos found via `codespell -S target -L crate`
- ignore Cargo.lock
2022-12-23 11:24:51 +08:00
Dezhi Wu
0ebfc8a54a
docs: fix a typo
2022-12-23 10:36:58 +08:00
Martin Geisler
264047445f
Merge pull request #28 from zdimension/patch-2
...
Add footnote about memory leaks
2022-12-22 20:29:10 +01:00
Danny Milosavljevic
4126cbd519
Tuples with "..." make no sense, so don't use them
2022-12-22 20:25:15 +01:00
Martin Geisler
06b594b47a
Merge pull request #26 from mxschumacher/patch-1
...
Fix typo
2022-12-22 20:18:54 +01:00
Tom Niget
3bed28a9d9
Add "mostly"
2022-12-22 20:18:36 +01:00
Martin Geisler
aa12047dce
Merge pull request #33 from LLyaudet/patch-1
...
Corrected 1 or 2 typos
2022-12-22 19:59:06 +01:00
Martin Geisler
466b6e9cd9
Merge pull request #30 from google/mdbook-versions
...
Include version numbers when installing `mdbook`
2022-12-22 19:57:22 +01:00
Martin Geisler
b29dd1ae09
Merge pull request #31 from google/mdbook-test
...
Add a build workflow to test PRs
2022-12-22 19:56:54 +01:00
Laurent Lyaudet
1315481e69
Corrected 1 or 2 typos
...
missing verb :
"The goal of the course to teach you Rust." -> "The goal of the course is to teach you Rust."
missing of ? :
"to cover all it" -> "to cover all of it"
for this one, I'm not a native english speaker but it seems more correct to me. I'll let you check :)
2022-12-22 18:33:02 +01:00
Martin Geisler
11789caee2
Add a build workflow to test PRs
...
We will expand this to build/test other things in the future.
2022-12-22 15:22:41 +01:00
Martin Geisler
85c1684fe3
Include version numbers when installing mdbook
2022-12-22 15:01:55 +01:00
Tom Niget
5dd366d7db
Remove part about Rc
2022-12-22 14:24:47 +01:00
Tom Niget
7b7b56398e
Add footnote about memory leaks
2022-12-22 14:03:18 +01:00
Taufik Rama
b9eed2a072
Minor sidenote for rustup installation as an alternative to distro package manager
2022-12-22 19:49:58 +07:00
Martin Geisler
15b8ca8a05
Merge pull request #22 from Arthur-Milchior/patch-1
...
Clarify from/into
2022-12-22 13:23:55 +01:00
Max Schumacher
adc64c020b
fix typo
2022-12-22 11:52:44 +01:00
Martin Geisler
121a7d33f3
Merge pull request #7 from andrewpollack/patch-5
...
Minor punctuation update
2022-12-22 10:08:16 +01:00
Martin Geisler
0e74800885
Merge pull request #9 from andrewpollack/patch-7
...
Minor punctuation addition
2022-12-22 10:07:58 +01:00
Andrew Pollack
7a215992b4
Minor typo, punctuation update ( #5 )
...
* Minor typo
2022-12-22 10:07:26 +01:00
Martin Geisler
d66506fe35
Merge pull request #3 from andrewpollack/patch-1
...
Adding colon punctuation to lists
2022-12-22 10:06:15 +01:00
Martin Geisler
1a7df6cfb1
Merge pull request #6 from andrewpollack/patch-4
...
Minor punctuation update
2022-12-22 10:05:53 +01:00
Martin Geisler
ed0a11a86b
Merge pull request #10 from andrewpollack/patch-8
...
Minor punctuation update
2022-12-22 10:05:08 +01:00
Martin Geisler
d80b91b3fd
Merge pull request #20 from lonesometraveler/typo
...
typo: assigment -> assignment
2022-12-22 10:03:35 +01:00
Martin Geisler
b424abf704
Merge pull request #14 from google/gh-action-cache
...
Cache the artifacts built by the publish workflow
2022-12-22 09:45:16 +01:00
Arthur Milchior
638dde7704
Clarify from/into
...
I found the phrasing confusing. Mentionning that a class implements From and then using `into()` seems confusing. It looks like that you meant that it implements `Into`.
So I believe that a little more details may help show why this exercise is valid.
I would have considered clarifying that `into` does not need to specify that we use the implementation for `i16` thanks to type analysis, but I assume this would add too much text, and this can either be ignored by the reader for the time being, or guessed
2022-12-21 16:46:23 -08:00
Kentaro Okuda
62f530d5ac
typo: assigment -> assignment
2022-12-21 19:45:02 -05:00
