1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2024-12-15 22:37:28 +02:00
Commit Graph

1562 Commits

Author SHA1 Message Date
Martin Geisler
150e78a3f9
Rephrase destructor delays
After a discussion, it seems singular works well.
2022-12-31 12:33:57 +01:00
Martin Geisler
8a8f44b568
Merge pull request #89 from jswalden/patch-3
Typo in "Fearless Concurrency" intro
2022-12-31 12:27:00 +01:00
Martin Geisler
ce143ad031
Merge pull request #90 from jswalden/patch-4
Typo in concurrency exercises intro
2022-12-31 12:26:20 +01:00
Jeff Walden
1ae03443d5
"a classic problem", not "...problems" 2022-12-30 21:54:35 -08:00
Jeff Walden
9def3e371d
Typo in "Fearless Concurrency" intro
"referred to a _fearless concurrency_" -> "referred to a*s* _fearless concurrency_"
2022-12-30 20:53:38 -08:00
Martin Geisler
d8fd38b88a
Merge pull request #81 from google/utf-8-encoding
Mention that strings are UTF-8 encoded
2022-12-28 20:38:46 +01:00
Martin Geisler
d7a33f24a6
Merge pull request #83 from google/mention-arc
Mention `Arc` on `Rc` slide
2022-12-28 20:38:22 +01:00
Martin Geisler
4a0455f5bd
Merge pull request #85 from der3318/update-test-cases-for-polygons
Better Test Case for Day 2 Polygon Exercise
2022-12-28 15:46:15 +01:00
Martin Geisler
6851a6b533
Show different tuple sizes 2022-12-28 15:41:08 +01:00
Der Chien
0b77fc6bf3
20221228 revert the points length check 2022-12-28 22:39:52 +08:00
Martin Geisler
7b98da490a
Merge pull request #84 from yesenarman/patch-1
Fix a typo: "will be drop" -> "will be dropped"
2022-12-28 15:31:18 +01:00
Der Chien
42494f95ab
20221228 add one more point to the polygon 2022-12-28 21:49:01 +08:00
Arman Yessenamanov
8470be86d0
Fix a typo 2022-12-28 18:58:23 +06:00
Martin Geisler
7ee63aced6
Mention Arc on Rc slide
Fixes #67.
2022-12-28 10:15:17 +01:00
Martin Geisler
cac0641a54
Mention that strings are UTF-8 encoded
Technically, it's the Rust source file that is UTF-8 encoded, but in practical terms, this means that the string literals are UTF-8 encoded. It's only if you start using non-ASCII identifiers that you end up with UTF-8 encoded text outside of a string literal.

Fixes #35.
2022-12-28 09:32:28 +01:00
Martin Geisler
dcf29d4653
Merge pull request #74 from google/try-operator
More precise phrasing of what ? expands to
2022-12-28 09:26:18 +01:00
Martin Geisler
2a73a58e25
Merge pull request #75 from google/method-receiver-types
Mention that there are other receiver types
2022-12-28 09:23:52 +01:00
Martin Geisler
94cd8bb592
Link to reference on method receiver types 2022-12-28 09:19:19 +01:00
Kane York
de7d91752f
comparison: copyedit 'delays' to 'delayed'
This is the correct grammatical form for the bullet point, it expands into "Destructors [of objects are] delayed."
2022-12-27 14:13:10 -08:00
Martin Geisler
82a2f4c423
Mention that there are other receiver types 2022-12-27 18:16:21 +01:00
Martin Geisler
c15e84f63e
More precise phrasing of what ? expands to
As per the suggestion from @QuineDot in #65.
2022-12-27 18:09:54 +01:00
Martin Geisler
c7eff6b85e
Merge pull request #55 from Arthur-Milchior/patch-5
Fix typo on Send+Sync page
2022-12-27 17:19:07 +01:00
Martin Geisler
4295b8da5c
Further refine language as per @QuineDot's idea 2022-12-27 17:17:38 +01:00
Martin Geisler
f217cd12a2
Merge pull request #54 from Arthur-Milchior/patch-4
Typos
2022-12-27 17:16:13 +01:00
Martin Geisler
cc0c02aa14
Copy-editing on the shared state page
The access is to the specific `T` value found in the `Mutex<T>`.
2022-12-27 17:14:45 +01:00
Martin Geisler
aab767ca74
Merge pull request #48 from nofurtherinformation/darkmode-svg-text-fix
Dark Mode SVG Text Fix
2022-12-27 17:09:13 +01:00
Dylan
2ce32238b5 Fix svgbob diagrams in dark mode 2022-12-27 17:04:14 +01:00
Martin Geisler
d052db8874
Merge pull request #73 from janosh/fix-casing-types-bit-width
Fix casing in type bit widths
2022-12-27 16:46:57 +01:00
Martin Geisler
bc37d48cb0
Merge pull request #61 from pdecat/patch-1
Remove misplaced "calls"
2022-12-27 16:40:08 +01:00
Janosh Riebesell
cf695a99e3
fix casing in type bit widths 2022-12-26 19:35:09 -08:00
Matthew Maurer
506522179e
Merge pull request #59 from matm/patch-1
Fixes typo
2022-12-26 08:38:41 -08:00
Patrick Decat
b5cbe4896b
Remove misplaced "calls" 2022-12-26 11:22:00 +01:00
Mathias M
fe3651df02
Fixes typo 2022-12-26 09:12:00 +01:00
Martin Geisler
d9f1709036
Merge pull request #57 from zdimension/patch-2
Precise what the Android parts are about (fixes #56)
2022-12-25 20:13:47 +01:00
Tom Niget
f82867b2bb
Precise what the Android parts are about (fixes #56) 2022-12-25 17:12:42 +01:00
Arthur Milchior
2b2e006417 Typo
Not sure of the intended meaning. At least the sentence is true and gramattically correct here
2022-12-24 20:39:48 -08:00
Arthur Milchior
94933b43f1
Typos 2022-12-24 20:23:43 -08:00
Martin Geisler
8f638d8c4a
Merge pull request #51 from jswalden/patch-1
Insert "a" in a sentence that's missing it
2022-12-24 10:17:52 +01:00
Jeff Walden
75f6d0b5bd
Insert "a" in a sentence that's missing it 2022-12-23 23:05:21 -08:00
Ilya Grigoriev
5ce7a08f0e
anyhow: say this example has fewer custom types 2022-12-23 13:35:40 -08:00
Ilya Grigoriev
894e694cdb
anyhow: Remove ReadUsernameError::IoError
As far as I understand, the example with the `anyhow` example
does not use its special `IoError` anymore, unlike the previous
example with just `thiserror`.

I think this should be made clear. I considered just adding a
`// Now unused` comment, but I think ti's clearer to just remove
the unused code.
2022-12-23 13:32:03 -08:00
Martin Geisler
0218fdb1f0
Merge pull request #46 from matm/patch-1
Fixes typo in comment
2022-12-23 14:26:30 +01:00
Martin Geisler
80edc895db
Merge pull request #42 from reillyeon/patch-2
Change "semantics is" to "semantics are"
2022-12-23 12:57:32 +01:00
Martin Geisler
cc6c7e63fe
Merge pull request #47 from google/build-version-numbers
Install specific mdbook version in build action
2022-12-23 12:50:48 +01:00
Martin Geisler
a9ca0c860a Install specific mdbook version in build action
Like in #30, we should install a known-good version of `mdbook` and
`mdbook-svgbob` when testing PRs.
2022-12-23 12:42:55 +01:00
Martin Geisler
2b91c8c818
Merge pull request #44 from drgnchan/patch-1
Fix grammer in references-dangling.md
2022-12-23 12:41:59 +01:00
Mathias M
69cd18f12a
Fixes typo in comment 2022-12-23 12:03:03 +01:00
Martin Geisler
61aa12e3f3
Merge pull request #27 from taufik-rama/docs/rustup-installation
Mention rustup.rs on the installation page

Fixes #19.
2022-12-23 11:41:30 +01:00
Martin Geisler
1b59aa5d71
Merge pull request #45 from Arthur-Milchior/patch-3
Makes ownership of `self` more accurate
2022-12-23 11:39:08 +01:00
Martin Geisler
952e778527
Merge pull request #43 from reillyeon/patch-3
Grammar fix in ownership/lifetimes-function-calls.md
2022-12-23 11:34:51 +01:00