1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-06-15 13:50:27 +02:00
Commit Graph

2249 Commits

Author SHA1 Message Date
59e4a912ca Merge pull request #113 from google/no-speaker-notes-on-mobile
Hide speaker note popup link on mobile
2023-01-05 10:08:15 +01:00
34f28cd4a0 Merge pull request #114 from yesenarman/patch-2
Fix a typo in `result.md`
2023-01-05 08:47:44 +00:00
e1c670c4a8 Fix a typo in result.md
"have already see" -> "have already seen"
2023-01-05 14:41:40 +06:00
8feb6b4ad4 Merge pull request #109 from rhapsodyai/fixes-99
Fixes: #99
2023-01-05 09:08:03 +01:00
019e464ba8 Hide speaker note popup link on mobile
This uses the same media query as the rest of the mdbook theme:
devices with a width less than 1080px (mobiles) will not see the link
to open speaker notes in a new window.
2023-01-05 08:27:19 +01:00
986d607d1e Show speaker notes as closed by default
This makes it clearer that the notes are extra content.
2023-01-05 08:06:09 +01:00
15f88b3700 Merge pull request #107 from google/speaker-notes
Add support for speaker notes
2023-01-05 07:48:01 +01:00
d5359fa92a Add support for speaker notes
This implements a system for speaker notes via `details` elements and
some JavaScript. The general idea is

1. You add speaker notes to each page by wrapping some Markdown code
   in `<details> … </details>`. This is a standard HTML element for,
   well extra details. Browsers will render the element with a toggle
   control for showing/hiding the content.

2. We inject JavaScript on every page which finds these speaker note
   elements. They’re styled slightly and we keep their open/closed
   state in a browser local storage. This ensures that you can keep
   them open/closed across page loads.

3. We add a link to the speaker notes which will open in a new tab.
   The URL is amended with `#speaker-notes-open`, which we detect in
   the new tab: we hide the other content in this case.
   Simultaneously, we hide the speaker notes in the original window.

4. When navigating to a new page, we signal this to the other window.
   We then navigate to the same page. The logic above kicks in and
   hides the right part of the content. This lets the users page
   through the course using either the regular window or the speaker
   notes — the result is the same and both windows stay in sync.

Tested in both Chrome and Firefox. When using a popup speaker note
window, the content loads more smoothly in Chrome, but it still works
fine in Firefox.

Fixes #53.
2023-01-05 07:46:18 +01:00
115c87d8fd Fixes: #99 2023-01-04 17:55:28 -08:00
28942d7b9f Merge pull request #36 from daym/patch-1
Tuples with "..." make no sense, so don't use them
2023-01-04 15:42:35 +00:00
9f46beafdb Merge pull request #105 from Adrian-Samoticha/patch-1
Fix typo in `modules.md`
2023-01-04 15:42:07 +00:00
1fb87d4b81 Merge pull request #106 from Adrian-Samoticha/patch-2
Fix typo in `visibility.md`
2023-01-04 15:41:59 +00:00
a0ad1eafa8 Fix typo in visibility.md 2023-01-04 15:58:34 +01:00
89ad1f6a65 Fix typo in modules.md 2023-01-04 15:44:37 +01:00
c2c11531a5 Merge pull request #96 from zhouwfang/simplify-solution-to-prefix-matching
Simplify the solution to prefix matching
2023-01-04 09:11:58 +01:00
bffd70a90e Merge pull request #104 from liao02x/patch-1
fix typo in deriving-error-enums.md
2023-01-04 09:10:18 +01:00
8d36a3bdd3 fix typo in deriving-error-enums.md 2023-01-03 21:18:30 -08:00
1fb0b0a46d Simplify solution to prefix matching. 2023-01-03 20:11:20 -08:00
eee3fb6302 Merge pull request #101 from google/course-target-audience
Explain who the course is for
2023-01-03 18:10:09 +01:00
571c87283d Explain how the course can be used
From a discussion on Twitter:
https://twitter.com/bluxte/status/1610297443324727298.
2023-01-03 16:55:33 +01:00
78766a6bf6 Merge pull request #98 from google/simplify-publish
Simplify the publish workflow
2023-01-03 15:57:50 +01:00
499657c830 Simplify the publish workflow
This removes a bunch of boiler-plate comments which were left from the
template I used originally.

It also simplifies the name to just “Publish” since I feel this fits
better for what we do here.
2023-01-03 15:49:21 +01:00
9d41acf22d Merge pull request #97 from google/cargo-test
Run `cargo test` on pull requests
2023-01-03 15:47:48 +01:00
a0a1398b9b Simplify workflow name
Now that we multiple jobs, this will look better in the GitHut output:
“Build / mdbook (pull_request)” and “Test / mdbook (pull_request)”.
2023-01-03 14:46:25 +01:00
6f49dcf2fe Add Cargo.lock
This captures a set of known-good dependencies for the provided
solutions.
2023-01-03 14:42:33 +01:00
1bfe3cf7a2 Run cargo test on pull requests
This uses the `Cargo.toml` file in the repository to test the provided
solutions.
2023-01-03 14:39:24 +01:00
2a92487bbd Merge pull request #94 from MaschitaG/patch-2
Unsafe Rust
2023-01-02 10:32:00 +01:00
b027db0241 Add back links to the Rust Book
I think it's important that we link the students to the full information about Unsafe Rust.
2023-01-02 10:30:40 +01:00
b2ae19b5fd Update static-and-const.md 2023-01-02 10:25:39 +01:00
1c1c3d38d8 Unsafe Rust
Unsafe Rust is mentioned in the course
2023-01-02 10:12:56 +01:00
12c110d172 Merge pull request #93 from Fosco1/patch-1
Corrected typo on receiver.md
2023-01-02 10:08:42 +01:00
9499ddb8f9 Merge pull request #92 from MaschitaG/patch-1
Update welcome.md
2023-01-02 10:06:46 +01:00
a4bd084e50 Corrected typo on receiver.md
https://dictionary.cambridge.org/it/grammatica/grammatica-britannico/it-s-or-its
2023-01-02 10:04:04 +01:00
a7461f805a Update welcome.md
Make the language more precise
2023-01-02 10:01:10 +01:00
a62c695fe3 Merge pull request #91 from sudonym1/patch-1
Correct compilation error in unit-tests.md
2023-01-02 09:04:41 +01:00
6cb3254cf1 Correct compilation error in unit-tests.md 2023-01-01 13:57:19 -08:00
51cbf29d92 Merge pull request #79 from riking/patch-1
comparison: copyedit 'delays' to 'delayed'
2022-12-31 12:35:24 +01:00
150e78a3f9 Rephrase destructor delays
After a discussion, it seems singular works well.
2022-12-31 12:33:57 +01:00
8a8f44b568 Merge pull request #89 from jswalden/patch-3
Typo in "Fearless Concurrency" intro
2022-12-31 12:27:00 +01:00
ce143ad031 Merge pull request #90 from jswalden/patch-4
Typo in concurrency exercises intro
2022-12-31 12:26:20 +01:00
1ae03443d5 "a classic problem", not "...problems" 2022-12-30 21:54:35 -08:00
9def3e371d Typo in "Fearless Concurrency" intro
"referred to a _fearless concurrency_" -> "referred to a*s* _fearless concurrency_"
2022-12-30 20:53:38 -08:00
d8fd38b88a Merge pull request #81 from google/utf-8-encoding
Mention that strings are UTF-8 encoded
2022-12-28 20:38:46 +01:00
d7a33f24a6 Merge pull request #83 from google/mention-arc
Mention `Arc` on `Rc` slide
2022-12-28 20:38:22 +01:00
4a0455f5bd Merge pull request #85 from der3318/update-test-cases-for-polygons
Better Test Case for Day 2 Polygon Exercise
2022-12-28 15:46:15 +01:00
6851a6b533 Show different tuple sizes 2022-12-28 15:41:08 +01:00
0b77fc6bf3 20221228 revert the points length check 2022-12-28 22:39:52 +08:00
7b98da490a Merge pull request #84 from yesenarman/patch-1
Fix a typo: "will be drop" -> "will be dropped"
2022-12-28 15:31:18 +01:00
42494f95ab 20221228 add one more point to the polygon 2022-12-28 21:49:01 +08:00
8470be86d0 Fix a typo 2022-12-28 18:58:23 +06:00