rust/ripgrep
1
0
Fork 0
mirror of https://github.com/BurntSushi/ripgrep.git synced 2025-01-29 22:01:04 +02:00
Code Issues Releases Activity

readme: encoding_rs's SIMD support is broken

Browse Source 
Add a note about it to the README.

Also, remove mention of the avx-accel feature since it no longer exists.
(bytecount now uses runtime detection to enable SIMD support.)

Fixes #1175
This commit is contained in:
Andrew Gallant 2019-01-24 06:58:28 -05:00
parent 47833b9ce7
commit 9a9f54d44c
No known key found for this signature in database
GPG Key ID: B2E3A4923F8B0D44
2 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
CHANGELOG.md
View File

@ -2,6 +2,15 @@
============ ============
TODO. TODO.
**BREAKING CHANGES**:
* The `avx-accel` feature of ripgrep has been removed since it is no longer
necessary. All uses of AVX in ripgrep are now enabled automatically via
runtime CPU feature detection. The `simd-accel` feature does remain
available, however, it is broken in the latest nightly release of Rust.
See [#1175](https://github.com/BurntSushi/ripgrep/issues/1175) for more
info.
Feature enhancements: Feature enhancements:
* [FEATURE #1099](https://github.com/BurntSushi/ripgrep/pull/1099): * [FEATURE #1099](https://github.com/BurntSushi/ripgrep/pull/1099):

24
README.md
View File

@ -383,19 +383,19 @@ $ ./target/release/rg --version
If you have a Rust nightly compiler and a recent Intel CPU, then you can enable If you have a Rust nightly compiler and a recent Intel CPU, then you can enable
additional optional SIMD acceleration like so: additional optional SIMD acceleration like so:
**WARNING**: Building with the `simd-accel` feature on the latest Rust nightly
does not work because the [`encoding_rs`](https://crates.io/crates/encoding_rs)
crate hasn't yet migrated to the new SIMD infrastructure, and the old SIMD
infrastructure no longer works on the latest nightly version of Rust.
``` ```
RUSTFLAGS="-C target-cpu=native" cargo build --release --features 'simd-accel avx-accel' RUSTFLAGS="-C target-cpu=native" cargo build --release --features 'simd-accel'
``` ```
If your machine doesn't support AVX instructions, then simply remove The `simd-accel` feature enables SIMD support in certain ripgrep dependencies
`avx-accel` from the features list. Similarly for SIMD (which corresponds (responsible for transcoding). They are not necessary to get SIMD optimizations
roughly to SSE instructions). for search; those are enabled automatically. Hopefully, some day, the
`simd-accel` feature will similarly become unnecessary.
The `simd-accel` and `avx-accel` features enable SIMD support in certain
ripgrep dependencies (responsible for counting lines and transcoding). They
are not necessary to get SIMD optimizations for search; those are enabled
automatically. Hopefully, some day, the `simd-accel` and `avx-accel` features
will similarly become unnecessary.
Finally, optional PCRE2 support can be built with ripgrep by enabling the Finally, optional PCRE2 support can be built with ripgrep by enabling the
`pcre2` feature: `pcre2` feature:
@ -404,8 +404,8 @@ Finally, optional PCRE2 support can be built with ripgrep by enabling the
$ cargo build --release --features 'pcre2' $ cargo build --release --features 'pcre2'
``` ```
(Tip: use `--features 'pcre2 simd-accel avx-accel'` to also include compile (Tip: use `--features 'pcre2 simd-accel'` to also include compile time SIMD
time SIMD optimizations, which will only work with a nightly compiler.) optimizations, which will only work with a nightly compiler.)
Enabling the PCRE2 feature works with a stable Rust compiler and will Enabling the PCRE2 feature works with a stable Rust compiler and will
attempt to automatically find and link with your system's PCRE2 library via attempt to automatically find and link with your system's PCRE2 library via