1
0
mirror of https://github.com/BurntSushi/ripgrep.git synced 2025-05-13 21:26:27 +02:00

couple of trivial fixes to make clippy a bit more happy (#704)

clippy: fix a few lints

The fixes are:

  * Use single quotes for single-character
  * Use ticks in documentation when necessary.
  * Just bow to clippy's wisdom.
This commit is contained in:
Igor Gnatenko 2017-12-30 22:06:16 +01:00 committed by Andrew Gallant
parent 03b0d832ed
commit a5855a5d73
4 changed files with 10 additions and 9 deletions

View File

@ -327,16 +327,17 @@ impl<'a, R: io::Read, W: WriteColor> Searcher<'a, R, W> {
#[inline(always)] #[inline(always)]
fn fill(&mut self) -> Result<bool, Error> { fn fill(&mut self) -> Result<bool, Error> {
let mut keep = self.inp.lastnl; let keep = if self.opts.before_context > 0 || self.opts.after_context > 0 {
if self.opts.before_context > 0 || self.opts.after_context > 0 {
let lines = 1 + cmp::max( let lines = 1 + cmp::max(
self.opts.before_context, self.opts.after_context); self.opts.before_context, self.opts.after_context);
keep = start_of_previous_lines( start_of_previous_lines(
self.opts.eol, self.opts.eol,
&self.inp.buf, &self.inp.buf,
self.inp.lastnl.saturating_sub(1), self.inp.lastnl.saturating_sub(1),
lines); lines)
} } else {
self.inp.lastnl
};
if keep < self.last_printed { if keep < self.last_printed {
self.last_printed -= keep; self.last_printed -= keep;
} else { } else {

View File

@ -14,8 +14,8 @@ enum State {
/// Unescapes a string given on the command line. It supports a limited set of /// Unescapes a string given on the command line. It supports a limited set of
/// escape sequences: /// escape sequences:
/// ///
/// * \t, \r and \n are mapped to their corresponding ASCII bytes. /// * `\t`, `\r` and `\n` are mapped to their corresponding ASCII bytes.
/// * \xZZ hexadecimal escapes are mapped to their byte. /// * `\xZZ` hexadecimal escapes are mapped to their byte.
pub fn unescape(s: &str) -> Vec<u8> { pub fn unescape(s: &str) -> Vec<u8> {
use self::State::*; use self::State::*;

View File

@ -62,7 +62,7 @@ fn paths(unix: &[&str]) -> Vec<String> {
fn paths_from_stdout(stdout: String) -> Vec<String> { fn paths_from_stdout(stdout: String) -> Vec<String> {
let mut paths: Vec<_> = stdout.lines().map(|s| { let mut paths: Vec<_> = stdout.lines().map(|s| {
s.split(":").next().unwrap().to_string() s.split(':').next().unwrap().to_string()
}).collect(); }).collect();
paths.sort(); paths.sort();
paths paths

View File

@ -13,7 +13,7 @@ use std::time::Duration;
static TEST_DIR: &'static str = "ripgrep-tests"; static TEST_DIR: &'static str = "ripgrep-tests";
static NEXT_ID: AtomicUsize = ATOMIC_USIZE_INIT; static NEXT_ID: AtomicUsize = ATOMIC_USIZE_INIT;
/// WorkDir represents a directory in which tests are run. /// `WorkDir` represents a directory in which tests are run.
/// ///
/// Directories are created from a global atomic counter to avoid duplicates. /// Directories are created from a global atomic counter to avoid duplicates.
#[derive(Debug)] #[derive(Debug)]