mirror of
https://github.com/BurntSushi/ripgrep.git
synced 2024-12-07 11:13:17 +02:00
a7d26c8f14
This commit attempts to surface binary filtering in a slightly more user friendly way. Namely, before, ripgrep would silently stop searching a file if it detected a NUL byte, even if it had previously printed a match. This can lead to the user quite reasonably assuming that there are no more matches, since a partial search is fairly unintuitive. (ripgrep has this behavior by default because it really wants to NOT search binary files at all, just like it doesn't search gitignored or hidden files.) With this commit, if a match has already been printed and ripgrep detects a NUL byte, then it will print a warning message indicating that the search stopped prematurely. Moreover, this commit adds a new flag, --binary, which causes ripgrep to stop filtering binary files, but in a way that still avoids dumping binary data into terminals. That is, the --binary flag makes ripgrep behave more like grep's default behavior. For files explicitly specified in a search, e.g., `rg foo some-file`, then no binary filtering is applied (just like no gitignore and no hidden file filtering is applied). Instead, ripgrep behaves as if you gave the --binary flag for all explicitly given files. This was a fairly invasive change, and potentially increases the UX complexity of ripgrep around binary files. (Before, there were two binary modes, where as now there are three.) However, ripgrep is now a bit louder with warning messages when binary file detection might otherwise be hiding potential matches, so hopefully this is a net improvement. Finally, the `-uuu` convenience now maps to `--no-ignore --hidden --binary`, since this is closer to the actualy intent of the `--unrestricted` flag, i.e., to reduce ripgrep's smart filtering. As a consequence, `rg -uuu foo` should now search roughly the same number of bytes as `grep -r foo`, and `rg -uuua foo` should search roughly the same number of bytes as `grep -ra foo`. (The "roughly" weasel word is used because grep's and ripgrep's binary file detection might differ somewhat---perhaps based on buffer sizes---which can impact exactly what is and isn't searched.) See the numerous tests in tests/binary.rs for intended behavior. Fixes #306, Fixes #855
23 lines
585 B
Rust
23 lines
585 B
Rust
// Macros useful for testing.
|
|
#[macro_use]
|
|
mod macros;
|
|
|
|
// Corpora.
|
|
mod hay;
|
|
// Utilities for making tests nicer to read and easier to write.
|
|
mod util;
|
|
|
|
// Tests for ripgrep's handling of binary files.
|
|
mod binary;
|
|
// Tests related to most features in ripgrep. If you're adding something new
|
|
// to ripgrep, tests should probably go in here.
|
|
mod feature;
|
|
// Tests for ripgrep's JSON format.
|
|
mod json;
|
|
// Miscellaneous tests grouped in a haphazard manner. Try not to add more.
|
|
mod misc;
|
|
// Tests for ripgrep's multiline search support.
|
|
mod multiline;
|
|
// Regression tests.
|
|
mod regression;
|