2801: #2799 was incomplete, this brings master in line with what's released r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Need this too.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2807: Fix typo r=mergify[bot] a=strugee
## What type of PR?
Documentation
## What does this PR do?
Typo fix; see diff
### Related issue(s)
None
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: AJ Jordan <alex@strugee.net>
2808: Ensure SCAN_MACROS works r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Ensure SCAN_MACROS works
### Related issue(s)
- closes#2805
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2799: Fix roundcube's spellchecker r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Without this only 'English' is offered.
### Related issue(s)
- close#2798
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2794: Fix logs in the SMTP container r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
- #2771 broke logging in the postfix container. This fixes it
- The health-check of Dovecot is creating a zillion zombies... this simplifies it.
- Document that COMPRESSION=zstd can be used
### Related issue(s)
- #2771
- #2139
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2791: LD_PRELOAD may not be in ENV r=nextgens a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
In front, config.py can be called several times. LD_PRELOAD may have already been removed from ENV
### Related issue(s)
- close#2789
- #2541
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2786: adapted to v2 release and a docker change r=mergify[bot] a=elandorr
- v2 changed the path
- docker deprecated/removed the scale command, you have to do it like this now
## What type of PR?
documentation
Co-authored-by: elandorr <56206745+elandorr@users.noreply.github.com>
2772: Always exempt app-tokens from rate limits r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Always exempt app-tokens from rate limits
Ensure that unsuccessful login attempts against a valid account hit the ip-based rate-limit too
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2771: Sanitize logs as appropriate r=mergify[bot] a=nextgens
## What type of PR?
enhancement
## What does this PR do?
- Sanitize logs as appropriate.
- change the healthcheck of radicale to something less verbose
- disable hardened-malloc if we detect a processor not supporting the AVX extension set
Should we backport something like that? It could be argued it's a bugfix.
### Related issue(s)
- close#2644
- close#2764
- #2541
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2777: Whitelist all mailso* stream types in snuffleupagus for snappymail r=mergify[bot] a=Nebukadneza
## What type of PR?
bug-fix
## What does this PR do?
For attachment download in snappymail to work, at least mailsoliteral is needed. The additionally used stream types (from looking at the snappymail source) have also been added, to ensure compatability with whatever feature might rely on them ….
### Context
I’m not sure the newly whitelisted stream types other than `mailsoliteral` are actually needed. Would like some input on that, so I’m creating a draft first ….
Also, should this go to `2.0` or both `2.0` and `master`?
### Related issue(s)
- closes#2776
## Prerequisites
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dario Ernst <dario.ernst@rommelag.com>
For attachment download in snappymail to work, at least mailsoliteral is
needed. The additionally used stream types (from looking at the
snappymail source) have also been added, to ensure compatability with
whatever feature might rely on them ….
2767: Fix#2720: make letsencrypt work when reverse proxies are misconfigured r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Letsencrypt only works if port 80 is reachable. Users behind reverse-proxies don't read instructions... this makes the common misconfiguration work too.
### Related issue(s)
- closes#2720
- closes#2766
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2756: POP3 is broken r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Add a test to show it's broken, then fix it.
### Related issue(s)
- close#2754
- close#2757
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2752: Fix config-import. Config with dkim key could not be imported. r=mergify[bot] a=Diman0
## What type of PR?
bug-fix
## What does this PR do?
Imports with dkim keys failed due to two bugs
- The situation where the DKIM key was included as \<hidden\> in the config.yml was not handled
- An attempt was made to byte encode a value that was already a byte encoded value
This PR fixes both issues. Now config yml's with valid dkim keys and dkim keys with value \<hidden\> can be imported again using config-import.
### Related issue(s)
- #2747
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2748: Improve ci by using intermediate images r=mergify[bot] a=Diman0
## What type of PR?
enhancement
## What does this PR do?
As discussed in the mailu-dev chat, to improve build times we should
1. First build the base image and push this to ghcr.io
2. Secondly at the same time build the assets images and push this to ghcr.io.
3. Simultanuously build all other images which use the base/assets image from ghcr.io.
I've made these changes to the build_test_deploy.yml file and build-ci.yml file.
https://github.com/Mailu/Mailu/actions/runs/4637399505
In the worst case the build time appears to be around ~13 minutes now.
- build-ci.hcl will be used only by the github workflow. This file is modified to pull the base/assets image from the registry.
- build.hcl is unmodified. This file can be used to build all images locally.
I changed the name of the build jobs to make sure they fit in the overview list when viewing the action on github. You can now actually identify what job is run for what matrix target.
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [n/a ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>