1
0
mirror of https://github.com/Mailu/Mailu.git synced 2024-12-12 10:45:38 +02:00
Commit Graph

3366 Commits

Author SHA1 Message Date
Maximilian Fischer
8775dc5b15 Fixing AUTH_RATELIMIT_IP not working on imap/pop3/smtp
#2283
2022-03-17 20:36:23 +01:00
bors[bot]
0b25854de0
Merge #2210
2210: Add input validation for domain creation r=mergify[bot] a=0pc0deFR

## What type of PR?

bug-fix

## What does this PR do?

This patch add the input validation for domain creation.

### Related issue(s)
- Mention an issue like: #1817
- Auto close an issue like: closes #1817


Co-authored-by: Kevin Falcoz <0pc0defr@gmail.com>
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2022-03-12 12:34:30 +00:00
bors[bot]
43598119b8
Merge #2275
2275: Fix2274: Inbound emails are rejected r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

Fix email reception

### Related issue(s)
- closes #2274

## Prerequisites
No documentation as this affects only people running master since yesterday

Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2022-03-09 19:58:19 +00:00
Florent Daigniere
a7f9a35fa1
Merge branch 'master' into fix2274 2022-03-09 19:33:04 +01:00
Florent Daigniere
a4ed464170 doh 2022-03-09 19:29:39 +01:00
bors[bot]
fe7397bedf
Merge #2265
2265: Prevent an exception from being thrown if the username isn't an email address r=mergify[bot] a=nextgens

## What type of PR?

enhancement

## What does this PR do?

Mailu expects users to identify using an email address; some brute-force script don't send just an username and this leads to an exception... that makes the error message and return code vary.

This PR prevents the exceptions from being thrown in the first place

```
WARNING in nginx: Invalid user 'xxxx': (builtins.ValueError) invalid email address (no "`@")"`
```

### Related issue(s)
- closes #2261
- closes #1750

Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2022-03-08 12:15:28 +00:00
Florent Daigniere
0bfbb3bcd4
doh 2022-03-08 13:10:27 +01:00
Florent Daigniere
cd3eee4c51 ghostwheel42's suggestion 2022-03-07 09:09:36 +01:00
Florent Daigniere
d723326b8e style 2022-03-07 09:04:40 +01:00
Florent Daigniere
f01d8cd9b9 improve 2022-03-05 18:41:06 +01:00
Florent Daigniere
7b9c4e01f7 improve 2022-03-05 18:36:27 +01:00
Florent Daigniere
91de20c49c Fix exception in logs
This was occuring when you had square brackets in the domain part
2022-03-05 18:22:58 +01:00
Florent Daigniere
8cf76afbab Catch the ValueError instead 2022-03-05 18:01:30 +01:00
Florent Daigniere
08aa32a5df Revert "Don't bother running the query without an address"
This reverts commit dc81979550.
2022-03-05 17:59:44 +01:00
Florent Daigniere
7ce7f2096b belt, braces and suspenders 2022-03-05 14:54:54 +01:00
Florent Daigniere
dc81979550 Don't bother running the query without an address
This should solve the following in admin logs:
"WARNING in nginx: Invalid user 'xxxx': (builtins.ValueError)
invalid email address (no "@")"
2022-03-05 14:33:20 +01:00
bors[bot]
2e9b14d536
Merge #2254
2254: Send ISRG_X1 on port 25, make DANE pin that r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

Ensure we send ISRG_X1 in the handshake on port 25 (non-interactive, size doesn't really matter).

Update the DANE pin to reflect the change.

I am not sure whether we will need to add --preferred-chain= in the future; This may be the case when letsencrypt decides to use X2/the ECDSA chain

This needs to be tested on a letsencrypt account that isn't mine (I'm opted in for the alternate cert chains)

### Related issue(s)
- closes #2138

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

There's already a towncrier news for it

Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2022-02-24 13:22:57 +00:00
Florent Daigniere
f9869b1d79 ghostwheel42's suggestions 2022-02-24 12:45:30 +01:00
bors[bot]
cac9b48027
Merge #2253
2253: Workaround the infamous coredns feature r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

Ensure that we set the ``DO`` flag on our queries to work around https://github.com/coredns/coredns/issues/5189

Add a FAQ entry to point users in the right direction in other cases (dnsmasq), discourage users from running Mailu without unbound

### Related issue(s)
- closes #2243
- closes #2239
- #2164
- #2163
- #2162
- #2135
- #1988

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2022-02-23 12:14:05 +00:00
Dimitri Huisman
c40a0f4b80 Change link in warning to master. Master is always available. 1.9 will be unavaiable in the future. 2022-02-23 10:48:53 +00:00
Dimitri Huisman
dfd5e441bd Fix resolver warning message not being displayed in setup. 2022-02-23 10:41:08 +00:00
Florent Daigniere
0abbf2ba4a untested but it should work 2022-02-22 13:23:01 +01:00
Florent Daigniere
ab35492589 the first time the loop runs we don't have the second cert 2022-02-20 12:02:30 +01:00
Florent Daigniere
0816cb9497 simplify as per ghostwheel42's suggestion 2022-02-20 11:56:21 +01:00
Florent Daigniere
e4a32b55f5 Send ISRG_X1 on port 25, make DANE pin that 2022-02-19 14:35:45 +01:00
Florent Daigniere
1364451a9e towncrier 2022-02-19 13:32:10 +01:00
Florent Daigniere
d3e7ea5389 spell it out 2022-02-19 13:30:36 +01:00
Florent Daigniere
a8dc20962a workaround a bug in coredns 2022-02-19 13:02:52 +01:00
bors[bot]
9a99f4253b
Merge #2251
2251: Fix broken setup. Not all dependencies were pinned. As usual a depend… r=mergify[bot] a=Diman0

…ency had a breaking update.

## What type of PR?

bug-fix

## What does this PR do?
The dependencies pulled in by the python packages required for setup were not pinned. Unfortunately one of the dependencies had a breaking update. This PR also pins all dependencies to the last working version.

### Related issue(s)
- closes #2249 

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2022-02-18 21:20:00 +00:00
Dimitri Huisman
874a0ad24c Fix broken setup. Not all dependencies were pinned. As usual a dependency had a breaking update. 2022-02-18 21:06:53 +00:00
bors[bot]
921cab60de
Merge #2185
2185: Update reverse.rst r=mergify[bot] a=audioscavenger

updated the external proxy location pattern and added a note: do not add a ``/`` at the end

## What type of PR?

documentation

## What does this PR do?

### Related issue(s)
- did not bother to create an issue

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] i would like to add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file but i don't know how


Co-authored-by: Eric <dev@derewonko.com>
2022-02-18 11:02:43 +00:00
bors[bot]
bcecbda9de
Merge #2195
2195: roundcube: Add /overrides directory in include r=mergify[bot] a=mnival

Added the /overrides directory in the roundcube config.inc.php file

## What type of PR?

bug-fix

## What does this PR do?

### Related issue(s)
none

Co-authored-by: mnival <1595998+mnival@users.noreply.github.com>
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2022-02-18 10:42:17 +00:00
Dimitri Huisman
731a3741ca Update overrides faq for include roundcube 2022-02-17 14:28:41 +00:00
bors[bot]
b73963aae5
Merge #2207
2207: Update webmail container configuration to support MESSAGE_SIZE_LIMIT r=mergify[bot] a=marioja

## What type of PR?

bug-fix

## What does this PR do?

### Related issue(s)
- Auto close an issue like: closes #2186 

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Mario Jauvin <marioja@users.noreply.github.com>
2022-02-17 14:04:59 +00:00
Dimitri Huisman
55a601de5a Add missing import for validators, improve behaviour when an error occurs. 2022-02-17 13:09:15 +00:00
bors[bot]
c83457a2fa
Merge #2216
2216: Add iptables+ipset as additional FAQ entry for fail2ban r=mergify[bot] a=tkaefer

## What type of PR?

(Feature, enhancement, bug-fix, documentation)

## What does this PR do?

### Related issue(s)
 closes #2214 

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Tobias Käfer <tobias@tkaefer.de>
2022-02-17 13:02:11 +00:00
Dimitri Huisman
7d801c560c Improve if statement 2022-02-17 12:45:35 +00:00
Tobias Käfer
314145868c Include review suggestions 2022-02-14 10:38:26 +01:00
Mario Jauvin
490e27e229 Start fastcgi process manager after config files updated 2022-02-13 20:40:08 -05:00
bors[bot]
6d348b1650
Merge #2196
2196: roundcube-carddav : Use des_key for pwstore_scheme  r=nextgens a=mnival

roundcube-carddav: Configuring pwstore_scheme in carddav plugin with des_key because Mailu is incompatible with encrypted

https://github.com/mstilkerich/rcmcarddav/blob/master/doc/ADMIN-SETTINGS.md#password-storing-scheme

## What type of PR?

bug-fix

## What does this PR do?

### Related issue(s)
- closes #2230

Co-authored-by: mnival <1595998+mnival@users.noreply.github.com>
2022-02-13 15:56:38 +00:00
bors[bot]
eb11292aa6
Merge #2234
2234: fix #2220 r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

Fix the CI. I don't understand webpack well enough but that does the trick.

### Related issue(s)
- close #2220

Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2022-02-13 15:26:45 +00:00
Florent Daigniere
9466ad4131 fix #2220 2022-02-13 15:40:20 +01:00
bors[bot]
ea7c743797
Merge #2209
2209: Change URL dashboard in DKIM/SPF & DMARC Entries r=mergify[bot] a=0pc0deFR

## What type of PR?

documentation

## What does this PR do?

Example URL correction in documentation of DKIM/SPF & DMARC Entries

### Related issue(s)
- Mention an issue like: #2123
- Auto close an issue like: closes #2123

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ X] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Kevin Falcoz <0pc0defr@gmail.com>
2022-02-07 09:29:27 +00:00
Kevin Falcoz
69ce21c353
Create 2210.bugfix 2022-02-04 15:12:04 +01:00
Mario Jauvin
c8d3d1b611
Merge branch 'Mailu:master' into master 2022-02-03 21:29:10 -05:00
Tobias Käfer
e274ee762f Update fail2ban faq doc 2022-02-03 20:51:45 +01:00
bors[bot]
855f3b065b
Merge #2211
2211: Ensure we use IMAP IDLE like it's supposed to work r=mergify[bot] a=nextgens

## What type of PR?

enhancement

## What does this PR do?

Increase IMAP IDLE time from 2min to 29mins: this should massively help reduce network traffic & increase battery life of clients

See https://peterkieser.com/2011/03/25/androids-k-9-mail-battery-life-and-dovecots-push-imap/

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2022-02-03 12:44:25 +00:00
Florent Daigniere
224880822f
remove space 2022-02-03 11:31:33 +01:00
bors[bot]
9742f002e3
Merge #2206
2206: Patch function "Display Name" into admin page r=mergify[bot] a=0pc0deFR

## What type of PR?

bug-fix

## What does this PR do?

This PR is bug-fix for #2100 

### Related issue(s)
- Mention an issue like: #2100
- Auto close an issue like: closes #2100


Co-authored-by: Kevin Falcoz <0pc0defr@gmail.com>
Co-authored-by: Kevin Falcoz <0pc0deFR@gmail.com>
2022-02-01 17:43:03 +00:00
Florent Daigniere
3d7b9fe194 Ensure we use IMAP IDLE like it's supposed to work
imap_idle_notify_interval = 2 mins -> 29 mins

See https://peterkieser.com/2011/03/25/androids-k-9-mail-battery-life-and-dovecots-push-imap/
2022-02-01 18:17:34 +01:00