self-hosted/Sonarr
1
0
Fork 0
mirror of https://github.com/Sonarr/Sonarr.git synced 2024-12-16 11:37:58 +02:00
Code Issues Releases Activity

Cleanup Multiple Compiler Warnings

Browse Source
This commit is contained in:
Qstick 2019-08-07 22:08:03 -04:00 committed by Mark McDowall
parent fa8b8cebf9
commit 0c1ce66053
31 changed files with 23 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/NzbDrone.Api.Test/NzbDrone.Api.Test.csproj
View File

@ -50,10 +50,6 @@
<Reference Include="FluentAssertions.Core, Version=4.19.0.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a, processorArchitecture=MSIL">
<HintPath>..\packages\FluentAssertions.4.19.0\lib\net40\FluentAssertions.Core.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<Private>True</Private>
<HintPath>..\packages\FluentAssertions.4.19.0\lib\net45\FluentAssertions.Core.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL" />
<Reference Include="nunit.framework, Version=3.6.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">
<HintPath>..\packages\NUnit.3.6.0\lib\net45\nunit.framework.dll</HintPath>

3
src/NzbDrone.Api/NzbDrone.Api.csproj
View File

@ -75,9 +75,6 @@
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="Omu.ValueInjecter">
<HintPath>..\packages\ValueInjecter.2.3.3\lib\net35\Omu.ValueInjecter.dll</HintPath>
</Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="..\NzbDrone.Common\Properties\SharedAssemblyInfo.cs">

3
src/NzbDrone.App.Test/NzbDrone.Host.Test.csproj
View File

@ -49,9 +49,6 @@
<Reference Include="FluentAssertions.Core, Version=4.19.0.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a, processorArchitecture=MSIL">
<HintPath>..\packages\FluentAssertions.4.19.0\lib\net45\FluentAssertions.Core.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
<Private>True</Private>

4
src/NzbDrone.Automation.Test/AutomationTest.cs
View File

@ -31,7 +31,7 @@ public AutomationTest()
LogManager.Configuration.LoggingRules.Add(new LoggingRule("*", NLog.LogLevel.Trace, consoleTarget));
}
[TestFixtureSetUp]
[OneTimeSetUp]
public void SmokeTestSetup()
{
driver = new FirefoxDriver();
@ -56,7 +56,7 @@ protected IEnumerable<string> GetPageErrors()
.Select(e => e.Text);
}
[TestFixtureTearDown]
[OneTimeTearDown]
public void SmokeTestTearDown()
{
_runner.KillAll();

3
src/NzbDrone.Common.Test/NzbDrone.Common.Test.csproj
View File

@ -46,9 +46,6 @@
<Reference Include="FluentAssertions.Core, Version=4.19.0.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a, processorArchitecture=MSIL">
<HintPath>..\packages\FluentAssertions.4.19.0\lib\net45\FluentAssertions.Core.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
<Private>True</Private>

3
src/NzbDrone.Console/NzbDrone.Console.csproj
View File

@ -82,9 +82,6 @@
</Reference>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="Owin">
<HintPath>..\packages\Owin.1.0\lib\net40\Owin.dll</HintPath>
</Reference>
<Reference Include="Owin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=f0ebd12fd5e55cc5, processorArchitecture=MSIL">
<HintPath>..\packages\Owin.1.0\lib\net40\Owin.dll</HintPath>
</Reference>

2
src/NzbDrone.Core.Test/Datastore/Converters/Int32ConverterFixture.cs
View File

@ -15,7 +15,7 @@ public void should_return_int_when_saving_int_to_db()
{
var i = 5;
Subject.ToDB(5).Should().Be(5);
Subject.ToDB(i).Should().Be(5);
}
[Test]

2
src/NzbDrone.Core.Test/MediaFiles/EpisodeImport/Aggregation/Aggregators/AggregateQualityFixture.cs
View File

@ -18,8 +18,6 @@ public class AugmentQualityFixture : CoreTest<AggregateQuality>
private Mock<IAugmentQuality> _fileExtensionAugmenter;
private Mock<IAugmentQuality> _nameAugmenter;
private IEnumerable<IAugmentQuality> _qualityAugmenters;
[SetUp]
public void Setup()
{

7
src/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj
View File

@ -75,13 +75,6 @@
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="NCrunch.Framework, Version=3.2.0.3, Culture=neutral, PublicKeyToken=01d101bf6f3e0aea, processorArchitecture=MSIL">
<HintPath>..\packages\NCrunch.Framework.3.2.0.3\lib\NCrunch.Framework.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">

2
src/NzbDrone.Core.Test/OrganizerTests/FileNameBuilderTests/RequiresEpisodeTitleFixture.cs
View File

@ -2,7 +2,6 @@
using FizzWare.NBuilder;
using FluentAssertions;
using NUnit.Framework;
using NzbDrone.Core.MediaFiles;
using NzbDrone.Core.Organizer;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Core.Tv;
@ -14,7 +13,6 @@ public class RequiresEpisodeTitleFixture : CoreTest<FileNameBuilder>
{
private Series _series;
private Episode _episode;
private EpisodeFile _episodeFile;
private NamingConfig _namingConfig;
[SetUp]

2
src/NzbDrone.Core.Test/TvTests/RefreshEpisodeServiceFixture.cs
View File

@ -20,7 +20,7 @@ public class RefreshEpisodeServiceFixture : CoreTest<RefreshEpisodeService>
private List<Episode> _deletedEpisodes;
private Tuple<Series, List<Episode>> _gameOfThrones;
[TestFixtureSetUp]
[OneTimeSetUp]
public void TestFixture()
{
UseRealHttp();

4
src/NzbDrone.Core/Download/Clients/Hadouken/Hadouken.cs
View File

@ -160,7 +160,7 @@ private ValidationFailure TestConnection()
}
catch (DownloadClientAuthenticationException ex)
{
_logger.ErrorException(ex.Message, ex);
_logger.Error(ex, ex.Message);
return new NzbDroneValidationFailure("Password", "Authentication failed");
}
@ -176,7 +176,7 @@ private ValidationFailure TestGetTorrents()
}
catch (Exception ex)
{
_logger.ErrorException(ex.Message, ex);
_logger.Error(ex, ex.Message);
return new NzbDroneValidationFailure(String.Empty, "Failed to get the list of torrents: " + ex.Message);
}

3
src/NzbDrone.Core/Download/Clients/Hadouken/HadoukenProxy.cs
View File

@ -21,7 +21,6 @@ public interface IHadoukenProxy
public class HadoukenProxy : IHadoukenProxy
{
private static int _callId;
private readonly IHttpClient _httpClient;
private readonly Logger _logger;
@ -147,7 +146,7 @@ private HadoukenTorrent MapTorrent(object[] item)
}
catch(Exception ex)
{
_logger.ErrorException("Failed to map Hadouken torrent data.", ex);
_logger.Error(ex, "Failed to map Hadouken torrent data.");
}
return torrent;

2
src/NzbDrone.Core/Extras/Metadata/ExistingMetadataImporter.cs
View File

@ -73,7 +73,7 @@ public override IEnumerable<ExtraFile> ProcessFiles(Series series, List<string>
{
_aggregationService.Augment(localEpisode, false);
}
catch (AugmentingFailedException ex)
catch (AugmentingFailedException)
{
_logger.Debug("Unable to parse extra file: {0}", possibleMetadataFile);
continue;

2
src/NzbDrone.Core/Extras/Others/ExistingOtherExtraImporter.cs
View File

@ -58,7 +58,7 @@ public override IEnumerable<ExtraFile> ProcessFiles(Series series, List<string>
{
_aggregationService.Augment(localEpisode, false);
}
catch (AugmentingFailedException ex)
catch (AugmentingFailedException)
{
_logger.Debug("Unable to parse extra file: {0}", possibleExtraFile);
continue;

2
src/NzbDrone.Core/Extras/Subtitles/ExistingSubtitleImporter.cs
View File

@ -53,7 +53,7 @@ public override IEnumerable<ExtraFile> ProcessFiles(Series series, List<string>
{
_aggregationService.Augment(localEpisode, false);
}
catch (AugmentingFailedException ex)
catch (AugmentingFailedException)
{
_logger.Debug("Unable to parse extra file: {0}", possibleSubtitleFile);
continue;

2
src/NzbDrone.Core/Messaging/Commands/CommandExecutor.cs
View File

@ -51,7 +51,7 @@ private void ExecuteCommands()
_logger.Error(ex, "Thread aborted");
Thread.ResetAbort();
}
catch (OperationCanceledException ex)
catch (OperationCanceledException)
{
_logger.Trace("Stopped one command execution pipeline");
}

2
src/NzbDrone.Core/Notifications/Plex/PlexTv/PlexTvProxy.cs
View File

@ -68,7 +68,7 @@ private string ProcessRequest(HttpRequestBuilder requestBuilder)
{
throw new NzbDroneClientException(ex.Response.StatusCode, "Unable to connect to plex.tv");
}
catch (WebException ex)
catch (WebException)
{
throw new NzbDroneClientException(HttpStatusCode.BadRequest, "Unable to connect to plex.tv");
}

2
src/NzbDrone.Core/Tv/MoveSeriesService.cs
View File

@ -5,7 +5,6 @@
using NzbDrone.Core.Messaging.Commands;
using NzbDrone.Core.Messaging.Events;
using NzbDrone.Core.Organizer;
using NzbDrone.Core.RootFolders;
using NzbDrone.Core.Tv.Commands;
using NzbDrone.Core.Tv.Events;
@ -17,7 +16,6 @@ public class MoveSeriesService : IExecute<MoveSeriesCommand>, IExecute<BulkMoveS
private readonly IBuildFileNames _filenameBuilder;
private readonly IDiskProvider _diskProvider;
private readonly IDiskTransferService _diskTransferService;
private readonly IRootFolderService _rootFolderService;
private readonly IEventAggregator _eventAggregator;
private readonly Logger _logger;

3
src/NzbDrone.Host/NzbDrone.Host.csproj
View File

@ -96,9 +96,6 @@
<Reference Include="NLog, Version=4.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c, processorArchitecture=MSIL">
<HintPath>..\packages\NLog.4.5.3\lib\net45\NLog.dll</HintPath>
</Reference>
<Reference Include="NLog.Extensions.Logging, Version=1.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c, processorArchitecture=MSIL">
<HintPath>..\packages\NLog.Extensions.Logging.1.1.0\lib\net462\NLog.Extensions.Logging.dll</HintPath>
</Reference>
<Reference Include="Owin, Version=1.0.0.0, Culture=neutral, PublicKeyToken=f0ebd12fd5e55cc5, processorArchitecture=MSIL">
<HintPath>..\packages\Owin.1.0\lib\net40\Owin.dll</HintPath>
</Reference>

2
src/NzbDrone.Host/Owin/MiddleWare/NzbDroneVersionMiddleWare.cs
View File

@ -37,7 +37,7 @@ public override async Task Invoke(IOwinContext context)
context.Response.Headers.Add(_versionHeader);
await Next.Invoke(context);
}
catch (Exception ex)
catch (Exception)
{
Logger.Debug("Unable to set version header");
}

1
src/NzbDrone.Integration.Test/CorsFixture.cs
View File

@ -2,7 +2,6 @@
using NUnit.Framework;
using Sonarr.Http.Extensions;
using RestSharp;
using Sonarr.Http.Extensions;
namespace NzbDrone.Integration.Test
{

3
src/NzbDrone.Integration.Test/NzbDrone.Integration.Test.csproj
View File

@ -62,9 +62,6 @@
<Reference Include="Microsoft.Owin.Hosting, Version=3.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Microsoft.Owin.Hosting.3.1.0\lib\net45\Microsoft.Owin.Hosting.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
<Private>True</Private>

3
src/NzbDrone.Test.Common/NzbDrone.Test.Common.csproj
View File

@ -58,9 +58,6 @@
<Reference Include="Microsoft.Practices.Unity.Configuration, Version=2.1.505.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\packages\Unity.2.1.505.2\lib\NET35\Microsoft.Practices.Unity.Configuration.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
<Private>True</Private>

3
src/NzbDrone.Update.Test/NzbDrone.Update.Test.csproj
View File

@ -48,9 +48,6 @@
<Reference Include="FluentAssertions.Core, Version=4.19.0.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a, processorArchitecture=MSIL">
<HintPath>..\packages\FluentAssertions.4.19.0\lib\net45\FluentAssertions.Core.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
</Reference>
<Reference Include="Moq, Version=4.0.10827.0, Culture=neutral, PublicKeyToken=69f491c39445e920, processorArchitecture=MSIL">
<HintPath>..\packages\Moq.4.0.10827\lib\NET40\Moq.dll</HintPath>
<Private>True</Private>

1
src/Sonarr.Api.V3/EpisodeFiles/EpisodeFileModule.cs
View File

@ -23,7 +23,6 @@ public class EpisodeFileModule : SonarrRestModuleWithSignalR<EpisodeFileResource
{
private readonly IMediaFileService _mediaFileService;
private readonly IDeleteMediaFiles _mediaFileDeletionService;
private readonly IRecycleBinProvider _recycleBinProvider;
private readonly ISeriesService _seriesService;
private readonly IUpgradableSpecification _upgradableSpecification;

8
src/Sonarr.Api.V3/Profiles/Release/ReleaseProfileModule.cs
View File

@ -15,11 +15,11 @@ public ReleaseProfileModule(IReleaseProfileService releaseProfileService)
{
_releaseProfileService = releaseProfileService;
GetResourceById = Get;
GetResourceById = GetReleaseProfile;
GetResourceAll = GetAll;
CreateResource = Create;
UpdateResource = Update;
DeleteResource = Delete;
DeleteResource = DeleteReleaseProfile;
SharedValidator.Custom(restriction =>
{
@ -32,7 +32,7 @@ public ReleaseProfileModule(IReleaseProfileService releaseProfileService)
});
}
private ReleaseProfileResource Get(int id)
private ReleaseProfileResource GetReleaseProfile(int id)
{
return _releaseProfileService.Get(id).ToResource();
}
@ -52,7 +52,7 @@ private void Update(ReleaseProfileResource resource)
_releaseProfileService.Update(resource.ToModel());
}
private void Delete(int id)
private void DeleteReleaseProfile(int id)
{
_releaseProfileService.Delete(id);
}

4
src/Sonarr.Api.V3/Tags/TagDetailsModule.cs
View File

@ -13,11 +13,11 @@ public TagDetailsModule(ITagService tagService)
{
_tagService = tagService;
GetResourceById = Get;
GetResourceById = GetTagDetails;
GetResourceAll = GetAll;
}
private TagDetailsResource Get(int id)
private TagDetailsResource GetTagDetails(int id)
{
return _tagService.Details(id).ToResource();
}

8
src/Sonarr.Api.V3/Tags/TagModule.cs
View File

@ -17,14 +17,14 @@ public TagModule(IBroadcastSignalRMessage signalRBroadcaster,
{
_tagService = tagService;
GetResourceById = Get;
GetResourceById = GetTag;
GetResourceAll = GetAll;
CreateResource = Create;
UpdateResource = Update;
DeleteResource = Delete;
DeleteResource = DeleteTag;
}
private TagResource Get(int id)
private TagResource GetTag(int id)
{
return _tagService.GetTag(id).ToResource();
}
@ -44,7 +44,7 @@ private void Update(TagResource resource)
_tagService.Update(resource.ToModel());
}
private void Delete(int id)
private void DeleteTag(int id)
{
_tagService.Delete(id);
}

2
src/Sonarr.Http/Frontend/Mappers/BackupFileMapper.cs
View File

@ -1,7 +1,6 @@
using System.IO;
using NLog;
using NzbDrone.Common.Disk;
using NzbDrone.Common.EnvironmentInfo;
using NzbDrone.Core.Backup;
namespace Sonarr.Http.Frontend.Mappers
@ -9,7 +8,6 @@ namespace Sonarr.Http.Frontend.Mappers
public class BackupFileMapper : StaticResourceMapperBase
{
private readonly IBackupService _backupService;
private readonly IAppFolderInfo _appFolderInfo;
public BackupFileMapper(IBackupService backupService, IDiskProvider diskProvider, Logger logger)
: base(diskProvider, logger)

2
src/Sonarr.Http/TinyIoCNancyBootstrapper.cs
View File

@ -91,7 +91,6 @@ protected override sealed void RegisterTypes(TinyIoCContainer container, IEnumer
break;
case Lifetime.PerRequest:
throw new InvalidOperationException("Unable to directly register a per request lifetime.");
break;
default:
throw new ArgumentOutOfRangeException();
}
@ -118,7 +117,6 @@ protected override sealed void RegisterCollectionTypes(TinyIoCContainer containe
break;
case Lifetime.PerRequest:
throw new InvalidOperationException("Unable to directly register a per request lifetime.");
break;
default:
throw new ArgumentOutOfRangeException();
}