self-hosted/Sonarr
1
0
Fork 0
mirror of https://github.com/Sonarr/Sonarr.git synced 2024-12-16 11:37:58 +02:00
Code Issues Releases Activity

Fixed: Health Check produced warning if Sonarr binaries folder was not writable even when the external script update mechanism was selected.

Browse Source 
fixes #964
This commit is contained in:
Taloth Saldono 2015-12-27 20:40:37 +01:00
parent eaf3228bb7
commit 37c621dcdb
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/NzbDrone.Core.Test/HealthCheck/Checks/UpdateCheckFixture.cs
View File

@ -6,6 +6,7 @@
using NzbDrone.Core.Configuration;
using NzbDrone.Core.HealthCheck.Checks;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Core.Update;
namespace NzbDrone.Core.Test.HealthCheck.Checks
{
@ -47,5 +48,28 @@ public void should_return_error_when_app_folder_is_write_protected_and_update_au
Subject.Check().ShouldBeError();
}
[Test]
public void should_not_return_error_when_app_folder_is_write_protected_and_external_script_enabled()
{
MonoOnly();
Mocker.GetMock<IConfigFileProvider>()
.Setup(s => s.UpdateAutomatically)
.Returns(true);
Mocker.GetMock<IConfigFileProvider>()
.Setup(s => s.UpdateMechanism)
.Returns(UpdateMechanism.Script);
Mocker.GetMock<IAppFolderInfo>()
.Setup(s => s.StartUpFolder)
.Returns(@"/opt/nzbdrone");
Mocker.GetMock<NzbDrone.Common.Disk.IDiskProvider>()
.Verify(c => c.FolderWritable(Moq.It.IsAny<string>()), Times.Never());
Subject.Check().ShouldBeOk();
}
}
}

3
src/NzbDrone.Core/HealthCheck/Checks/UpdateCheck.cs
View File

@ -27,7 +27,8 @@ public UpdateCheck(IDiskProvider diskProvider,
public override HealthCheck Check()
{
if (OsInfo.IsWindows || _configFileProvider.UpdateAutomatically)
if ((OsInfo.IsWindows || _configFileProvider.UpdateAutomatically) &&
_configFileProvider.UpdateMechanism == UpdateMechanism.BuiltIn)
{
if (!_diskProvider.FolderWritable(_appFolderInfo.StartUpFolder))
{