self-hosted/Sonarr
1
0
Fork 0
mirror of https://github.com/Sonarr/Sonarr.git synced 2024-12-14 11:23:42 +02:00
Code Issues Releases Activity

Fixed tests/null reference for import lists

Browse Source
This commit is contained in:
Mark McDowall 2020-09-10 15:45:28 -07:00
parent b2b1600ebe
commit a92665c5cd
3 changed files with 85 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/NzbDrone.Core.Test/Languages/LanguageProfileServiceFixture.cs
View File

@ -1,7 +1,9 @@
using System.Linq;
using System.Collections.Generic;
using System.Linq;
using FizzWare.NBuilder;
using Moq;
using NUnit.Framework;
using NzbDrone.Core.ImportLists;
using NzbDrone.Core.Lifecycle;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Core.Tv;
@ -13,6 +15,14 @@ namespace NzbDrone.Core.Test.Languages
public class LanguageProfileServiceFixture : CoreTest<LanguageProfileService>
{
[SetUp]
public void Setup()
{
Mocker.GetMock<IImportListFactory>()
.Setup(s => s.All())
.Returns(new List<ImportListDefinition>());
}
[Test]
public void init_should_add_default_profiles()
{
@ -52,10 +62,8 @@ public void should_not_be_able_to_delete_profile_if_assigned_to_series()
Assert.Throws<LanguageProfileInUseException>(() => Subject.Delete(2));
Mocker.GetMock<ILanguageProfileRepository>().Verify(c => c.Delete(It.IsAny<int>()), Times.Never());
}
[Test]
public void should_delete_profile_if_not_assigned_to_series()
{
@ -71,5 +79,31 @@ public void should_delete_profile_if_not_assigned_to_series()
Mocker.GetMock<ILanguageProfileRepository>().Verify(c => c.Delete(1), Times.Once());
}
[Test]
public void should_not_be_able_to_delete_profile_if_assigned_to_import_list()
{
var seriesList = Builder<Series>.CreateListOfSize(3)
.Random(1)
.With(c => c.LanguageProfileId = 2)
.Build().ToList();
var importLists = Builder<ImportListDefinition>.CreateListOfSize(3)
.Random(1)
.With(c => c.LanguageProfileId = 1)
.Build().ToList();
Mocker.GetMock<ISeriesService>().Setup(c => c.GetAllSeries()).Returns(seriesList);
Mocker.GetMock<IImportListFactory>()
.Setup(s => s.All())
.Returns(importLists);
Assert.Throws<LanguageProfileInUseException>(() => Subject.Delete(1));
Mocker.GetMock<ILanguageProfileRepository>().Verify(c => c.Delete(It.IsAny<int>()), Times.Never());
}
}
}

45
src/NzbDrone.Core.Test/Profiles/ProfileServiceFixture.cs → src/NzbDrone.Core.Test/Profiles/QualityProfileServiceFixture.cs
View File

@ -1,7 +1,9 @@
using System.Collections.Generic;
using System.Linq;
using FizzWare.NBuilder;
using Moq;
using NUnit.Framework;
using NzbDrone.Core.ImportLists;
using NzbDrone.Core.Lifecycle;
using NzbDrone.Core.Profiles.Qualities;
using NzbDrone.Core.Test.Framework;
@ -10,8 +12,16 @@
namespace NzbDrone.Core.Test.Profiles
{
[TestFixture]
public class ProfileServiceFixture : CoreTest<QualityProfileService>
public class QualityProfileServiceFixture : CoreTest<QualityProfileService>
{
[SetUp]
public void Setup()
{
Mocker.GetMock<IImportListFactory>()
.Setup(s => s.All())
.Returns(new List<ImportListDefinition>());
}
[Test]
public void init_should_add_default_profiles()
{
@ -56,10 +66,8 @@ public void should_not_be_able_to_delete_profile_if_assigned_to_series()
Assert.Throws<QualityProfileInUseException>(() => Subject.Delete(profile.Id));
Mocker.GetMock<IProfileRepository>().Verify(c => c.Delete(It.IsAny<int>()), Times.Never());
}
[Test]
public void should_delete_profile_if_not_assigned_to_series()
{
@ -75,5 +83,36 @@ public void should_delete_profile_if_not_assigned_to_series()
Mocker.GetMock<IProfileRepository>().Verify(c => c.Delete(1), Times.Once());
}
[Test]
public void should_not_be_able_to_delete_profile_if_assigned_to_import_list()
{
var profile = Builder<QualityProfile>.CreateNew()
.With(p => p.Id = 1)
.Build();
var seriesList = Builder<Series>.CreateListOfSize(3)
.All()
.With(c => c.QualityProfileId = 2)
.Build().ToList();
var importLists = Builder<ImportListDefinition>.CreateListOfSize(3)
.Random(1)
.With(c => c.LanguageProfileId = 1)
.Build().ToList();
Mocker.GetMock<IProfileRepository>().Setup(c => c.Get(profile.Id)).Returns(profile);
Mocker.GetMock<ISeriesService>().Setup(c => c.GetAllSeries()).Returns(seriesList);
Mocker.GetMock<IImportListFactory>()
.Setup(s => s.All())
.Returns(importLists);
Assert.Throws<QualityProfileInUseException>(() => Subject.Delete(1));
Mocker.GetMock<IProfileRepository>().Verify(c => c.Delete(It.IsAny<int>()), Times.Never());
}
}
}

4
src/NzbDrone.Core/ImportLists/ImportListSyncService.cs
View File

@ -86,9 +86,13 @@ private void ProcessReports(List<ImportListItemInfo> reports)
{
var mappedSeries = _seriesSearchService.SearchForNewSeries(report.Title)
.FirstOrDefault();
if (mappedSeries != null)
{
report.TvdbId = mappedSeries.TvdbId;
report.Title = mappedSeries?.Title;
}
}
// Check to see if series in DB
var existingSeries = _seriesService.FindByTvdbId(report.TvdbId);