Mapped Network Drive Validator

New: Prevent adding Mapped Network Drives when Running as a Windows Services

src/NzbDrone.Api/Config/DownloadClientConfigModule.cs

@@ -7,16 +7,19 @@ namespace NzbDrone.Api.Config
 {
     public class DownloadClientConfigModule : NzbDroneConfigModule<DownloadClientConfigResource>
     {
-        public DownloadClientConfigModule(IConfigService configService, RootFolderValidator rootFolderValidator, PathExistsValidator pathExistsValidator)
+        public DownloadClientConfigModule(IConfigService configService,
+                                          RootFolderValidator rootFolderValidator,
+                                          PathExistsValidator pathExistsValidator,
+                                          MappedNetworkDriveValidator mappedNetworkDriveValidator)
             : base(configService)
         {
             SharedValidator.RuleFor(c => c.DownloadedEpisodesFolder)
                            .Cascade(CascadeMode.StopOnFirstFailure)
                            .IsValidPath()
                            .SetValidator(rootFolderValidator)
+                           .SetValidator(mappedNetworkDriveValidator)
                            .SetValidator(pathExistsValidator)
                            .When(c => !String.IsNullOrWhiteSpace(c.DownloadedEpisodesFolder));
-
         }
     }
 }

src/NzbDrone.Api/RemotePathMappings/RemotePathMappingModule.cs

@@ -11,7 +11,9 @@ public class RemotePathMappingModule : NzbDroneRestModule<RemotePathMappingResou
     {
         private readonly IRemotePathMappingService _remotePathMappingService;
 
-        public RemotePathMappingModule(IRemotePathMappingService remotePathMappingService, PathExistsValidator pathExistsValidator)
+        public RemotePathMappingModule(IRemotePathMappingService remotePathMappingService,
+                                       PathExistsValidator pathExistsValidator,
+                                       MappedNetworkDriveValidator mappedNetworkDriveValidator)
         {
             _remotePathMappingService = remotePathMappingService;
 
@@ -31,6 +33,7 @@ public RemotePathMappingModule(IRemotePathMappingService remotePathMappingServic
             SharedValidator.RuleFor(c => c.LocalPath)
                            .Cascade(CascadeMode.StopOnFirstFailure)
                            .IsValidPath()
+                           .SetValidator(mappedNetworkDriveValidator)
                            .SetValidator(pathExistsValidator);
         }
 

src/NzbDrone.Api/RootFolders/RootFolderModule.cs

@@ -15,7 +15,8 @@ public RootFolderModule(IRootFolderService rootFolderService,
                                 IBroadcastSignalRMessage signalRBroadcaster,
                                 RootFolderValidator rootFolderValidator,
                                 PathExistsValidator pathExistsValidator,
-                                DroneFactoryValidator droneFactoryValidator)
+                                DroneFactoryValidator droneFactoryValidator,
+                                MappedNetworkDriveValidator mappedNetworkDriveValidator)
             : base(signalRBroadcaster)
         {
             _rootFolderService = rootFolderService;
@@ -29,8 +30,9 @@ public RootFolderModule(IRootFolderService rootFolderService,
                            .Cascade(CascadeMode.StopOnFirstFailure)
                            .IsValidPath()
                            .SetValidator(rootFolderValidator)
-                           .SetValidator(pathExistsValidator)
+                           .SetValidator(droneFactoryValidator)
-                           .SetValidator(droneFactoryValidator);
+                           .SetValidator(mappedNetworkDriveValidator)
+                           .SetValidator(pathExistsValidator);
         }
 
         private RootFolderResource GetRootFolder(int id)

src/NzbDrone.Core/NzbDrone.Core.csproj

@@ -896,6 +896,7 @@
     <Compile Include="Validation\NzbDroneValidationFailure.cs" />
     <Compile Include="Validation\NzbDroneValidationResult.cs" />
     <Compile Include="Validation\NzbDroneValidationState.cs" />
+    <Compile Include="Validation\Paths\MappedNetworkDriveValidator.cs" />
     <Compile Include="Validation\Paths\DroneFactoryValidator.cs" />
     <Compile Include="Validation\Paths\PathExistsValidator.cs" />
     <Compile Include="Validation\Paths\PathValidator.cs" />

src/NzbDrone.Core/Validation/Paths/MappedNetworkDriveValidator.cs

@@ -0,0 +1,50 @@
+using System;
+using System.IO;
+using System.Text.RegularExpressions;
+using FluentValidation.Validators;
+using NzbDrone.Common.Disk;
+using NzbDrone.Common.EnvironmentInfo;
+
+namespace NzbDrone.Core.Validation.Paths
+{
+    public class MappedNetworkDriveValidator : PropertyValidator
+    {
+        private readonly IRuntimeInfo _runtimeInfo;
+        private readonly IDiskProvider _diskProvider;
+
+        private static readonly Regex DriveRegex = new Regex(@"[a-z]\:\\", RegexOptions.Compiled | RegexOptions.IgnoreCase);
+
+        public MappedNetworkDriveValidator(IRuntimeInfo runtimeInfo, IDiskProvider diskProvider)
+            : base("Mapped Network Drive and Windows Service")
+        {
+            _runtimeInfo = runtimeInfo;
+            _diskProvider = diskProvider;
+        }
+
+        protected override bool IsValid(PropertyValidatorContext context)
+        {
+            if (context.PropertyValue == null) return false;
+            if (OsInfo.IsNotWindows) return true;
+            if (!_runtimeInfo.IsWindowsService) return true;
+
+            var path = context.PropertyValue.ToString();
+
+            if (!DriveRegex.IsMatch(path)) return true;
+            
+            var drives = _diskProvider.GetDrives();
+
+            foreach (var drive in drives)
+            {
+                if (path.StartsWith(drive.Name, StringComparison.InvariantCultureIgnoreCase))
+                {
+                    if (drive.DriveType == DriveType.Network)
+                    {
+                        return false;
+                    }
+                }
+            }
+
+            return true;
+        }
+    }
+}