self-hosted/Sonarr
1
0
Fork 0
mirror of https://github.com/Sonarr/Sonarr.git synced 2024-12-14 11:23:42 +02:00
Code Issues Releases Activity

Fixed: Executing powershell and python scripts directly in Connect->Custom Scripts

Browse Source
This commit is contained in:
Taloth Saldono 2019-07-02 20:50:32 +02:00
parent c71b4bde86
commit df8ca250aa
2 changed files with 58 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/NzbDrone.Common.Test/ProcessProviderTests.cs
View File

@ -77,6 +77,54 @@ public void Should_be_able_to_start_process()
Subject.Exists(DummyApp.DUMMY_PROCCESS_NAME).Should().BeFalse();
}
[Test]
public void Should_be_able_to_start_powershell()
{
WindowsOnly();
var tempDir = GetTempFilePath();
var tempScript = Path.Combine(tempDir, "myscript.ps1");
Directory.CreateDirectory(tempDir);
File.WriteAllText(tempScript, "Write-Output 'Hello There'\r\n");
try
{
var result = Subject.StartAndCapture(tempScript);
result.Standard.First().Content.Should().Be("Hello There");
}
catch (Win32Exception ex) when (ex.NativeErrorCode == 2)
{
Assert.Fail("No Powershell available?!?");
}
}
[Test]
public void Should_be_able_to_start_python()
{
WindowsOnly();
var tempDir = GetTempFilePath();
var tempScript = Path.Combine(tempDir, "myscript.py");
Directory.CreateDirectory(tempDir);
File.WriteAllText(tempScript, "print(\"Hello There\")\r\n");
try
{
var result = Subject.StartAndCapture(tempScript);
result.Standard.First().Content.Should().Be("Hello There");
}
catch (Win32Exception ex) when (ex.NativeErrorCode == 2)
{
Assert.Inconclusive("No Python available");
}
}
[Test]
public void kill_all_should_kill_all_process_with_name()

10
src/NzbDrone.Common/Processes/ProcessProvider.cs
View File

@ -365,6 +365,16 @@ private List<Process> GetProcessesByName(string name)
return ("cmd.exe", $"/c {path} {args}");
}
if (OsInfo.IsWindows && path.EndsWith(".ps1", StringComparison.InvariantCultureIgnoreCase))
{
return ("powershell.exe", $"-ExecutionPolicy Bypass -NoProfile -File {path} {args}");
}
if (OsInfo.IsWindows && path.EndsWith(".py", StringComparison.InvariantCultureIgnoreCase))
{
return ("python.exe", $"{path} {args}");
}
return (path, args);
}
}