self-hosted/Sonarr
1
0
Fork 0
mirror of https://github.com/Sonarr/Sonarr.git synced 2024-12-16 11:37:58 +02:00
Code Issues Releases Activity

Fixed: Logging invalid version when failing to connect to Kodi

Browse Source 
Closes #927
This commit is contained in:
Mark McDowall 2015-11-14 22:34:56 -08:00
parent b02b9f026f
commit ea6ae85f7a
1 changed files with 18 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/NzbDrone.Core/Notifications/Xbmc/XbmcService.cs
View File

@ -1,6 +1,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Net;
using FluentValidation.Results; using FluentValidation.Results;
using Newtonsoft.Json.Linq; using Newtonsoft.Json.Linq;
using NLog; using NLog;
@ -58,12 +59,9 @@ public void Clean(XbmcSettings settings)
} }
private XbmcVersion GetJsonVersion(XbmcSettings settings) private XbmcVersion GetJsonVersion(XbmcSettings settings)
{
try
{ {
return _xbmcVersionCache.Get(settings.Address, () => return _xbmcVersionCache.Get(settings.Address, () =>
{ {
var response = _proxy.GetJsonVersion(settings); var response = _proxy.GetJsonVersion(settings);
_logger.Debug("Getting version from response: " + response); _logger.Debug("Getting version from response: " + response);
@ -71,22 +69,20 @@ private XbmcVersion GetJsonVersion(XbmcSettings settings)
var versionObject = result.Result.Property("version"); var versionObject = result.Result.Property("version");
if (versionObject.Value.Type == JTokenType.Integer) return new XbmcVersion((int) versionObject.Value); if (versionObject.Value.Type == JTokenType.Integer)
{
return new XbmcVersion((int)versionObject.Value);
}
if (versionObject.Value.Type == JTokenType.Object) return Json.Deserialize<XbmcVersion>(versionObject.Value.ToString()); if (versionObject.Value.Type == JTokenType.Object)
{
return Json.Deserialize<XbmcVersion>(versionObject.Value.ToString());
}
throw new InvalidCastException("Unknown Version structure!: " + versionObject); throw new InvalidCastException("Unknown Version structure!: " + versionObject);
}, TimeSpan.FromHours(12)); }, TimeSpan.FromHours(12));
} }
catch (Exception ex)
{
_logger.DebugException(ex.Message, ex);
}
return new XbmcVersion();
}
private IApiProvider GetApiProvider(XbmcSettings settings) private IApiProvider GetApiProvider(XbmcSettings settings)
{ {
var version = GetJsonVersion(settings); var version = GetJsonVersion(settings);