self-hosted/focalboard
1
0
Fork 0
mirror of https://github.com/mattermost/focalboard.git synced 2025-01-08 15:06:08 +02:00
Code Issues Releases Activity

Adds escaping when normalizing table names for MySQL on DB helpers (#4653)

Browse Source 
Co-authored-by: Mattermost Build <build@mattermost.com>
This commit is contained in:
Miguel de la Cruz 2023-03-27 13:56:39 +02:00 committed by GitHub
parent d8e1fb4832
commit 1fff221da9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
server/services/store/sqlstore/migrate.go
View File

@ -319,7 +319,7 @@ func (s *SQLStore) GetTemplateHelperFuncs() template.FuncMap {
func (s *SQLStore) genAddColumnIfNeeded(tableName, columnName, datatype, constraint string) (string, error) { func (s *SQLStore) genAddColumnIfNeeded(tableName, columnName, datatype, constraint string) (string, error) {
tableName = addPrefixIfNeeded(tableName, s.tablePrefix) tableName = addPrefixIfNeeded(tableName, s.tablePrefix)
normTableName := normalizeTablename(s.schemaName, tableName) normTableName := s.normalizeTablename(tableName)
switch s.dbType { switch s.dbType {
case model.SqliteDBType: case model.SqliteDBType:
@ -358,7 +358,7 @@ func (s *SQLStore) genAddColumnIfNeeded(tableName, columnName, datatype, constra
func (s *SQLStore) genDropColumnIfNeeded(tableName, columnName string) (string, error) { func (s *SQLStore) genDropColumnIfNeeded(tableName, columnName string) (string, error) {
tableName = addPrefixIfNeeded(tableName, s.tablePrefix) tableName = addPrefixIfNeeded(tableName, s.tablePrefix)
normTableName := normalizeTablename(s.schemaName, tableName) normTableName := s.normalizeTablename(tableName)
switch s.dbType { switch s.dbType {
case model.SqliteDBType: case model.SqliteDBType:
@ -395,7 +395,7 @@ func (s *SQLStore) genDropColumnIfNeeded(tableName, columnName string) (string,
func (s *SQLStore) genCreateIndexIfNeeded(tableName, columns string) (string, error) { func (s *SQLStore) genCreateIndexIfNeeded(tableName, columns string) (string, error) {
indexName := getIndexName(tableName, columns) indexName := getIndexName(tableName, columns)
tableName = addPrefixIfNeeded(tableName, s.tablePrefix) tableName = addPrefixIfNeeded(tableName, s.tablePrefix)
normTableName := normalizeTablename(s.schemaName, tableName) normTableName := s.normalizeTablename(tableName)
switch s.dbType { switch s.dbType {
case model.SqliteDBType: case model.SqliteDBType:
@ -435,7 +435,7 @@ func (s *SQLStore) genRenameTableIfNeeded(oldTableName, newTableName string) (st
oldTableName = addPrefixIfNeeded(oldTableName, s.tablePrefix) oldTableName = addPrefixIfNeeded(oldTableName, s.tablePrefix)
newTableName = addPrefixIfNeeded(newTableName, s.tablePrefix) newTableName = addPrefixIfNeeded(newTableName, s.tablePrefix)
normOldTableName := normalizeTablename(s.schemaName, oldTableName) normOldTableName := s.normalizeTablename(oldTableName)
vars := map[string]string{ vars := map[string]string{
"schema": s.schemaName, "schema": s.schemaName,
@ -466,14 +466,14 @@ func (s *SQLStore) genRenameTableIfNeeded(oldTableName, newTableName string) (st
case model.PostgresDBType: case model.PostgresDBType:
return replaceVars(` return replaceVars(`
do $$ do $$
begin begin
if (SELECT COUNT(table_name) FROM INFORMATION_SCHEMA.TABLES if (SELECT COUNT(table_name) FROM INFORMATION_SCHEMA.TABLES
WHERE table_name = '[[new_table_name]]' WHERE table_name = '[[new_table_name]]'
AND table_schema = '[[schema]]' AND table_schema = '[[schema]]'
) = 0 then ) = 0 then
ALTER TABLE [[norm_old_table_name]] RENAME TO [[new_table_name]]; ALTER TABLE [[norm_old_table_name]] RENAME TO [[new_table_name]];
end if; end if;
end$$; end$$;
`, vars), nil `, vars), nil
default: default:
return "", ErrUnsupportedDatabaseType return "", ErrUnsupportedDatabaseType
@ -482,7 +482,7 @@ func (s *SQLStore) genRenameTableIfNeeded(oldTableName, newTableName string) (st
func (s *SQLStore) genRenameColumnIfNeeded(tableName, oldColumnName, newColumnName, dataType string) (string, error) { func (s *SQLStore) genRenameColumnIfNeeded(tableName, oldColumnName, newColumnName, dataType string) (string, error) {
tableName = addPrefixIfNeeded(tableName, s.tablePrefix) tableName = addPrefixIfNeeded(tableName, s.tablePrefix)
normTableName := normalizeTablename(s.schemaName, tableName) normTableName := s.normalizeTablename(tableName)
vars := map[string]string{ vars := map[string]string{
"schema": s.schemaName, "schema": s.schemaName,
@ -516,15 +516,15 @@ func (s *SQLStore) genRenameColumnIfNeeded(tableName, oldColumnName, newColumnNa
case model.PostgresDBType: case model.PostgresDBType:
return replaceVars(` return replaceVars(`
do $$ do $$
begin begin
if (SELECT COUNT(table_name) FROM INFORMATION_SCHEMA.COLUMNS if (SELECT COUNT(table_name) FROM INFORMATION_SCHEMA.COLUMNS
WHERE table_name = '[[table_name]]' WHERE table_name = '[[table_name]]'
AND table_schema = '[[schema]]' AND table_schema = '[[schema]]'
AND column_name = '[[new_column_name]]' AND column_name = '[[new_column_name]]'
) = 0 then ) = 0 then
ALTER TABLE [[norm_table_name]] RENAME COLUMN [[old_column_name]] TO [[new_column_name]]; ALTER TABLE [[norm_table_name]] RENAME COLUMN [[old_column_name]] TO [[new_column_name]];
end if; end if;
end$$; end$$;
`, vars), nil `, vars), nil
default: default:
return "", ErrUnsupportedDatabaseType return "", ErrUnsupportedDatabaseType
@ -620,7 +620,7 @@ func (s *SQLStore) doesColumnExist(tableName, columnName string) (bool, error) {
func (s *SQLStore) genAddConstraintIfNeeded(tableName, constraintName, constraintType, constraintDefinition string) (string, error) { func (s *SQLStore) genAddConstraintIfNeeded(tableName, constraintName, constraintType, constraintDefinition string) (string, error) {
tableName = addPrefixIfNeeded(tableName, s.tablePrefix) tableName = addPrefixIfNeeded(tableName, s.tablePrefix)
normTableName := normalizeTablename(s.schemaName, tableName) normTableName := s.normalizeTablename(tableName)
var query string var query string
@ -686,8 +686,12 @@ func addPrefixIfNeeded(s, prefix string) string {
return s return s
} }
func normalizeTablename(schemaName, tableName string) string { func (s *SQLStore) normalizeTablename(tableName string) string {
if schemaName != "" && !strings.HasPrefix(tableName, schemaName+".") { if s.schemaName != "" && !strings.HasPrefix(tableName, s.schemaName+".") {
schemaName := s.schemaName
if s.dbType == model.MysqlDBType {
schemaName = "`" + schemaName + "`"
}
tableName = schemaName + "." + tableName tableName = schemaName + "." + tableName
} }
return tableName return tableName