From 36a073eaad764dc30a156cb04c7f83b8974a4bf4 Mon Sep 17 00:00:00 2001 From: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Date: Wed, 27 Jul 2022 23:47:38 +0530 Subject: [PATCH] Handled err in acse of lack of user-channel membership (#3378) * Handled err in acse of lack of user-channel membership * Used errors.As instead of type check Co-authored-by: Mattermod --- .../store/mattermostauthlayer/mattermostauthlayer.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/server/services/store/mattermostauthlayer/mattermostauthlayer.go b/server/services/store/mattermostauthlayer/mattermostauthlayer.go index 05996b60a..253eb278d 100644 --- a/server/services/store/mattermostauthlayer/mattermostauthlayer.go +++ b/server/services/store/mattermostauthlayer/mattermostauthlayer.go @@ -669,8 +669,16 @@ func (s *MattermostAuthLayer) GetMemberForBoard(boardID, userID string) (*model. if b.ChannelID != "" { _, err := s.servicesAPI.GetChannelMember(b.ChannelID, userID) if err != nil { + var appErr *mmModel.AppError + if errors.As(err, &appErr) && appErr.StatusCode == http.StatusNotFound { + // Plugin API returns error if channel member doesn't exist. + // We're fine if it doesn't exist, so its not an error for us. + return nil, nil + } + return nil, err } + return &model.BoardMember{ BoardID: boardID, UserID: userID,