self-hosted/focalboard
1
0
Fork 0
mirror of https://github.com/mattermost/focalboard.git synced 2025-01-08 15:06:08 +02:00
Code Issues Releases Activity

Added max height limit on filter options dropdown (#3313)

Browse Source 
* Added max height limit on filter options dropdown

* Updated tests

* lint fix
This commit is contained in:
Harshil Sharma 2022-07-06 20:51:16 +05:30 committed by GitHub
parent 88ad387166
commit 6e6bc36f4a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webapp/src/components/viewHeader/__snapshots__/filterValue.test.tsx.snap
View File

@ -4,7 +4,7 @@ exports[`components/viewHeader/filterValue return filterValue 1`] = `
<div> <div>
<div <div
aria-label="menuwrapper" aria-label="menuwrapper"
class="MenuWrapper" class="MenuWrapper filterValue"
role="button" role="button"
> >
<button <button
@ -86,7 +86,7 @@ exports[`components/viewHeader/filterValue return filterValue and click Status 1
<div> <div>
<div <div
aria-label="menuwrapper" aria-label="menuwrapper"
class="MenuWrapper" class="MenuWrapper filterValue"
role="button" role="button"
> >
<button <button
@ -105,7 +105,7 @@ exports[`components/viewHeader/filterValue return filterValue and click Status w
<div> <div>
<div <div
aria-label="menuwrapper" aria-label="menuwrapper"
class="MenuWrapper" class="MenuWrapper filterValue"
role="button" role="button"
> >
<button <button

6
webapp/src/components/viewHeader/filterValue.scss Normal file
View File

@ -0,0 +1,6 @@
.filterValue {
.Menu {
max-height: 400px;
overflow-y: auto;
}
}

4
webapp/src/components/viewHeader/filterValue.tsx
View File

@ -12,6 +12,8 @@ import Button from '../../widgets/buttons/button'
import Menu from '../../widgets/menu' import Menu from '../../widgets/menu'
import MenuWrapper from '../../widgets/menuWrapper' import MenuWrapper from '../../widgets/menuWrapper'
import './filterValue.scss'
type Props = { type Props = {
view: BoardView view: BoardView
filter: FilterClause filter: FilterClause
@ -35,7 +37,7 @@ const filterValue = (props: Props): JSX.Element|null => {
} }
return ( return (
<MenuWrapper> <MenuWrapper className='filterValue'>
<Button>{displayValue}</Button> <Button>{displayValue}</Button>
<Menu> <Menu>
{template.options.map((o) => ( {template.options.map((o) => (