self-hosted/focalboard
1
0
Fork 0
mirror of https://github.com/mattermost/focalboard.git synced 2024-12-21 13:38:56 +02:00
Code Issues Releases Activity

Adds a database migration to restore the fileinfos that are deleted (#4815) (#4817)

Browse Source 
(cherry picked from commit 257cc5f1fd)

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
This commit is contained in:
Mattermost Build 2023-07-22 06:12:40 +03:00 committed by GitHub
parent 93a57ecfe0
commit 886f50e342
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
server/services/store/sqlstore/migrations/000040_fix_fileinfo_soft_deletes.down.sql Normal file
View File

@ -0,0 +1 @@
SELECT 1;

8
server/services/store/sqlstore/migrations/000040_fix_fileinfo_soft_deletes.up.sql Normal file
View File

@ -0,0 +1,8 @@
{{if .plugin}}
UPDATE FileInfo
SET DeleteAt = 0
WHERE CreatorId = 'boards'
AND DeleteAt != 0;
{{else}}
SELECT 1;
{{end}}

9
server/services/store/sqlstore/migrationstests/fixtures/test40FixFileinfoSoftDeletes.sql Normal file
View File

@ -0,0 +1,9 @@
INSERT INTO FileInfo
(Id, CreatorId, CreateAt, UpdateAt, DeleteAt)
VALUES
('fileinfo-1', 'user-id', 1, 1, 1000),
('fileinfo-2', 'user-id', 1, 1, 1000),
('fileinfo-3', 'user-id', 1, 1, 0),
('fileinfo-4', 'boards', 1, 1, 2000),
('fileinfo-5', 'boards', 1, 1, 2000),
('fileinfo-6', 'boards', 1, 1, 0);

48
server/services/store/sqlstore/migrationstests/migration40_test.go Normal file
View File

@ -0,0 +1,48 @@
package migrationstests
import (
"testing"
"github.com/stretchr/testify/require"
)
func Test40FixFileinfoSoftDeletes(t *testing.T) {
th, tearDown := SetupPluginTestHelper(t)
defer tearDown()
th.f.MigrateToStep(39).
ExecFile("./fixtures/test40FixFileinfoSoftDeletes.sql").
MigrateToStep(40)
type FileInfo struct {
Id string
DeleteAt int
}
getFileInfo := func(t *testing.T, id string) FileInfo {
t.Helper()
fileInfo := FileInfo{}
query := "SELECT id, deleteat FROM FileInfo WHERE id = $1"
if th.IsMySQL() {
query = "SELECT Id as id, DeleteAt as deleteat FROM FileInfo WHERE Id = ?"
}
err := th.f.DB().Get(&fileInfo, query, id)
require.NoError(t, err)
return fileInfo
}
t.Run("the file infos that don't belong to boards will not be restored", func(t *testing.T) {
require.Equal(t, 1000, getFileInfo(t, "fileinfo-1").DeleteAt)
require.Equal(t, 1000, getFileInfo(t, "fileinfo-2").DeleteAt)
require.Empty(t, getFileInfo(t, "fileinfo-3").DeleteAt)
})
t.Run("the file infos that belong to boards should correctly be restored", func(t *testing.T) {
require.Empty(t, getFileInfo(t, "fileinfo-3").DeleteAt)
require.Empty(t, getFileInfo(t, "fileinfo-4").DeleteAt)
require.Empty(t, getFileInfo(t, "fileinfo-5").DeleteAt)
})
}