self-hosted/focalboard
1
0
Fork 0
mirror of https://github.com/mattermost/focalboard.git synced 2024-12-24 13:43:12 +02:00
Code Issues Releases Activity

Remove text property from Button because children is enough

Browse Source
This commit is contained in:
Jesús Espino 2020-10-15 20:42:58 +02:00
parent a43ea02616
commit b801cd84f0
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/client/components/boardComponent.tsx
View File

@ -141,7 +141,7 @@ class BoardComponent extends React.Component<Props, State> {
<div className="octo-board-header-cell">
<div className="octo-label" title={`Items with an empty ${boardTree.groupByProperty?.name} property will go here. This column cannot be removed.`}>{`No ${boardTree.groupByProperty?.name}`}</div>
<Button text={`${boardTree.emptyGroupCards.length}`} />
<Button>{`${boardTree.emptyGroupCards.length}`}</Button>
<div className="octo-spacer" />
<Button><div className="imageOptions" /></Button>
<Button onClick={() => { this.addCard(undefined) }}><div className="imageAdd" /></Button>
@ -165,7 +165,7 @@ class BoardComponent extends React.Component<Props, State> {
className={`octo-label ${group.option.color}`}
text={group.option.value}
onChanged={(text) => { this.propertyNameChanged(group.option, text) }} />
<Button text={`${group.cards.length}`} />
<Button>{`${group.cards.length}`}</Button>
<div className="octo-spacer" />
<MenuWrapper>
<Button><div className="imageOptions" /></Button>
@ -182,7 +182,7 @@ class BoardComponent extends React.Component<Props, State> {
)}
<div className="octo-board-header-cell">
<Button text="+ Add a group" onClick={(e) => { this.addGroupClicked() }} />
<Button onClick={(e) => { this.addGroupClicked() }}>+ Add a group</Button>
</div>
</div>
@ -202,7 +202,7 @@ class BoardComponent extends React.Component<Props, State> {
onDragStart={() => { this.draggedCard = card }}
onDragEnd={() => { this.draggedCard = undefined }} />
)}
<Button text="+ New" onClick={() => { this.addCard(undefined) }} />
<Button onClick={() => { this.addCard(undefined) }} >+ New</Button>
</BoardColumn>
{/* Columns */}
@ -218,7 +218,7 @@ class BoardComponent extends React.Component<Props, State> {
onDragStart={() => { this.draggedCard = card }}
onDragEnd={() => { this.draggedCard = undefined }} />
)}
<Button text="+ New" onClick={() => { this.addCard(group.option.value) }} />
<Button onClick={() => { this.addCard(group.option.value) }} >+ New</Button>
</BoardColumn>
)}
</div>

3
src/client/components/button.tsx
View File

@ -6,7 +6,7 @@ type Props = {
onClick?: (e: React.MouseEvent<HTMLDivElement>) => void
style?: React.CSSProperties
backgroundColor?: string
text?: string
children?: React.ReactNode
title?: string
}
@ -20,7 +20,6 @@ export default class Button extends React.Component<Props> {
style={style}
title={this.props.title}>
{this.props.children}
{this.props.text}
</div>)
}
}

4
src/client/components/cardDialog.tsx
View File

@ -125,7 +125,7 @@ class CardDialog extends React.Component<Props, State> {
<div className="dialog" >
<div className="toolbar">
<div className="octo-spacer"></div>
<Button text="..." onClick={(e) => {
<Button onClick={(e) => {
Menu.shared.options = [
{ id: "delete", name: "Delete" },
]
@ -139,7 +139,7 @@ class CardDialog extends React.Component<Props, State> {
}
}
Menu.shared.showAtElement(e.target as HTMLElement)
}}></Button>
}}>...</Button>
</div>
<div className="content">
{icon ?