self-hosted/focalboard
1
0
Fork 0
mirror of https://github.com/mattermost/focalboard.git synced 2024-12-03 08:45:40 +02:00
Code Issues Releases Activity

GH-2101 - Fixing card property and value bugs (#2103)

Browse Source
This commit is contained in:
Asaad Mahmood 2022-01-12 21:35:02 +05:00 committed by GitHub
parent d86d5005f6
commit bfddc335bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 32 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
webapp/src/components/__snapshots__/workspace.test.tsx.snap
View File

@ -671,7 +671,7 @@ exports[`src/components/workspace return workspace and showcard 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -715,7 +715,7 @@ exports[`src/components/workspace return workspace and showcard 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -759,7 +759,7 @@ exports[`src/components/workspace return workspace and showcard 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -1059,7 +1059,7 @@ exports[`src/components/workspace return workspace readonly and showcard 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -1089,7 +1089,7 @@ exports[`src/components/workspace return workspace readonly and showcard 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -1119,7 +1119,7 @@ exports[`src/components/workspace return workspace readonly and showcard 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -1830,7 +1830,7 @@ exports[`src/components/workspace should match snapshot 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -1874,7 +1874,7 @@ exports[`src/components/workspace should match snapshot 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -1918,7 +1918,7 @@ exports[`src/components/workspace should match snapshot 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -2218,7 +2218,7 @@ exports[`src/components/workspace should match snapshot with readonly 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -2248,7 +2248,7 @@ exports[`src/components/workspace should match snapshot with readonly 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>
@ -2278,7 +2278,7 @@ exports[`src/components/workspace should match snapshot with readonly 1`] = `
data-tooltip="Property 1"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
>
value1
</div>

16
webapp/src/components/cardDetail/cardDetail.scss
View File

@ -57,9 +57,12 @@
font-size: 14px;
padding: 4px 8px;
height: 32px;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
&.octo-propertyvalue--readonly {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
&:not(.readonly) {
min-width: 180px;
@ -93,8 +96,13 @@
}
}
.octo-propertyrow {
.octo-propertyname {
flex: 0 0 150px;
}
}
.octo-propertyname {
flex: 0 0 150px;
width: 150px;
margin-right: 5px;
color: rgba(var(--center-channel-color-rgb), 0.6);

2
webapp/src/components/cardDetail/cardDetailProperties.tsx
View File

@ -141,7 +141,7 @@ const CardDetailProperties = React.memo((props: Props) => {
key={propertyTemplate.id + '-' + propertyTemplate.type + '-' + propertyValue}
className='octo-propertyrow'
>
{props.readonly && <div className='octo-propertyname'>{propertyTemplate.name}</div>}
{props.readonly && <div className='octo-propertyname octo-propertyname--readonly'>{propertyTemplate.name}</div>}
{!props.readonly &&
<MenuWrapper isOpen={propertyTemplate.id === newTemplateId}>
<div className='octo-propertyname'><Button>{propertyTemplate.name}</Button></div>

2
webapp/src/components/gallery/__snapshots__/galleryCard.test.tsx.snap
View File

@ -871,7 +871,7 @@ exports[`src/components/gallery/GalleryCard without block content should match s
data-tooltip="testTemplateProperty"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
/>
</div>
</div>

10
webapp/src/components/kanban/__snapshots__/kanbanCard.test.tsx.snap
View File

@ -127,7 +127,7 @@ exports[`src/components/kanban/kanbanCard return kanbanCard and click on copy li
data-tooltip="name"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
/>
</div>
</div>
@ -261,7 +261,7 @@ exports[`src/components/kanban/kanbanCard return kanbanCard and click on delete
data-tooltip="name"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
/>
</div>
</div>
@ -395,7 +395,7 @@ exports[`src/components/kanban/kanbanCard return kanbanCard and click on duplica
data-tooltip="name"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
/>
</div>
</div>
@ -442,7 +442,7 @@ exports[`src/components/kanban/kanbanCard should match snapshot 1`] = `
data-tooltip="name"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
/>
</div>
</div>
@ -475,7 +475,7 @@ exports[`src/components/kanban/kanbanCard should match snapshot with readonly 1`
data-tooltip="name"
>
<div
class="octo-propertyvalue"
class="octo-propertyvalue octo-propertyvalue--readonly"
/>
</div>
</div>

2
webapp/src/components/propertyValueElement.tsx
View File

@ -242,7 +242,7 @@ const PropertyValueElement = (props:Props): JSX.Element => {
/>
)
}
return <div className='octo-propertyvalue'>{displayValue}</div>
return <div className='octo-propertyvalue octo-propertyvalue--readonly'>{displayValue}</div>
}
return <div className='octo-propertyvalue'>{finalDisplayValue}</div>
}