1
0
mirror of https://github.com/mattermost/focalboard.git synced 2025-02-07 19:30:18 +02:00

214 Commits

Author SHA1 Message Date
Jesse Hallam
6496c7735e
stop logging errors for api error responses
From a cursory glance, when a real error occurs, we already log
something at the application layer, so there's no reason to echo every
api error response as an error log too. Errors should be actionable, but
these logs were not, e.g.:

> access denied to templates

or:

> category ID specified in input does not exist for user
2024-07-04 12:16:52 -03:00
Rajat Dabade
c8e729b6fe
[Refactor]: updated dependency for focalboard server (#5009)
* refactor: updated dependency for focalboard server

* chore: more dependency fixes

* refactor: removed the unless code

* refactor: added ctx for login and removed unnessary code

* refactor: bump up go version

* refactor: removed the commented code

* chore: upgraded golinter version

* fix: linter issue

* refactor: removed feature flg fix golinter

* refactor: removed feature flag from code

* revert: statistic and it's function

* refactor: removed ProductLimit related code

* refactor: removed isWithinViewsLimit implementation

* refactor: moved function GetUsedCardsCount to statistics.go from cloud.go

* refactor: removed insight code board

* refactor: removed limit dialog

* refactor: updated dependencies for linux

* chore: golinter fix

* chore: updated helper test function to use newLogger

* fix: go test

* refactor: db ping attempts from config

* revert: feature in action

* revert: feature flag in action

* revert: boardsEditor setting

---------

Co-authored-by: Rajat Dabade <rajat@Rajats-MacBook-Pro.local>
2024-06-07 23:30:08 +05:30
Scott Bishel
134422df4d
MM-54366 Check guest access to other members (#4871)
* check guest access to other members

* lint fix
2023-09-25 08:19:53 -06:00
Elias Nahum
3625c53527
Sanitize user following config for ShowFullName and ShowEmailAddress (#4820) 2023-07-26 08:42:22 -04:00
Miguel de la Cruz
5dfd402e26
Unify and enhance block validation (#4790)
* Adds limit check for block titles

* Adds limit check for the aggregation of the fields

* Fix linter

* Adds tests

* Fix err check method order
2023-06-26 13:37:37 -06:00
Scott Bishel
888c169910
Backport fixes for import/export attachments and fixes (#4741)
* Backport fixes for import/export attachments and fixes

* fix bad merge

* lint fixes

* Update server/app/boards.go

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>

---------

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
2023-05-22 10:31:24 -06:00
Doug Lauder
2b9eec1bec
Avoid panic in file request handler on error (#4693)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-04-03 17:43:58 -04:00
Scott Bishel
d8e1fb4832
copy safe writeFileResponse into personal server/desktop (#4654)
* copy safe writeFileResponse into personal server/desktop

* lint fix

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-03-22 13:28:23 -06:00
Harshil Sharma
fa72286427
Board teamless file path (#4577)
* Updated upload and donwload code

* Removed archived file handling as we no longer have cloud limits

* Fixed server lint

* Restored unused

* CI

* Added new tests

* Fixed integration tests

* Added Path column for personal server's FileInfo table

* Removed sophesticated, elegant debug logs

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-03-07 10:21:53 +05:30
Scott Bishel
f88ee1ece3
Fix for users adding board links to Read-only channels (#4581)
* initial commit for channel permissions

* add test

* check for write post when returning channels

* lint fix

* fix test

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-02-22 14:55:13 -07:00
Scott Bishel
098868387e
initial implementation of SysAdmin/TeamAdmin feature (#4537)
* initial implementation of SysAdmin/TeamAdmin feature

* fix adminBadge tests

* updating tests

* more fixes for unit tests

* lint fixes

* update snapshots

* update cypress test for call change

* add additional unit tests

* update test for lint errors

* fix reviews implement tests

* fix for merge, reset dialog before redirection

* remove unused test code

* fix more tests

* fix swagger doc for missing parameters

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-02-14 09:17:33 -07:00
Rajat Dabade
c91a67fbe6
Used Shared resource from MM-server for attachment serving (#4542)
* Used Shared resource for File Handling

* Making use of shared attachment serve functionality

* Added license

---------

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-02-08 20:44:28 -07:00
Harshil Sharma
06984c7856
Added check for to-be-added user into team (#4515)
Co-authored-by: Mattermost Build <build@mattermost.com>
2023-02-07 09:09:26 +05:30
wiggin77
ad9d744d63 fix teamID check 2023-01-26 12:47:44 -05:00
wiggin77
c6b2c28394 Merge remote-tracking branch 'upstream/main' into compliance-history-export 2023-01-26 12:19:36 -05:00
Jesús Espino
345ff01539
MM-43342: More strict permissions on categories (#4504) 2023-01-26 10:07:41 +01:00
Doug Lauder
165d3c0fc1
Update server/api/compliance.go
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
2023-01-25 14:08:18 -05:00
wiggin77
7ebf861f1c fix merge conflict 2023-01-24 16:25:23 -05:00
Harshil Sharma
03f4717e96
Hide board feature (#4409)
* WIP

* Added migrations

* Updating store method

* WIP

* WIP

* Updated DND

* WIP

* WIP

* WIP

* WIP

* WIP

* wip

* WIP

* Adding new DB tool

* Used migration functions in new migrations

* Unique constraint migration

* Unique constraint migration

* Added SQLITE migrations

* Added SQLITE support in few more migrations

* Added SQLITE support in few more migrations

* WIP

* Used old-fashioned way to add unique constraint

* Using oldsqlite method

* Using oldsqlite method

* Fixed all store and app layer tests

* fixed integration tests

* test and lint fix

* Updated migration for MySQL and Postgres on personal server

* Types fix

* sqlite fix

* fix typo

* misc cleanup

* added new tests

* added new tests

* de-duping input for postgres

* integration tests, rmeoved uneeded migration

* Added some migration tests

* Added some migration tests

* Fixed a test

* completed migration tests

* completed migration tests

* Removed leftover debug statements

Co-authored-by: Mattermost Build <build@mattermost.com>
2023-01-24 15:41:54 +05:30
Agniva De Sarker
d6207dde6c
MM-49703: Bump to Go 1.19 (#4489) (#4502)
Also fix some gofmt issues

https://mattermost.atlassian.net/browse/MM-49703
2023-01-23 12:43:40 +05:30
Doug Lauder
50e15f3804
Revert "MM-49703: Bump to Go 1.19 (#4489)" (#4499)
This reverts commit 2d0dde21dd8d570e1247ec6db7b95a14f9ad4f2e.
2023-01-20 21:58:27 +05:30
Agniva De Sarker
2d0dde21dd
MM-49703: Bump to Go 1.19 (#4489)
* MM-49703: Bump to Go 1.19

Also fix some gofmt issues

https://mattermost.atlassian.net/browse/MM-49703

* Bump versions in go.mod

* Update go.work as well

* Bump GolangCI to 1.50.1

* Upgraded to new builder image
2023-01-20 11:06:16 -05:00
wiggin77
abbd5f46a1 fix export board permission 2023-01-03 17:47:20 -05:00
wiggin77
f4d5c39d7d swagger for new APIs 2023-01-03 16:53:57 -05:00
wiggin77
866d23529e integration tests for GetBlocksComplianceHistory 2023-01-01 14:16:46 -05:00
wiggin77
4272e2eac0 integration tests for GetBoardsComplianceHistory 2022-12-31 16:33:05 -05:00
wiggin77
dd1e64958f integration tests for GetBoardsForCompliance 2022-12-31 15:16:22 -05:00
wiggin77
96b790672b wip 2022-12-23 23:31:39 -05:00
Mattermod
625a3e12af
Merge branch 'main' into compliance-history-export 2022-12-23 03:12:01 +02:00
Doug Lauder
b63542fb63
Search boards by prop (#4291)
* SearchBoardsForUser API with property name search.
2022-12-16 11:46:00 -05:00
Harshil Sharma
eceb406535
Revert "Revert dnd (#4294)" (#4324)
This reverts commit 9fac8f476ef43dd8d8977397c562f77fc92f64c0.
2022-12-14 14:21:53 +05:30
Paul Esch-Laurent
dcdc3e20d9 wip: interface{} in JSON marshal struct 2022-12-05 16:10:03 -06:00
Miguel de la Cruz
9fac8f476e
Revert dnd (#4294)
* Revert "Fixed bug where boards would move to category of a different team (#4284)"

This reverts commit e075f408d340ab71891a667541e7bf333f875d56.

* Revert "Merge branch 'main' into only-explicit-boards-on-default-category"

This reverts commit 7db7e562963fbd0fef317d2b98bd7074c78b0637, reversing
changes made to 3feda10b6d075dd9bd82fa85fcd8b8b9560eaa64.

* Revert "DND support for category and boards in LHS (#3964)"

This reverts commit 9918a0b3f8a249e1fc43afeceddb084edf73a10c.
2022-12-05 15:03:34 -05:00
Paul Esch-Laurent
c4de1b9250 wip 2022-12-02 10:40:48 -06:00
Paul Esch-Laurent
f662e35daa wip 2022-11-30 15:49:16 -06:00
Paul Esch-Laurent
dbdd8e073c wip: sysadmin w/ license can export any board 2022-11-30 15:36:46 -06:00
Rajat Dabade
6674402079
File attachment in the card (#4053)
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-11-24 17:16:59 +05:30
Harshil Sharma
9918a0b3f8
DND support for category and boards in LHS (#3964)
* WIP

* WIP

* Removed unused webapp util

* Added server tests

* Lint fix

* Updating existing tests

* Updating existing tests

* Updating existing tests

* Fixing existing tests

* Fixing existing tests

* Fixing existing tests

* WIP

* Added category sort order migration

* Added logic to set new category on top

* Implemented api, WS listein logic remining

* finished webapp implementation

* Added category type and tests

* updated tests

* Fixed integration test

* type fix

* WIP

* implemented boards DND to other category and in same category

* removed seconds from boards name

* wip

* debugging cy test

* Enabled hiding views list while DNDing

* Removed some debug logs

* Fixed a bug preventing users from collapsing boards category

* WIP

* Debugging cypress test

* CI

* debugging cy test

* Testing a fix

* reverting test fix

* Handled personal server

* WIP

* WIP

* Adding support for building with esbuild

* Using different index.html templates for esbuild

* WIP

* WIP

* Fixed delete category and rename category

* WIP

* WIP

* Finally, its done.

* Adde suppor tot update board-category mapping in bulk

* Fixed a bug where create category option didn't show up on default category

* Fixed bug where new board was added as last board in Boards category instead of first board

* Minor cleanup

* WIP

* Added support to drab boards onto collapsed categories

* Fixed route order from specific to generic

* Fix linter

* Updated existin server tests

* fixed integration tests

* Fixed webapp test err

* Removed accidental dependencies

* Adding  new server tests

* Finished server tests

* added api to client.go

* Added API integration test

* Fixed existing webapp tests

* WIP

* WIP

* WIP

* WIP

* WIP

* Fixed missing paranthesis

* Some cleanup

* fixed server lint

* noopped down migration

* Fixed issue with DND not working great with newly added category

* Fixed a test

* Fixed a test

* Fixed a test

* Fixed console error while DNDing

* pakg lock restore

* Fixed missing react beautiful dnd in package.lock.json

* updated snapshots

* Fixed webapp test

* Review fixes

* Added API permission check

Co-authored-by: Jesús Espino <jespinog@gmail.com>
2022-11-24 15:31:32 +05:30
cyrilzhang-mm
6b28be7043
[MM-45052] Add error checking in insights API (#3876) 2022-11-18 11:11:32 -05:00
Jesús Espino
f915a20c64
Adding the new blocks based editor (#3825)
* Working in the new content block editor

* Moving blocksEditor content block into its own component

* Initial integration with quick development flow

* More WIP

* Adding drag and drop support with server side help

* Some extra work around the styles

* Adding image support

* Adding video and attachments, and fixing edit

* Putting everything behind a feature flag

* Adding support for download attachments

* Fixing compilation error

* Fixing linter errors

* Fixing javascript tests

* Fixing a typescript error

* Moving the move block to an action with undo support

* Fixing ci

* Fixing post merge errors

* Moving to more specific content-blocks api

* Apply suggestions from code review

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* Fixing the behavior of certain blocks

* Fixing linter error

* Fixing javascript linter errors

* Adding permission testing for the new move content block api

* Adding some unit tests

* Improving a bit the tests

* Adding more unit tests to the backend

* Fixed PR suggestion

* Adding h1, h2 and h3 tests

* Adding image tests

* Adding video tests

* Adding attachment tests

* Adding quote block tests

* Adding divider tests

* Adding checkbox tests

* Adding list item block tests

* Adding text block tests

* Reorganizing a bit the code to support deveditor eagain

* Fixing dark theme on editor view

* Fixing linter errors

* Fixing tests and removing unneeded data-testid

* Adding root input tests

* Fixing some merge problems

* Fixing text/text.test.tsx test

* Adding more unit tests to the blocks editor

* Fix linter error

* Adding blocksEditor tests

* Fixing linter errors

* Adding tests for blockContent

* Update webapp/src/components/blocksEditor/blockContent.test.tsx

Fix linter warning

* Update webapp/src/components/blocksEditor/blockContent.test.tsx

Fix linter warning

* Update webapp/src/components/blocksEditor/blockContent.test.tsx

Fix linter error

* Fixing test

* Removing unneeded TODO

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
2022-11-15 16:59:07 +01:00
Benjamin Masters
0cd4257ebc
[GH-3410] Healthcheck Endpoint with Server Metadata (#4151)
* add ping endpoint and tests

* remove unnecessary newlines

* fix: invalid Swagger YAML comment blocks

* refactor and add 'suite' SKU

* generate swagger docs

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Paul Esch-Laurent <paul.esch-laurent@mattermost.com>
2022-11-14 14:37:06 -05:00
Harshil Sharma
8d17dd820e
Boards as persisted category (#3877)
* WIP

* WIP

* Removed unused webapp util

* Added server tests

* Lint fix

* Updating existing tests

* Updating existing tests

* Updating existing tests

* Fixing existing tests

* Fixing existing tests

* Fixing existing tests

* Added category type and tests

* updated tests

* Fixed integration test

* type fix

* removed seconds from boards name

* wip

* debugging cy test

* Fixed a bug preventing users from collapsing boards category

* Debugging cypress test

* CI

* debugging cy test

* Testing a fix

* reverting test fix

* Handled personal server

* Fixed a case for personal server

* fixed a test
2022-10-26 16:38:03 +05:30
Miguel de la Cruz
91f9f71bf7
Replace Block references to use pointers throughout all application layers (#3934)
* Replace Block references to use pointers throughout all application layers

* lint fixes

* gofmt file, lint fix

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
2022-10-25 14:46:43 -06:00
Scott Bishel
e3ae682eea
Display board statistics (#4025)
* initial commit for displaying board statistics

* lint fixes

* i18n-extract, remove log entries, cleanup

* more lint fixes

* add check for standalone mode

* update tests due to change to NotImplemented

* lint fix

* revert removing empty comment lines

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-10-25 14:28:00 -06:00
Scott Bishel
ee2f07c3da
fix adding members to public board by editor (#3954)
* fix adding members to public board by editor

* remove log line

* fix unit tests

* lint fix

* update test
2022-10-06 14:02:15 -06:00
Harshil Sharma
2c27d2626e
Fix bug where workspace era uploaded files won't load on team era codebase (#3907)
* WIP

* Added comment for explaination

* Lint fix

* move file if found in channel directory

* lint fixes

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-10-05 14:16:03 -06:00
Miguel de la Cruz
4e8a3f8232
Preserve old handleServeFile endpoint behavior after refactor (#3892) 2022-10-03 10:45:04 +05:30
Scott Bishel
8f4951dd4a
Fix members (#3875)
* retrieve all team members for specific lists

* retrieve all team members for specific lists

* final fixes

* update to use enum

* unit test fixes

* lint fixes

* fix integration test

* fixup integration test

* fix issues with making board private

* update to make webapp and server enums match

* fix to add member in correct role

* remove unnecessary property, check Open/Private board

* cleanup confirm for non admin

* some final cleanup

* move default to webapp

* only allow greater roles in drop down, change property name to minimumRole

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
2022-09-30 08:26:41 -06:00
Harshil Sharma
8ded5838a8
removed non-existent field (#3856) 2022-09-16 07:40:38 +02:00
Rajat Dabade
80024851a5
Added single-user check for getUserList (#3801)
* Added single-user check for getUserList

* Added check for length of UserIDs slice

* ErrorResponse arg fix and UserIDs len fix

* Linter fixes

* Error fixes

* Linter and error fix
2022-09-15 16:52:35 -04:00