mirror of
https://github.com/mattermost/focalboard.git
synced 2024-12-24 13:43:12 +02:00
aa540e73ce
* wip
* Added data migration for populating categories
* wip
* Added data migration for populating categories
* Store WIP
* migration WIP
* category CRUD APIs complete
* category block API WIP
* block category update API done
* Fetcehed data into store
* Started displayting sidebar data
* sidebar WIP
* Dashboard - basic changes
* Sidebar dashboard btn and board switcher UI only
* Sidebar dashboard btn and board switcher UI only
* create category dialog WIP
* Create category webapp side done
* Integrated move card to other category
* board to block
* Disabled dashboard route for now as we'll implement it in phase 2
* WIP
* Added logic to open last board/view on per team level
* Add workspace to teams and boards migrations (#1986)
* Add workspace to teams and boards migrations
* Update json annotations on board models
* boards search dialog WIP
* Seach dialog WIP
* Implemented opening boiard from search results
* Boards switcher styliung
* Handled update category WS event
* Template support
* personal server support and styling fixes
* test fix WIP
* Fixed a bug causing boards to not be moved correctly beteen categories
* Fixed webapp tests
* fix
* Store changes (#2011)
* Permissions phase 1 - Websocket updates (#2014)
* Store changes
* Websockets changes
* Permissions phase 1 - Permissions service (#2015)
* Store changes
* Websockets changes
* Permissions service
* Api and app updates (#2016)
* Store changes
* Websockets changes
* Permissions service
* New API and App changes
* Delete and Patch boards and blocks endpoints
* Used correct variable
* Webapp changes WIP
* Open correct team URL
* Fixed get block API
* Used React context for workspace users
* WIP
* On load navigation sorted out
* WIP
* Nav fix
* categories WS broadcast
* Used real search API
* Fixed unfurl ppreview
* set active team in sidebar
* IMplemented navigation on changing team in sidebar
* Misc fixes
* close rows inside transaction (#2045)
* update syntax for mysql (#2044)
* Upadted mutator for new patchBlock API
* Updated patchBlock API to use new URL
* Listeining to correct event in plugin mode
* Implemented WS messages for category operations:
* Fix duplicated build tags on Makefile
* Sidebar enhancements
* Add missing prefix to SQLite migration and fix flaky tests
* Sidebar boards menu enhancement
* Fix board page interactions (#2144)
* Fix patch board card properties error
* Fix board interactions
* Fix insert blocks interactions
* Fix app tests (#2104)
* Add json1 tag to vscode launch (#2157)
* Fix add, delete and update boards and add board patch generation (#2146)
* Fix update boards and add board patch generation
* Make add board and add template work, as well as deleting a board
* Update the state on board deletion
* Delete unused variable
* Fix bad parenthesis
* Fix board creation inside plugin, options were coming null due websocket message serialization
* update property type mutators to use boards API (#2168)
* Add permissions modal (#2196)
* Initial integration
* Permissions modal, websocket updates and API tests implemented
* Avoid updating/removing user if there is only one admin left
* Fix duplicates on board search
* Adds integration test
* Addressing PR review comments
Co-authored-by: Jesús Espino <jespinog@gmail.com>
* Merge
* I'm able to compile now
* Some fixes around tests execution
* Fixing migrations
* Fixing migrations order
* WIP
* Fixing some other compilation problems on tests
* Some typescript tests fixed
* Fixing javascript tests
* Fixing compilation
* Fixing some problems to create boards
* Load the templates on initial load
* Improvements over initial team templates import
* Adding new fields in the database
* Working on adding duplicate board api
* Removing RootID concept entirely
* Improving a bit the subscriptions
* Fixing store tests for notificationHints
* Fixing more tests
* fixing tests
* Fixing tests
* Fixing tests
* Fixing some small bugs related to templates
* Fixing registration link generation/regeneration
* Fixing cypress tests
* Adding store tests for duplicateBoard and duplicateBlock
* Addressing some TODO comments
* Making the export api simpler
* Add redirect component for old workspace urls
* Removing Dashboard code
* Delete only the built-in templates on update
* fixing tests
* Adding users autocompletion
* Updating snapshots
* Fixing bad merge
* fix panic when creating new card in notifysubscriptions (#2352)
* fix lint errors (#2353)
* fix lint errors
* fix panic when creating new card in notifysubscriptions (#2352)
* fix lint errors
* fix unit test
* Revert "fix unit test"
This reverts commit 0ad78aed65
.
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
* fix sql syntax error for SearchUsersByTeam (#2357)
* Fix mentions delivery (#2358)
* fix sql syntax error for SearchUsersByTeam
* fix mentions delivery
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* update api for octoClient calls, pass correct variables to mutator (#2359)
* Fixing tests after merge
* Fix sidebar context menu UI issue (#2399)
* Fix notification diff for text blocks (#2386)
* fix notification diff for text blocks; fix various linter errors.
* fix URLs to cards
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Permissions branch: Fix card links (#2391)
* fix notification diff for text blocks; fix various linter errors.
* fix URLs to cards
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixing sqlite tests
* Fixing server tests
* Update migrations to create global templates. (#2397)
* fix duplicate templates
* revert migrate.go
* update UI for empty templates
* implement updating built-in templates as global (teamId = 0)
* handle error if board not found
* update unit test
* fix more tests
* Update blocks_test.go
Fix merge issue
* fix migration sql error (#2414)
* Fixing frontend tests
* Set target team ID when using a global template (#2419)
* Fix some server tests
* Fixing onboarding creation
* Permissions branch: Fix unit tests and CI errors (part 1) (#2425)
* Fixing some small memory leaks (#2400)
* Fixing some small memory leaks
* fixing tests
* passing the tags to all test targets
* Increasing the timeout of the tests
* Fix some type checkings
* Permissions branch: Fixes all the linter errors (#2429)
* fix linter errors
* Reestructuring the router and splitting in more subcomponents (#2403)
* Reestructuring the router and splitting in more subcomponents
* Removing console.log calls
* Removing unneeded selector
* Addressing PR comment
* Fix redirection to one team when you load directly the boards home path
* Using properly the lastTeamID to redirect the user if needed
* don't allow last admin change/deleted (#2416)
* don't allow last admin change/deleted
* update for i18-extract
* fixed en.json
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
* Splitting BoardPage component into simpler/smaller components (#2435)
* Splitting BoardPage component into simpler/smaller components
* Removing unneeded import
* Replace go migrate with morph permissions (#2424)
* merge origin/replace-go-migrate-with-morph
* run go mod tidy on mattermost-plugin and increase test timeout
* fix merge issue temprorarily
* remove some debug changes
* fixing the linter
* Allow always team 0 (global) templates fetch (#2472)
* Fix problem with viewId 0 in the URL (#2473)
* Migrate from binddata to goembed (#2471)
* Adding join logic to the board switcher (#2434)
* Adding join logic to the board switcher
* Using already existing client function and removing the joinBoard one
* Adding support for autojoin based on url
* Fixing frontend tests
* fix webapp compile error, missing enableSharedBoards (#2501)
* Fixing duplication on postgres
* Adding back views to the sidebar (#2494)
* Fix #2507. Update Swagger comments (#2508)
* Fix the flash of the template selector on board/team switch (#2490)
* Fix the flash of the template selector on board/team switch
* More fixes specially around error handling
* Fixing the bot badge (#2487)
* simplifying a bit the team store sync between channels and focalboard (#2481)
* Fix menu tests (#2528)
* fix failing menu tests
* fix lint error
* Added keyboard shortcut for boards switcher (#2407)
* Added keyboard shortcut for boards switcher
* Fixed a type error
* Added some inline comments
* Fixed lint
* Fixed bug with scroll jumping when the card is opened: (#2477)
- avoid remounting of `ScrollingComponent` for each render of `Kanban` component
- property `autoFocus` set to false for `CalculationOptions` because it triggers `blur` even for the button in Jest tests and closes the menu
- snapshots for tests with `CalculationOptions` updated
* Adding the frontend support for permissions and applying it to a big part of the interface. (#2536)
* Initial work on permissions gates
* Applying permissions gates in more places
* Adding more checks to the interface
* Adding more permissions gates and keeping the store up to date
* fixing some tests
* Fixing some more tests
* Fixing another test
* Fixing all tests and adding some more
* Adding no-permission snapshot tests
* Addressing PR review comments
* Fixing invert behavior
* Permissions branch: No sqlstore calls after app shutdown (#2530)
* fix webapp compile error, missing enableSharedBoards
* refactor app init wip
* - ensure all block change notifications are finished before shutting down app
- fix unit tests for mysql (insert_at only has 1 second resolution!)
* adjust logging
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixed migrations to allow upgrading from previous version (#2535)
* Added mechanism to check if schema migration is needed
* WIP
* WIP
* WIP
* WIP
* Fixed migration
* Fixed for SQLite
* minor cleaniup
* Deleted old schema migration table after running migrations
* Removed a debug log
* Fixed a bug where the code always tried to delete a table which may or may not exist
* Show properly the user avatar in the ShareBoard component (#2542)
* Fixing the last CI problems from the permissions-branch (#2541)
* Fix history ordering
* Giving some times to avoid possible race conditions
* Empty
* Reverting accidental change in the config.json
* Optimizing table view (#2540)
* Optimizing table view
* Reducing the amount of rendering for tables
* Some other performance improvements
* Improve the activeView updates
* Some extra simplifications
* Another small improvement
* Fixing tests
* Fixing linter errors
* Reducing a bit the amount of dependency with big objects in the store
* Small simplification
* Removing Commenter role from the user role selector (#2561)
* Shareboard cleanup (#2550)
* Initial work on permissions gates
* Applying permissions gates in more places
* Adding more checks to the interface
* Adding more permissions gates and keeping the store up to date
* fixing some tests
* Fixing some more tests
* Fixing another test
* Fixing all tests and adding some more
* Adding no-permission snapshot tests
* Addressing PR review comments
* cleanup some shareboard settings
* remove unused property, fix for user items being displayed for non admin
* revert change, allow users to show
Co-authored-by: Jesús Espino <jespinog@gmail.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixing comments and cards with the new optimizations in the store (#2560)
* Fixing property creation (#2563)
* Fix user selection in table view (#2565)
* Fixing focus new row in table view (#2567)
* Permissions branch: Fix sqlite table lock (CI) (#2568)
* fix sqlite table lock
* remove test db on teardown
* revert .gitignore
* fix goimport on migration code
* fix typo
* more linter fixes
* clean up tmp db for sqlstore tests
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixing snapshots
* Migrating center panel to functional component (#2562)
* Migrating center panel to functional component
* Fixing some tests
* Fixing another test
* Fixing linter errors
* Fixing types errors
* Fixing linter error
* Fixing cypress tests
* Fixing the last cypress test
* Simpliying a bit the code
* Making property insertion more robust
* Updating checkbox test
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Chen-I Lim <46905241+chenilim@users.noreply.github.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: kamre <eremchenko@gmail.com>
264 lines
7.3 KiB
Go
264 lines
7.3 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package notifysubscriptions
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
"sync"
|
|
"text/template"
|
|
|
|
"github.com/mattermost/focalboard/server/model"
|
|
"github.com/wiggin77/merror"
|
|
|
|
mm_model "github.com/mattermost/mattermost-server/v6/model"
|
|
"github.com/mattermost/mattermost-server/v6/shared/mlog"
|
|
)
|
|
|
|
const (
|
|
// card change notifications.
|
|
defAddCardNotify = "{{.Authors | printAuthors \"unknown_user\" }} has added the card {{. | makeLink}}\n"
|
|
defModifyCardNotify = "###### {{.Authors | printAuthors \"unknown_user\" }} has modified the card {{. | makeLink}}\n"
|
|
defDeleteCardNotify = "{{.Authors | printAuthors \"unknown_user\" }} has deleted the card {{. | makeLink}}\n"
|
|
)
|
|
|
|
var (
|
|
// templateCache is a map of text templateCache keyed by languange code.
|
|
templateCache = make(map[string]*template.Template)
|
|
templateCacheMux sync.Mutex
|
|
)
|
|
|
|
// DiffConvOpts provides options when converting diffs to slack attachments.
|
|
type DiffConvOpts struct {
|
|
Language string
|
|
MakeCardLink func(block *model.Block, board *model.Board, card *model.Block) string
|
|
Logger *mlog.Logger
|
|
}
|
|
|
|
// getTemplate returns a new or cached named template based on the language specified.
|
|
func getTemplate(name string, opts DiffConvOpts, def string) (*template.Template, error) {
|
|
templateCacheMux.Lock()
|
|
defer templateCacheMux.Unlock()
|
|
|
|
key := name + "&" + opts.Language
|
|
t, ok := templateCache[key]
|
|
if !ok {
|
|
t = template.New(key)
|
|
|
|
if opts.MakeCardLink == nil {
|
|
opts.MakeCardLink = func(block *model.Block, _ *model.Board, _ *model.Block) string {
|
|
return fmt.Sprintf("`%s`", block.Title)
|
|
}
|
|
}
|
|
myFuncs := template.FuncMap{
|
|
"getBoardDescription": getBoardDescription,
|
|
"makeLink": func(diff *Diff) string {
|
|
return opts.MakeCardLink(diff.NewBlock, diff.Board, diff.Card)
|
|
},
|
|
"stripNewlines": func(s string) string {
|
|
return strings.TrimSpace(strings.ReplaceAll(s, "\n", "¶ "))
|
|
},
|
|
"printAuthors": func(empty string, authors StringMap) string {
|
|
return makeAuthorsList(authors, empty)
|
|
},
|
|
}
|
|
t.Funcs(myFuncs)
|
|
|
|
s := def // TODO: lookup i18n string when supported on server
|
|
t2, err := t.Parse(s)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("cannot parse markdown template '%s' for notifications: %w", key, err)
|
|
}
|
|
templateCache[key] = t2
|
|
}
|
|
return t, nil
|
|
}
|
|
|
|
func makeAuthorsList(authors StringMap, empty string) string {
|
|
if len(authors) == 0 {
|
|
return empty
|
|
}
|
|
prefix := ""
|
|
sb := &strings.Builder{}
|
|
for _, name := range authors.Values() {
|
|
sb.WriteString(prefix)
|
|
sb.WriteString("@")
|
|
sb.WriteString(strings.TrimSpace(name))
|
|
prefix = ", "
|
|
}
|
|
return sb.String()
|
|
}
|
|
|
|
// execTemplate executes the named template corresponding to the template name and language specified.
|
|
func execTemplate(w io.Writer, name string, opts DiffConvOpts, def string, data interface{}) error {
|
|
t, err := getTemplate(name, opts, def)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return t.Execute(w, data)
|
|
}
|
|
|
|
// Diffs2SlackAttachments converts a slice of `Diff` to slack attachments to be used in a post.
|
|
func Diffs2SlackAttachments(diffs []*Diff, opts DiffConvOpts) ([]*mm_model.SlackAttachment, error) {
|
|
var attachments []*mm_model.SlackAttachment
|
|
merr := merror.New()
|
|
|
|
for _, d := range diffs {
|
|
// only handle cards for now.
|
|
if d.BlockType == model.TypeCard {
|
|
a, err := cardDiff2SlackAttachment(d, opts)
|
|
if err != nil {
|
|
merr.Append(err)
|
|
continue
|
|
}
|
|
if a == nil {
|
|
continue
|
|
}
|
|
attachments = append(attachments, a)
|
|
}
|
|
}
|
|
return attachments, merr.ErrorOrNil()
|
|
}
|
|
|
|
func cardDiff2SlackAttachment(cardDiff *Diff, opts DiffConvOpts) (*mm_model.SlackAttachment, error) {
|
|
// sanity check
|
|
if cardDiff.NewBlock == nil && cardDiff.OldBlock == nil {
|
|
return nil, nil
|
|
}
|
|
|
|
attachment := &mm_model.SlackAttachment{}
|
|
buf := &bytes.Buffer{}
|
|
|
|
// card added
|
|
if cardDiff.NewBlock != nil && cardDiff.OldBlock == nil {
|
|
if err := execTemplate(buf, "AddCardNotify", opts, defAddCardNotify, cardDiff); err != nil {
|
|
return nil, err
|
|
}
|
|
attachment.Pretext = buf.String()
|
|
attachment.Fallback = attachment.Pretext
|
|
return attachment, nil
|
|
}
|
|
|
|
// card deleted
|
|
if (cardDiff.NewBlock == nil || cardDiff.NewBlock.DeleteAt != 0) && cardDiff.OldBlock != nil {
|
|
buf.Reset()
|
|
if err := execTemplate(buf, "DeleteCardNotify", opts, defDeleteCardNotify, cardDiff); err != nil {
|
|
return nil, err
|
|
}
|
|
attachment.Pretext = buf.String()
|
|
attachment.Fallback = attachment.Pretext
|
|
return attachment, nil
|
|
}
|
|
|
|
// at this point new and old block are non-nil
|
|
|
|
opts.Logger.Debug("cardDiff2SlackAttachment",
|
|
mlog.String("board_id", cardDiff.Board.ID),
|
|
mlog.String("card_id", cardDiff.Card.ID),
|
|
mlog.String("new_block_id", cardDiff.NewBlock.ID),
|
|
mlog.String("old_block_id", cardDiff.OldBlock.ID),
|
|
mlog.Int("childDiffs", len(cardDiff.Diffs)),
|
|
)
|
|
|
|
buf.Reset()
|
|
if err := execTemplate(buf, "ModifyCardNotify", opts, defModifyCardNotify, cardDiff); err != nil {
|
|
return nil, fmt.Errorf("cannot write notification for card %s: %w", cardDiff.NewBlock.ID, err)
|
|
}
|
|
attachment.Pretext = buf.String()
|
|
attachment.Fallback = attachment.Pretext
|
|
|
|
// title changes
|
|
if cardDiff.NewBlock.Title != cardDiff.OldBlock.Title {
|
|
attachment.Fields = append(attachment.Fields, &mm_model.SlackAttachmentField{
|
|
Short: false,
|
|
Title: "Title",
|
|
Value: fmt.Sprintf("%s ~~`%s`~~", stripNewlines(cardDiff.NewBlock.Title), stripNewlines(cardDiff.OldBlock.Title)),
|
|
})
|
|
}
|
|
|
|
// property changes
|
|
if len(cardDiff.PropDiffs) > 0 {
|
|
for _, propDiff := range cardDiff.PropDiffs {
|
|
if propDiff.NewValue == propDiff.OldValue {
|
|
continue
|
|
}
|
|
|
|
var val string
|
|
if propDiff.OldValue != "" {
|
|
val = fmt.Sprintf("%s ~~`%s`~~", stripNewlines(propDiff.NewValue), stripNewlines(propDiff.OldValue))
|
|
} else {
|
|
val = propDiff.NewValue
|
|
}
|
|
|
|
attachment.Fields = append(attachment.Fields, &mm_model.SlackAttachmentField{
|
|
Short: false,
|
|
Title: propDiff.Name,
|
|
Value: val,
|
|
})
|
|
}
|
|
}
|
|
|
|
// comment add/delete
|
|
for _, child := range cardDiff.Diffs {
|
|
if child.BlockType == model.TypeComment {
|
|
var format string
|
|
var block *model.Block
|
|
if child.NewBlock != nil && child.OldBlock == nil {
|
|
// added comment
|
|
format = "%s"
|
|
block = child.NewBlock
|
|
}
|
|
|
|
if child.NewBlock == nil && child.OldBlock != nil {
|
|
// deleted comment
|
|
format = "~~`%s`~~"
|
|
block = child.OldBlock
|
|
}
|
|
|
|
if format != "" {
|
|
attachment.Fields = append(attachment.Fields, &mm_model.SlackAttachmentField{
|
|
Short: false,
|
|
Title: "Comment by " + makeAuthorsList(child.Authors, "unknown_user"), // todo: localize this when server has i18n
|
|
Value: fmt.Sprintf(format, stripNewlines(block.Title)),
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
// content/description changes
|
|
for _, child := range cardDiff.Diffs {
|
|
if child.BlockType != model.TypeComment {
|
|
var newTitle, oldTitle string
|
|
if child.NewBlock != nil {
|
|
newTitle = stripNewlines(child.NewBlock.Title)
|
|
}
|
|
if child.OldBlock != nil {
|
|
oldTitle = stripNewlines(child.OldBlock.Title)
|
|
}
|
|
|
|
if newTitle == oldTitle {
|
|
continue
|
|
}
|
|
|
|
markdown := generateMarkdownDiff(oldTitle, newTitle, opts.Logger)
|
|
if markdown == "" {
|
|
continue
|
|
}
|
|
|
|
attachment.Fields = append(attachment.Fields, &mm_model.SlackAttachmentField{
|
|
Short: false,
|
|
Title: "Description",
|
|
Value: markdown,
|
|
})
|
|
}
|
|
}
|
|
|
|
if len(attachment.Fields) == 0 {
|
|
return nil, nil
|
|
}
|
|
return attachment, nil
|
|
}
|