mirror of
https://github.com/mattermost/focalboard.git
synced 2024-12-24 13:43:12 +02:00
08c0b7a2fd
* Refactor error usage from the store level up and add API helpers * Complete API tests * Fix merge errorResponse calls * Remove ensure helpers to allow for custom messages on permission errors * Fix bad import and call * Remove bad user check on auth that was added as part of the main merge * Fix empty list test * Replace deprecated proxy calls to ioutil.ReadAll with io.ReadAll * Add information to the NotFound errors * Add context to all remaining errors and address review comments * Fix linter * Adapt the new card API endpoints to the error refactor * Remove almost all customErrorResponse calls * Add request entity too large to errorResponse and remove customErrorResponse * Fix linter
85 lines
2.0 KiB
Go
85 lines
2.0 KiB
Go
package app
|
|
|
|
import (
|
|
"database/sql"
|
|
"testing"
|
|
|
|
"github.com/mattermost/focalboard/server/model"
|
|
"github.com/mattermost/focalboard/server/utils"
|
|
"github.com/pkg/errors"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGetSharing(t *testing.T) {
|
|
th, tearDown := SetupTestHelper(t)
|
|
defer tearDown()
|
|
|
|
t.Run("should get a sharing successfully", func(t *testing.T) {
|
|
want := &model.Sharing{
|
|
ID: utils.NewID(utils.IDTypeBlock),
|
|
Enabled: true,
|
|
Token: "token",
|
|
ModifiedBy: "otherid",
|
|
UpdateAt: utils.GetMillis(),
|
|
}
|
|
th.Store.EXPECT().GetSharing("test-id").Return(want, nil)
|
|
|
|
result, err := th.App.GetSharing("test-id")
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, result, want)
|
|
require.NotNil(t, th.App)
|
|
})
|
|
|
|
t.Run("should fail to get a sharing", func(t *testing.T) {
|
|
th.Store.EXPECT().GetSharing("test-id").Return(
|
|
nil,
|
|
errors.New("sharing not found"),
|
|
)
|
|
result, err := th.App.GetSharing("test-id")
|
|
|
|
require.Nil(t, result)
|
|
require.Error(t, err)
|
|
require.Equal(t, "sharing not found", err.Error())
|
|
})
|
|
|
|
t.Run("should return a not found error", func(t *testing.T) {
|
|
th.Store.EXPECT().GetSharing("test-id").Return(
|
|
nil,
|
|
sql.ErrNoRows,
|
|
)
|
|
result, err := th.App.GetSharing("test-id")
|
|
require.Error(t, err)
|
|
require.True(t, model.IsErrNotFound(err))
|
|
require.Nil(t, result)
|
|
})
|
|
}
|
|
|
|
func TestUpsertSharing(t *testing.T) {
|
|
th, tearDown := SetupTestHelper(t)
|
|
defer tearDown()
|
|
|
|
sharing := model.Sharing{
|
|
ID: utils.NewID(utils.IDTypeBlock),
|
|
Enabled: true,
|
|
Token: "token",
|
|
ModifiedBy: "otherid",
|
|
UpdateAt: utils.GetMillis(),
|
|
}
|
|
|
|
t.Run("should success to upsert sharing", func(t *testing.T) {
|
|
th.Store.EXPECT().UpsertSharing(sharing).Return(nil)
|
|
err := th.App.UpsertSharing(sharing)
|
|
|
|
require.NoError(t, err)
|
|
})
|
|
|
|
t.Run("should fail to upsert a sharing", func(t *testing.T) {
|
|
th.Store.EXPECT().UpsertSharing(sharing).Return(errors.New("sharing not found"))
|
|
err := th.App.UpsertSharing(sharing)
|
|
|
|
require.Error(t, err)
|
|
require.Equal(t, "sharing not found", err.Error())
|
|
})
|
|
}
|