1
0
mirror of https://github.com/mattermost/focalboard.git synced 2024-12-24 13:43:12 +02:00
focalboard/server/services/store/storetests/blocks.go
Chen-I Lim c3a4921ac3
GetBoardMetadata API (#2569)
* wip

* Added data migration for populating categories

* wip

* Added data migration for populating categories

* Store WIP

* migration WIP

* category CRUD APIs complete

* category block API WIP

* block category update API done

* Fetcehed data into store

* Started displayting sidebar data

* sidebar WIP

* Dashboard - basic changes

* Sidebar dashboard btn and board switcher UI only

* Sidebar dashboard btn and board switcher UI only

* create category dialog WIP

* Create category webapp side done

* Integrated move card to other category

* board to block

* Disabled dashboard route for now as we'll implement it in phase 2

* WIP

* Added logic to open last board/view on per team level

* Add workspace to teams and boards migrations (#1986)

* Add workspace to teams and boards migrations

* Update json annotations on board models

* boards search dialog WIP

* Seach dialog WIP

* Implemented opening boiard from search results

* Boards switcher styliung

* Handled update category WS event

* Template support

* personal server support and styling fixes

* test fix WIP

* Fixed a bug causing boards to not be moved correctly beteen categories

* Fixed webapp tests

* fix

* Store changes (#2011)

* Permissions phase 1 - Websocket updates (#2014)

* Store changes

* Websockets changes

* Permissions phase 1 - Permissions service (#2015)

* Store changes

* Websockets changes

* Permissions service

* Api and app updates (#2016)

* Store changes

* Websockets changes

* Permissions service

* New API and App changes

* Delete and Patch boards and blocks endpoints

* Used correct variable

* Webapp changes WIP

* Open correct team URL

* Fixed get block API

* Used React context for workspace users

* WIP

* On load navigation sorted out

* WIP

* Nav fix

* categories WS broadcast

* Used real search API

* Fixed unfurl ppreview

* set active team in sidebar

* IMplemented navigation on changing team in sidebar

* Misc fixes

* close rows inside transaction (#2045)

* update syntax for mysql (#2044)

* Upadted mutator for new patchBlock API

* Updated patchBlock API to use new URL

* Listeining to correct event in plugin mode

* Implemented WS messages for category operations:

* Fix duplicated build tags on Makefile

* Sidebar enhancements

* Add missing prefix to SQLite migration and fix flaky tests

* Sidebar boards menu enhancement

* Fix board page interactions (#2144)

* Fix patch board card properties error

* Fix board interactions

* Fix insert blocks interactions

* Fix app tests (#2104)

* Add json1 tag to vscode launch (#2157)

* Fix add, delete and update boards and add board patch generation (#2146)

* Fix update boards and add board patch generation

* Make add board and add template work, as well as deleting a board

* Update the state on board deletion

* Delete unused variable

* Fix bad parenthesis

* Fix board creation inside plugin, options were coming null due websocket message serialization

* update property type mutators to use boards API (#2168)

* Add permissions modal (#2196)

* Initial integration

* Permissions modal, websocket updates and API tests implemented

* Avoid updating/removing user if there is only one admin left

* Fix duplicates on board search

* Adds integration test

* Addressing PR review comments

Co-authored-by: Jesús Espino <jespinog@gmail.com>

* Merge

* I'm able to compile now

* Some fixes around tests execution

* Fixing migrations

* Fixing migrations order

* WIP

* Fixing some other compilation problems on tests

* Some typescript tests fixed

* Fixing javascript tests

* Fixing compilation

* Fixing some problems to create boards

* Load the templates on initial load

* Improvements over initial team templates import

* Adding new fields in the database

* Working on adding duplicate board api

* Removing RootID concept entirely

* Improving a bit the subscriptions

* Fixing store tests for notificationHints

* Fixing more tests

* fixing tests

* Fixing tests

* Fixing tests

* Fixing some small bugs related to templates

* Fixing registration link generation/regeneration

* Fixing cypress tests

* Adding store tests for duplicateBoard and duplicateBlock

* Addressing some TODO comments

* Making the export api simpler

* Add redirect component for old workspace urls

* Removing Dashboard code

* Delete only the built-in templates on update

* fixing tests

* Adding users autocompletion

* Updating snapshots

* Fixing bad merge

* fix panic when creating new card in notifysubscriptions (#2352)

* fix lint errors (#2353)

* fix lint errors

* fix panic when creating new card in notifysubscriptions (#2352)

* fix lint errors

* fix unit test

* Revert "fix unit test"

This reverts commit 0ad78aed65.

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* fix sql syntax error for SearchUsersByTeam (#2357)

* Fix mentions delivery (#2358)

* fix sql syntax error for SearchUsersByTeam

* fix mentions delivery

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* update api for octoClient calls, pass correct variables to mutator (#2359)

* Fixing tests after merge

* Fix sidebar context menu UI issue (#2399)

* Fix notification diff for text blocks (#2386)

* fix notification diff for text blocks; fix various linter errors.

* fix URLs to cards

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Permissions branch: Fix card links (#2391)

* fix notification diff for text blocks; fix various linter errors.

* fix URLs to cards

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Fixing sqlite tests

* Fixing server tests

* Update migrations to create global templates. (#2397)

* fix duplicate templates

* revert migrate.go

* update UI for empty templates

* implement updating built-in templates as global (teamId = 0)

* handle error if board not found

* update unit test

* fix more tests

* Update blocks_test.go

Fix merge issue

* fix migration sql error (#2414)

* Fixing frontend tests

* Set target team ID when using a global template (#2419)

* Fix some server tests

* Fixing onboarding creation

* Permissions branch: Fix unit tests and CI errors (part 1) (#2425)

* Fixing some small memory leaks (#2400)

* Fixing some small memory leaks

* fixing tests

* passing the tags to all test targets

* Increasing the timeout of the tests

* Fix some type checkings

* Permissions branch: Fixes all the linter errors (#2429)

* fix linter errors

* Reestructuring the router and splitting in more subcomponents (#2403)

* Reestructuring the router and splitting in more subcomponents

* Removing console.log calls

* Removing unneeded selector

* Addressing PR comment

* Fix redirection to one team when you load directly the boards home path

* Using properly the lastTeamID to redirect the user if needed

* don't allow last admin change/deleted (#2416)

* don't allow last admin change/deleted

* update for i18-extract

* fixed en.json

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>

* Splitting BoardPage component into simpler/smaller components (#2435)

* Splitting BoardPage component into simpler/smaller components

* Removing unneeded import

* Replace go migrate with morph permissions (#2424)

* merge origin/replace-go-migrate-with-morph

* run go mod tidy on mattermost-plugin and increase test timeout

* fix merge issue temprorarily

* remove some debug changes

* fixing the linter

* Allow always team 0 (global) templates fetch (#2472)

* Fix problem with viewId 0 in the URL (#2473)

* Migrate from binddata to goembed (#2471)

* Adding join logic to the board switcher (#2434)

* Adding join logic to the board switcher

* Using already existing client function and removing the joinBoard one

* Adding support for autojoin based on url

* Fixing frontend tests

* fix webapp compile error, missing enableSharedBoards (#2501)

* Fixing duplication on postgres

* Adding back views to the sidebar (#2494)

* Fix #2507. Update Swagger comments (#2508)

* Fix the flash of the template selector on board/team switch (#2490)

* Fix the flash of the template selector on board/team switch

* More fixes specially around error handling

* Fixing the bot badge (#2487)

* simplifying a bit the team store sync between channels and focalboard (#2481)

* Fix menu tests (#2528)

* fix failing menu tests

* fix lint error

* Added keyboard shortcut for boards switcher (#2407)

* Added keyboard shortcut for boards switcher

* Fixed a type error

* Added some inline comments

* Fixed lint

* Fixed bug with scroll jumping when the card is opened: (#2477)

- avoid remounting of `ScrollingComponent` for each render of `Kanban` component
  - property `autoFocus` set to false for `CalculationOptions` because it triggers `blur` even for the button in Jest tests and closes the menu
  - snapshots for tests with `CalculationOptions` updated

* Adding the frontend support for permissions and applying it to a big part of the interface. (#2536)

* Initial work on permissions gates

* Applying permissions gates in more places

* Adding more checks to the interface

* Adding more permissions gates and keeping the store up to date

* fixing some tests

* Fixing some more tests

* Fixing another test

* Fixing all tests and adding some more

* Adding no-permission snapshot tests

* Addressing PR review comments

* Fixing invert behavior

* Permissions branch:  No sqlstore calls after app shutdown (#2530)

* fix webapp compile error, missing enableSharedBoards

* refactor app init wip

* - ensure all block change notifications are finished before shutting down app
- fix unit tests for mysql (insert_at only has 1 second resolution!)

* adjust logging

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Fixed migrations to allow upgrading from previous version (#2535)

* Added mechanism to check if schema migration is needed

* WIP

* WIP

* WIP

* WIP

* Fixed migration

* Fixed for SQLite

* minor cleaniup

* Deleted old schema migration table after running migrations

* Removed a debug log

* Fixed a bug where the code always tried to delete a table which may or may not exist

* Show properly the user avatar in the ShareBoard component (#2542)

* Fixing the last CI problems from the permissions-branch (#2541)

* Fix history ordering

* Giving some times to avoid possible race conditions

* Empty

* Reverting accidental change in the config.json

* Optimizing table view (#2540)

* Optimizing table view

* Reducing the amount of rendering for tables

* Some other performance improvements

* Improve the activeView updates

* Some extra simplifications

* Another small improvement

* Fixing tests

* Fixing linter errors

* Reducing a bit the amount of dependency with big objects in the store

* Small simplification

* Removing Commenter role from the user role selector (#2561)

* Shareboard cleanup (#2550)

* Initial work on permissions gates

* Applying permissions gates in more places

* Adding more checks to the interface

* Adding more permissions gates and keeping the store up to date

* fixing some tests

* Fixing some more tests

* Fixing another test

* Fixing all tests and adding some more

* Adding no-permission snapshot tests

* Addressing PR review comments

* cleanup some shareboard settings

* remove unused property, fix for user items being displayed for non admin

* revert change, allow users to show

Co-authored-by: Jesús Espino <jespinog@gmail.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* GetBoardMetadata API

* Integration tests. WIP

* getBoardHistory

* Working integration test

* Fix ordering, add store tests

* Fix: Update board_history update_at on patch

* sqltests

* Fix unmarshall delete boards_history

* testGetBlockMetadata with delete and undelete

* Handle board not found

* Fixing comments and cards with the new optimizations in the store (#2560)

* Fixing property creation (#2563)

* Cleanup

* Fix user selection in table view (#2565)

* Fixing focus new row in table view (#2567)

* Permissions branch: Fix sqlite table lock (CI) (#2568)

* fix sqlite table lock

* remove test db on teardown

* revert .gitignore

* fix goimport on migration code

* fix typo

* more linter fixes

* clean up tmp db for sqlstore tests

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Fixing snapshots

* Remove debug log

* Return metadata for deleted boards

* Migrating center panel to functional component (#2562)

* Migrating center panel to functional component

* Fixing some tests

* Fixing another test

* Fixing linter errors

* Fixing types errors

* Fixing linter error

* Fixing cypress tests

* Fixing the last cypress test

* Simpliying a bit the code

* Making property insertion more robust

* Updating checkbox test

* License check

* Cleanup and update Swagger docs

* Merge from main

* Fix bad merge

* Fix Linux-app build break

* do mod tidy

* Fix server lint

* Require credentials (not only read token)

* Add missing defer CloseRows

* do mod tidy

Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Jesús Espino <jespinog@gmail.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: kamre <eremchenko@gmail.com>
2022-03-29 14:47:49 -07:00

1066 lines
29 KiB
Go

package storetests
import (
"testing"
"time"
"github.com/mattermost/focalboard/server/model"
"github.com/mattermost/focalboard/server/services/store"
"github.com/mattermost/focalboard/server/utils"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
const (
testUserID = "user-id"
testTeamID = "team-id"
testBoardID = "board-id"
)
//nolint:dupl
func StoreTestBlocksStore(t *testing.T, setup func(t *testing.T) (store.Store, func())) {
t.Run("InsertBlock", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testInsertBlock(t, store)
})
t.Run("InsertBlocks", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testInsertBlocks(t, store)
})
t.Run("PatchBlock", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testPatchBlock(t, store)
})
t.Run("PatchBlocks", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testPatchBlocks(t, store)
})
t.Run("DeleteBlock", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testDeleteBlock(t, store)
})
t.Run("UndeleteBlock", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testUndeleteBlock(t, store)
})
t.Run("GetSubTree2", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testGetSubTree2(t, store)
})
t.Run("GetSubTree3", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testGetSubTree3(t, store)
})
t.Run("GetBlocks", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testGetBlocks(t, store)
})
t.Run("GetBlock", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testGetBlock(t, store)
})
t.Run("DuplicateBlock", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testDuplicateBlock(t, store)
})
t.Run("GetBlockMetadata", func(t *testing.T) {
store, tearDown := setup(t)
defer tearDown()
testGetBlockMetadata(t, store)
})
}
func testInsertBlock(t *testing.T, store store.Store) {
userID := testUserID
boardID := testBoardID
blocks, errBlocks := store.GetBlocksForBoard(boardID)
require.NoError(t, errBlocks)
initialCount := len(blocks)
t.Run("valid block", func(t *testing.T) {
block := model.Block{
ID: "id-test",
BoardID: boardID,
ModifiedBy: userID,
}
err := store.InsertBlock(&block, "user-id-1")
require.NoError(t, err)
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+1)
})
t.Run("invalid rootid", func(t *testing.T) {
block := model.Block{
ID: "id-test",
BoardID: "",
ModifiedBy: userID,
}
err := store.InsertBlock(&block, "user-id-1")
require.Error(t, err)
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+1)
})
t.Run("invalid fields data", func(t *testing.T) {
block := model.Block{
ID: "id-test",
BoardID: "id-test",
ModifiedBy: userID,
Fields: map[string]interface{}{"no-serialiable-value": t.Run},
}
err := store.InsertBlock(&block, "user-id-1")
require.Error(t, err)
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+1)
})
t.Run("insert new block", func(t *testing.T) {
block := model.Block{
BoardID: testBoardID,
}
err := store.InsertBlock(&block, "user-id-2")
require.NoError(t, err)
require.Equal(t, "user-id-2", block.CreatedBy)
})
t.Run("update existing block", func(t *testing.T) {
block := model.Block{
ID: "id-2",
BoardID: "board-id-1",
Title: "Old Title",
}
// inserting
err := store.InsertBlock(&block, "user-id-2")
require.NoError(t, err)
// created by populated from user id for new blocks
require.Equal(t, "user-id-2", block.CreatedBy)
// hack to avoid multiple, quick updates to a card
// violating block_history composite primary key constraint
time.Sleep(1 * time.Millisecond)
// updating
newBlock := model.Block{
ID: "id-2",
BoardID: "board-id-1",
CreatedBy: "user-id-3",
Title: "New Title",
}
err = store.InsertBlock(&newBlock, "user-id-4")
require.NoError(t, err)
// created by is not altered for existing blocks
require.Equal(t, "user-id-3", newBlock.CreatedBy)
require.Equal(t, "New Title", newBlock.Title)
})
createdAt, err := time.Parse(time.RFC822, "01 Jan 90 01:00 IST")
assert.NoError(t, err)
updateAt, err := time.Parse(time.RFC822, "02 Jan 90 01:00 IST")
assert.NoError(t, err)
t.Run("data tamper attempt", func(t *testing.T) {
block := model.Block{
ID: "id-10",
BoardID: "board-id-1",
Title: "Old Title",
CreateAt: utils.GetMillisForTime(createdAt),
UpdateAt: utils.GetMillisForTime(updateAt),
CreatedBy: "user-id-5",
ModifiedBy: "user-id-6",
}
// inserting
err := store.InsertBlock(&block, "user-id-1")
require.NoError(t, err)
retrievedBlock, err := store.GetBlock("id-10")
assert.NoError(t, err)
assert.NotNil(t, retrievedBlock)
assert.Equal(t, "board-id-1", retrievedBlock.BoardID)
assert.Equal(t, "user-id-1", retrievedBlock.CreatedBy)
assert.Equal(t, "user-id-1", retrievedBlock.ModifiedBy)
assert.WithinDurationf(t, time.Now(), utils.GetTimeForMillis(retrievedBlock.CreateAt), 1*time.Second, "create time should be current time")
assert.WithinDurationf(t, time.Now(), utils.GetTimeForMillis(retrievedBlock.UpdateAt), 1*time.Second, "update time should be current time")
})
}
func testInsertBlocks(t *testing.T, store store.Store) {
userID := testUserID
blocks, errBlocks := store.GetBlocksForBoard("id-test")
require.NoError(t, errBlocks)
initialCount := len(blocks)
t.Run("invalid block", func(t *testing.T) {
validBlock := model.Block{
ID: "id-test",
BoardID: "id-test",
ModifiedBy: userID,
}
invalidBlock := model.Block{
ID: "id-test",
BoardID: "",
ModifiedBy: userID,
}
newBlocks := []model.Block{validBlock, invalidBlock}
time.Sleep(1 * time.Millisecond)
err := store.InsertBlocks(newBlocks, "user-id-1")
require.Error(t, err)
blocks, err := store.GetBlocksForBoard("id-test")
require.NoError(t, err)
// no blocks should have been inserted
require.Len(t, blocks, initialCount)
})
}
func testPatchBlock(t *testing.T, store store.Store) {
userID := testUserID
boardID := "board-id-1"
block := model.Block{
ID: "id-test",
BoardID: boardID,
Title: "oldTitle",
ModifiedBy: userID,
Fields: map[string]interface{}{"test": "test value", "test2": "test value 2"},
}
err := store.InsertBlock(&block, "user-id-1")
require.NoError(t, err)
blocks, errBlocks := store.GetBlocksForBoard(boardID)
require.NoError(t, errBlocks)
initialCount := len(blocks)
t.Run("not existing block id", func(t *testing.T) {
err := store.PatchBlock("invalid-block-id", &model.BlockPatch{}, "user-id-1")
require.Error(t, err)
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount)
})
t.Run("invalid rootid", func(t *testing.T) {
wrongBoardID := ""
blockPatch := model.BlockPatch{
BoardID: &wrongBoardID,
}
err := store.PatchBlock("id-test", &blockPatch, "user-id-1")
require.Error(t, err)
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount)
})
t.Run("invalid fields data", func(t *testing.T) {
blockPatch := model.BlockPatch{
UpdatedFields: map[string]interface{}{"no-serialiable-value": t.Run},
}
err := store.PatchBlock("id-test", &blockPatch, "user-id-1")
require.Error(t, err)
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount)
})
t.Run("update block fields", func(t *testing.T) {
newTitle := "New title"
blockPatch := model.BlockPatch{
Title: &newTitle,
}
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
// inserting
err := store.PatchBlock("id-test", &blockPatch, "user-id-2")
require.NoError(t, err)
retrievedBlock, err := store.GetBlock("id-test")
require.NoError(t, err)
// created by populated from user id for new blocks
require.Equal(t, "user-id-2", retrievedBlock.ModifiedBy)
require.Equal(t, "New title", retrievedBlock.Title)
})
t.Run("update block custom fields", func(t *testing.T) {
blockPatch := model.BlockPatch{
UpdatedFields: map[string]interface{}{"test": "new test value", "test3": "new value"},
}
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
// inserting
err := store.PatchBlock("id-test", &blockPatch, "user-id-2")
require.NoError(t, err)
retrievedBlock, err := store.GetBlock("id-test")
require.NoError(t, err)
// created by populated from user id for new blocks
require.Equal(t, "user-id-2", retrievedBlock.ModifiedBy)
require.Equal(t, "new test value", retrievedBlock.Fields["test"])
require.Equal(t, "test value 2", retrievedBlock.Fields["test2"])
require.Equal(t, "new value", retrievedBlock.Fields["test3"])
})
t.Run("remove block custom fields", func(t *testing.T) {
blockPatch := model.BlockPatch{
DeletedFields: []string{"test", "test3", "test100"},
}
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
// inserting
err := store.PatchBlock("id-test", &blockPatch, "user-id-2")
require.NoError(t, err)
retrievedBlock, err := store.GetBlock("id-test")
require.NoError(t, err)
// created by populated from user id for new blocks
require.Equal(t, "user-id-2", retrievedBlock.ModifiedBy)
require.Equal(t, nil, retrievedBlock.Fields["test"])
require.Equal(t, "test value 2", retrievedBlock.Fields["test2"])
require.Equal(t, nil, retrievedBlock.Fields["test3"])
})
}
func testPatchBlocks(t *testing.T, store store.Store) {
block := model.Block{
ID: "id-test",
BoardID: "id-test",
Title: "oldTitle",
}
block2 := model.Block{
ID: "id-test2",
BoardID: "id-test2",
Title: "oldTitle2",
}
insertBlocks := []model.Block{block, block2}
err := store.InsertBlocks(insertBlocks, "user-id-1")
require.NoError(t, err)
t.Run("successful updated existing blocks", func(t *testing.T) {
title := "updatedTitle"
blockPatch := model.BlockPatch{
Title: &title,
}
blockPatch2 := model.BlockPatch{
Title: &title,
}
blockIds := []string{"id-test", "id-test2"}
blockPatches := []model.BlockPatch{blockPatch, blockPatch2}
time.Sleep(1 * time.Millisecond)
err := store.PatchBlocks(&model.BlockPatchBatch{BlockIDs: blockIds, BlockPatches: blockPatches}, "user-id-1")
require.NoError(t, err)
retrievedBlock, err := store.GetBlock("id-test")
require.NoError(t, err)
require.Equal(t, title, retrievedBlock.Title)
retrievedBlock2, err := store.GetBlock("id-test2")
require.NoError(t, err)
require.Equal(t, title, retrievedBlock2.Title)
})
t.Run("invalid block id, nothing updated existing blocks", func(t *testing.T) {
if store.DBType() == model.SqliteDBType {
t.Skip("No transactions support int sqlite")
}
title := "Another Title"
blockPatch := model.BlockPatch{
Title: &title,
}
blockPatch2 := model.BlockPatch{
Title: &title,
}
blockIds := []string{"id-test", "invalid id"}
blockPatches := []model.BlockPatch{blockPatch, blockPatch2}
time.Sleep(1 * time.Millisecond)
err := store.PatchBlocks(&model.BlockPatchBatch{BlockIDs: blockIds, BlockPatches: blockPatches}, "user-id-1")
require.Error(t, err)
retrievedBlock, err := store.GetBlock("id-test")
require.NoError(t, err)
require.NotEqual(t, title, retrievedBlock.Title)
})
}
var (
subtreeSampleBlocks = []model.Block{
{
ID: "parent",
BoardID: testBoardID,
ModifiedBy: testUserID,
},
{
ID: "child1",
BoardID: testBoardID,
ParentID: "parent",
ModifiedBy: testUserID,
},
{
ID: "child2",
BoardID: testBoardID,
ParentID: "parent",
ModifiedBy: testUserID,
},
{
ID: "grandchild1",
BoardID: testBoardID,
ParentID: "child1",
ModifiedBy: testUserID,
},
{
ID: "grandchild2",
BoardID: testBoardID,
ParentID: "child2",
ModifiedBy: testUserID,
},
{
ID: "greatgrandchild1",
BoardID: testBoardID,
ParentID: "grandchild1",
ModifiedBy: testUserID,
},
}
)
func testGetSubTree2(t *testing.T, store store.Store) {
boardID := testBoardID
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
initialCount := len(blocks)
InsertBlocks(t, store, subtreeSampleBlocks, "user-id-1")
time.Sleep(1 * time.Millisecond)
defer DeleteBlocks(t, store, subtreeSampleBlocks, "test")
blocks, err = store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+6)
t.Run("from root id", func(t *testing.T) {
blocks, err = store.GetSubTree2(boardID, "parent", model.QuerySubtreeOptions{})
require.NoError(t, err)
require.Len(t, blocks, 3)
require.True(t, ContainsBlockWithID(blocks, "parent"))
require.True(t, ContainsBlockWithID(blocks, "child1"))
require.True(t, ContainsBlockWithID(blocks, "child2"))
})
t.Run("from child id", func(t *testing.T) {
blocks, err = store.GetSubTree2(boardID, "child1", model.QuerySubtreeOptions{})
require.NoError(t, err)
require.Len(t, blocks, 2)
require.True(t, ContainsBlockWithID(blocks, "child1"))
require.True(t, ContainsBlockWithID(blocks, "grandchild1"))
})
t.Run("from not existing id", func(t *testing.T) {
blocks, err = store.GetSubTree2(boardID, "not-exists", model.QuerySubtreeOptions{})
require.NoError(t, err)
require.Len(t, blocks, 0)
})
}
func testGetSubTree3(t *testing.T, store store.Store) {
boardID := testBoardID
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
initialCount := len(blocks)
InsertBlocks(t, store, subtreeSampleBlocks, "user-id-1")
time.Sleep(1 * time.Millisecond)
defer DeleteBlocks(t, store, subtreeSampleBlocks, "test")
blocks, err = store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+6)
t.Run("from board id", func(t *testing.T) {
blocks, err = store.GetSubTree3(boardID, "parent", model.QuerySubtreeOptions{})
require.NoError(t, err)
require.Len(t, blocks, 5)
require.True(t, ContainsBlockWithID(blocks, "parent"))
require.True(t, ContainsBlockWithID(blocks, "child1"))
require.True(t, ContainsBlockWithID(blocks, "child2"))
require.True(t, ContainsBlockWithID(blocks, "grandchild1"))
require.True(t, ContainsBlockWithID(blocks, "grandchild2"))
})
t.Run("from child id", func(t *testing.T) {
blocks, err = store.GetSubTree3(boardID, "child1", model.QuerySubtreeOptions{})
require.NoError(t, err)
require.Len(t, blocks, 3)
require.True(t, ContainsBlockWithID(blocks, "child1"))
require.True(t, ContainsBlockWithID(blocks, "grandchild1"))
require.True(t, ContainsBlockWithID(blocks, "greatgrandchild1"))
})
t.Run("from not existing id", func(t *testing.T) {
blocks, err = store.GetSubTree3(boardID, "not-exists", model.QuerySubtreeOptions{})
require.NoError(t, err)
require.Len(t, blocks, 0)
})
}
func testDeleteBlock(t *testing.T, store store.Store) {
userID := testUserID
boardID := testBoardID
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
initialCount := len(blocks)
blocksToInsert := []model.Block{
{
ID: "block1",
BoardID: boardID,
ModifiedBy: userID,
},
{
ID: "block2",
BoardID: boardID,
ModifiedBy: userID,
},
{
ID: "block3",
BoardID: boardID,
ModifiedBy: userID,
},
}
InsertBlocks(t, store, blocksToInsert, "user-id-1")
defer DeleteBlocks(t, store, blocksToInsert, "test")
blocks, err = store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+3)
t.Run("existing id", func(t *testing.T) {
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err := store.DeleteBlock("block1", userID)
require.NoError(t, err)
})
t.Run("existing id multiple times", func(t *testing.T) {
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err := store.DeleteBlock("block1", userID)
require.NoError(t, err)
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err = store.DeleteBlock("block1", userID)
require.NoError(t, err)
})
t.Run("from not existing id", func(t *testing.T) {
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err := store.DeleteBlock("not-exists", userID)
require.NoError(t, err)
})
}
func testUndeleteBlock(t *testing.T, store store.Store) {
boardID := testBoardID
userID := testUserID
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
initialCount := len(blocks)
blocksToInsert := []model.Block{
{
ID: "block1",
BoardID: boardID,
ModifiedBy: userID,
},
{
ID: "block2",
BoardID: boardID,
ModifiedBy: userID,
},
{
ID: "block3",
BoardID: boardID,
ModifiedBy: userID,
},
}
InsertBlocks(t, store, blocksToInsert, "user-id-1")
defer DeleteBlocks(t, store, blocksToInsert, "test")
blocks, err = store.GetBlocksForBoard(boardID)
require.NoError(t, err)
require.Len(t, blocks, initialCount+3)
t.Run("existing id", func(t *testing.T) {
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err := store.DeleteBlock("block1", userID)
require.NoError(t, err)
block, err := store.GetBlock("block1")
require.NoError(t, err)
require.Nil(t, block)
time.Sleep(1 * time.Millisecond)
err = store.UndeleteBlock("block1", userID)
require.NoError(t, err)
block, err = store.GetBlock("block1")
require.NoError(t, err)
require.NotNil(t, block)
})
t.Run("existing id multiple times", func(t *testing.T) {
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err := store.DeleteBlock("block1", userID)
require.NoError(t, err)
block, err := store.GetBlock("block1")
require.NoError(t, err)
require.Nil(t, block)
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err = store.UndeleteBlock("block1", userID)
require.NoError(t, err)
block, err = store.GetBlock("block1")
require.NoError(t, err)
require.NotNil(t, block)
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err = store.UndeleteBlock("block1", userID)
require.NoError(t, err)
block, err = store.GetBlock("block1")
require.NoError(t, err)
require.NotNil(t, block)
})
t.Run("from not existing id", func(t *testing.T) {
// Wait for not colliding the ID+insert_at key
time.Sleep(1 * time.Millisecond)
err := store.UndeleteBlock("not-exists", userID)
require.NoError(t, err)
block, err := store.GetBlock("not-exists")
require.NoError(t, err)
require.Nil(t, block)
})
}
func testGetBlocks(t *testing.T, store store.Store) {
boardID := testBoardID
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
blocksToInsert := []model.Block{
{
ID: "block1",
BoardID: boardID,
ParentID: "",
ModifiedBy: testUserID,
Type: "test",
},
{
ID: "block2",
BoardID: boardID,
ParentID: "block1",
ModifiedBy: testUserID,
Type: "test",
},
{
ID: "block3",
BoardID: boardID,
ParentID: "block1",
ModifiedBy: testUserID,
Type: "test",
},
{
ID: "block4",
BoardID: boardID,
ParentID: "block1",
ModifiedBy: testUserID,
Type: "test2",
},
{
ID: "block5",
BoardID: boardID,
ParentID: "block2",
ModifiedBy: testUserID,
Type: "test",
},
}
InsertBlocks(t, store, blocksToInsert, "user-id-1")
defer DeleteBlocks(t, store, blocksToInsert, "test")
t.Run("not existing parent", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithParentAndType(boardID, "not-exists", "test")
require.NoError(t, err)
require.Len(t, blocks, 0)
})
t.Run("not existing type", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithParentAndType(boardID, "block1", "not-existing")
require.NoError(t, err)
require.Len(t, blocks, 0)
})
t.Run("valid parent and type", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithParentAndType(boardID, "block1", "test")
require.NoError(t, err)
require.Len(t, blocks, 2)
})
t.Run("not existing parent", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithParent(boardID, "not-exists")
require.NoError(t, err)
require.Len(t, blocks, 0)
})
t.Run("valid parent", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithParent(boardID, "block1")
require.NoError(t, err)
require.Len(t, blocks, 3)
})
t.Run("not existing type", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithType(boardID, "not-exists")
require.NoError(t, err)
require.Len(t, blocks, 0)
})
t.Run("valid type", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithType(boardID, "test")
require.NoError(t, err)
require.Len(t, blocks, 4)
})
t.Run("not existing board", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithBoardID("not-exists")
require.NoError(t, err)
require.Len(t, blocks, 0)
})
t.Run("all blocks of the a board", func(t *testing.T) {
time.Sleep(1 * time.Millisecond)
blocks, err = store.GetBlocksWithBoardID(boardID)
require.NoError(t, err)
require.Len(t, blocks, 5)
})
}
func testGetBlock(t *testing.T, store store.Store) {
t.Run("get a block", func(t *testing.T) {
block := model.Block{
ID: "block-id-10",
BoardID: "board-id-1",
ModifiedBy: "user-id-1",
}
err := store.InsertBlock(&block, "user-id-1")
require.NoError(t, err)
fetchedBlock, err := store.GetBlock("block-id-10")
require.NoError(t, err)
require.NotNil(t, fetchedBlock)
require.Equal(t, "block-id-10", fetchedBlock.ID)
require.Equal(t, "board-id-1", fetchedBlock.BoardID)
require.Equal(t, "user-id-1", fetchedBlock.CreatedBy)
require.Equal(t, "user-id-1", fetchedBlock.ModifiedBy)
assert.WithinDurationf(t, time.Now(), utils.GetTimeForMillis(fetchedBlock.CreateAt), 1*time.Second, "create time should be current time")
assert.WithinDurationf(t, time.Now(), utils.GetTimeForMillis(fetchedBlock.UpdateAt), 1*time.Second, "update time should be current time")
})
t.Run("get a non-existing block", func(t *testing.T) {
fetchedBlock, err := store.GetBlock("non-existing-id")
require.NoError(t, err)
require.Nil(t, fetchedBlock)
})
}
func testDuplicateBlock(t *testing.T, store store.Store) {
InsertBlocks(t, store, subtreeSampleBlocks, "user-id-1")
time.Sleep(1 * time.Millisecond)
defer DeleteBlocks(t, store, subtreeSampleBlocks, "test")
t.Run("duplicate existing block as no template", func(t *testing.T) {
blocks, err := store.DuplicateBlock(testBoardID, "child1", testUserID, false)
require.NoError(t, err)
require.Len(t, blocks, 3)
require.Equal(t, false, blocks[0].Fields["isTemplate"])
})
t.Run("duplicate existing block as template", func(t *testing.T) {
blocks, err := store.DuplicateBlock(testBoardID, "child1", testUserID, true)
require.NoError(t, err)
require.Len(t, blocks, 3)
require.Equal(t, true, blocks[0].Fields["isTemplate"])
})
t.Run("duplicate not existing block", func(t *testing.T) {
blocks, err := store.DuplicateBlock(testBoardID, "not-existing-id", testUserID, false)
require.Error(t, err)
require.Nil(t, blocks)
})
t.Run("duplicate not existing board", func(t *testing.T) {
blocks, err := store.DuplicateBlock("not-existing-board", "not-existing-id", testUserID, false)
require.Error(t, err)
require.Nil(t, blocks)
})
t.Run("not matching board/block", func(t *testing.T) {
blocks, err := store.DuplicateBlock("other-id", "child1", testUserID, false)
require.Error(t, err)
require.Nil(t, blocks)
})
}
func testGetBlockMetadata(t *testing.T, store store.Store) {
boardID := testBoardID
blocks, err := store.GetBlocksForBoard(boardID)
require.NoError(t, err)
blocksToInsert := []model.Block{
{
ID: "block1",
BoardID: boardID,
ParentID: "",
ModifiedBy: testUserID,
Type: "test",
},
{
ID: "block2",
BoardID: boardID,
ParentID: "block1",
ModifiedBy: testUserID,
Type: "test",
},
{
ID: "block3",
BoardID: boardID,
ParentID: "block1",
ModifiedBy: testUserID,
Type: "test",
},
{
ID: "block4",
BoardID: boardID,
ParentID: "block1",
ModifiedBy: testUserID,
Type: "test2",
},
{
ID: "block5",
BoardID: boardID,
ParentID: "block2",
ModifiedBy: testUserID,
Type: "test",
},
}
for _, v := range blocksToInsert {
time.Sleep(20 * time.Millisecond)
subBlocks := []model.Block{v}
InsertBlocks(t, store, subBlocks, testUserID)
}
defer DeleteBlocks(t, store, blocksToInsert, "test")
t.Run("get full block history", func(t *testing.T) {
opts := model.QueryBlockHistoryOptions{
Descending: false,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 5)
expectedBlock := blocksToInsert[0]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get full block history descending", func(t *testing.T) {
opts := model.QueryBlockHistoryOptions{
Descending: true,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 5)
expectedBlock := blocksToInsert[len(blocksToInsert)-1]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get limited block history", func(t *testing.T) {
opts := model.QueryBlockHistoryOptions{
Limit: 3,
Descending: false,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 3)
})
t.Run("get first block history", func(t *testing.T) {
opts := model.QueryBlockHistoryOptions{
Limit: 1,
Descending: false,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 1)
expectedBlock := blocksToInsert[0]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get last block history", func(t *testing.T) {
opts := model.QueryBlockHistoryOptions{
Limit: 1,
Descending: true,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 1)
expectedBlock := blocksToInsert[len(blocksToInsert)-1]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get block history after updateAt", func(t *testing.T) {
rBlocks, err2 := store.GetBlocksWithType(boardID, "test")
require.NoError(t, err2)
require.NotZero(t, rBlocks[2].UpdateAt)
opts := model.QueryBlockHistoryOptions{
AfterUpdateAt: rBlocks[2].UpdateAt,
Descending: false,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 2)
expectedBlock := blocksToInsert[3]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get block history before updateAt", func(t *testing.T) {
rBlocks, err2 := store.GetBlocksWithType(boardID, "test")
require.NoError(t, err2)
require.NotZero(t, rBlocks[2].UpdateAt)
opts := model.QueryBlockHistoryOptions{
BeforeUpdateAt: rBlocks[2].UpdateAt,
Descending: true,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 2)
expectedBlock := blocksToInsert[1]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get full block history after delete", func(t *testing.T) {
time.Sleep(20 * time.Millisecond)
err = store.DeleteBlock(blocksToInsert[0].ID, testUserID)
require.NoError(t, err)
opts := model.QueryBlockHistoryOptions{
Descending: true,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 6)
expectedBlock := blocksToInsert[0]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
t.Run("get full block history after undelete", func(t *testing.T) {
time.Sleep(20 * time.Millisecond)
err = store.UndeleteBlock(blocksToInsert[0].ID, testUserID)
require.NoError(t, err)
opts := model.QueryBlockHistoryOptions{
Descending: true,
}
blocks, err = store.GetBlockHistoryDescendants(boardID, opts)
require.NoError(t, err)
require.Len(t, blocks, 7)
expectedBlock := blocksToInsert[0]
block := blocks[0]
require.Equal(t, expectedBlock.ID, block.ID)
})
}