mirror of
https://github.com/mattermost/focalboard.git
synced 2024-12-24 13:43:12 +02:00
f00b5c9e61
* Add boilerplate functions and handlers for boards insights * Fix function signatures to add 'duration' parameter, fix where clauses in db queries * Fix where clause to include boards of which userId in parameter is a member * Modify queries to work with sqlite, postgres, mysql * Integration tests, and results of make generate * Lint Fixes * Add icons to board insights * Lint fixes * Format insights queries without squirrel to fix parameterization issues * Add tests for sqlstore utility functions * Improve team insights tests by creating 2 boards * Refactor endpoints/app to adhere to developments in 7.0 release * Refactor queries to use squirrel * Lint fixes * Fix client, integration tests * Remove old integration tests * Add storetests, refactor functions to handle authorized board_ids * Make queries compatible with mysql, sqlite * Add app tests * Fix lint errors * Revert makefile changes, fix docstring in api * Lint fixes and doc correction suggested by @wiggin77 * Fix mock store call count error * adding client code * Make the following changes - use serviceAPI to get user.Timezone - rename licenseAndGuestUserCheck to insightPermissionGate, and handle returned error better - validate page, perPage parameters aren't < 0 * Lint fix Co-authored-by: Mattermod <mattermod@users.noreply.github.com> Co-authored-by: Benjamin Cooke <benjamincooke@Benjamins-MacBook-Pro.local>
90 lines
3.2 KiB
Go
90 lines
3.2 KiB
Go
package app
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mattermost/focalboard/server/model"
|
|
mmModel "github.com/mattermost/mattermost-server/v6/model"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var mockInsightsBoards = []*model.Board{
|
|
{
|
|
ID: "mock-user-workspace-id",
|
|
Title: "MockUserWorkspace",
|
|
},
|
|
}
|
|
|
|
var mockTeamInsights = []*model.BoardInsight{
|
|
{
|
|
BoardID: "board-id-1",
|
|
},
|
|
{
|
|
BoardID: "board-id-2",
|
|
},
|
|
}
|
|
|
|
var mockTeamInsightsList = &model.BoardInsightsList{
|
|
InsightsListData: mmModel.InsightsListData{HasNext: false},
|
|
Items: mockTeamInsights,
|
|
}
|
|
|
|
type insightError struct {
|
|
msg string
|
|
}
|
|
|
|
func (ie insightError) Error() string {
|
|
return ie.msg
|
|
}
|
|
|
|
func TestGetTeamAndUserBoardsInsights(t *testing.T) {
|
|
th, tearDown := SetupTestHelper(t)
|
|
defer tearDown()
|
|
|
|
t.Run("success query", func(t *testing.T) {
|
|
fakeLicense := &mmModel.License{Features: &mmModel.Features{}, SkuShortName: mmModel.LicenseShortSkuEnterprise}
|
|
th.Store.EXPECT().GetLicense().Return(fakeLicense).AnyTimes()
|
|
fakeUser := &model.User{
|
|
ID: "user-id",
|
|
IsGuest: false,
|
|
}
|
|
th.Store.EXPECT().GetUserByID("user-id").Return(fakeUser, nil).AnyTimes()
|
|
th.Store.EXPECT().GetBoardsForUserAndTeam("user-id", "team-id").Return(mockInsightsBoards, nil).AnyTimes()
|
|
th.Store.EXPECT().
|
|
GetTeamBoardsInsights("team-id", "user-id", int64(0), 0, 10, []string{"mock-user-workspace-id"}).
|
|
Return(mockTeamInsightsList, nil)
|
|
results, err := th.App.GetTeamBoardsInsights("user-id", "team-id", &mmModel.InsightsOpts{StartUnixMilli: 0, Page: 0, PerPage: 10})
|
|
require.NoError(t, err)
|
|
require.Len(t, results.Items, 2)
|
|
th.Store.EXPECT().
|
|
GetUserBoardsInsights("team-id", "user-id", int64(0), 0, 10, []string{"mock-user-workspace-id"}).
|
|
Return(mockTeamInsightsList, nil)
|
|
results, err = th.App.GetUserBoardsInsights("user-id", "team-id", &mmModel.InsightsOpts{StartUnixMilli: 0, Page: 0, PerPage: 10})
|
|
require.NoError(t, err)
|
|
require.Len(t, results.Items, 2)
|
|
})
|
|
|
|
t.Run("fail query", func(t *testing.T) {
|
|
fakeLicense := &mmModel.License{Features: &mmModel.Features{}, SkuShortName: mmModel.LicenseShortSkuEnterprise}
|
|
th.Store.EXPECT().GetLicense().Return(fakeLicense).AnyTimes()
|
|
fakeUser := &model.User{
|
|
ID: "user-id",
|
|
IsGuest: false,
|
|
}
|
|
th.Store.EXPECT().GetUserByID("user-id").Return(fakeUser, nil).AnyTimes()
|
|
th.Store.EXPECT().GetBoardsForUserAndTeam("user-id", "team-id").Return(mockInsightsBoards, nil).AnyTimes()
|
|
th.Store.EXPECT().
|
|
GetTeamBoardsInsights("team-id", "user-id", int64(0), 0, 10, []string{"mock-user-workspace-id"}).
|
|
Return(nil, insightError{"board-insight-error"})
|
|
_, err := th.App.GetTeamBoardsInsights("user-id", "team-id", &mmModel.InsightsOpts{StartUnixMilli: 0, Page: 0, PerPage: 10})
|
|
require.Error(t, err)
|
|
require.ErrorIs(t, err, insightError{"board-insight-error"})
|
|
th.Store.EXPECT().
|
|
GetUserBoardsInsights("team-id", "user-id", int64(0), 0, 10, []string{"mock-user-workspace-id"}).
|
|
Return(nil, insightError{"board-insight-error"})
|
|
_, err = th.App.GetUserBoardsInsights("user-id", "team-id", &mmModel.InsightsOpts{StartUnixMilli: 0, Page: 0, PerPage: 10})
|
|
require.Error(t, err)
|
|
require.ErrorIs(t, err, insightError{"board-insight-error"})
|
|
})
|
|
}
|