mirror of
https://github.com/mattermost/focalboard.git
synced 2024-12-03 08:45:40 +02:00
aa540e73ce
* wip
* Added data migration for populating categories
* wip
* Added data migration for populating categories
* Store WIP
* migration WIP
* category CRUD APIs complete
* category block API WIP
* block category update API done
* Fetcehed data into store
* Started displayting sidebar data
* sidebar WIP
* Dashboard - basic changes
* Sidebar dashboard btn and board switcher UI only
* Sidebar dashboard btn and board switcher UI only
* create category dialog WIP
* Create category webapp side done
* Integrated move card to other category
* board to block
* Disabled dashboard route for now as we'll implement it in phase 2
* WIP
* Added logic to open last board/view on per team level
* Add workspace to teams and boards migrations (#1986)
* Add workspace to teams and boards migrations
* Update json annotations on board models
* boards search dialog WIP
* Seach dialog WIP
* Implemented opening boiard from search results
* Boards switcher styliung
* Handled update category WS event
* Template support
* personal server support and styling fixes
* test fix WIP
* Fixed a bug causing boards to not be moved correctly beteen categories
* Fixed webapp tests
* fix
* Store changes (#2011)
* Permissions phase 1 - Websocket updates (#2014)
* Store changes
* Websockets changes
* Permissions phase 1 - Permissions service (#2015)
* Store changes
* Websockets changes
* Permissions service
* Api and app updates (#2016)
* Store changes
* Websockets changes
* Permissions service
* New API and App changes
* Delete and Patch boards and blocks endpoints
* Used correct variable
* Webapp changes WIP
* Open correct team URL
* Fixed get block API
* Used React context for workspace users
* WIP
* On load navigation sorted out
* WIP
* Nav fix
* categories WS broadcast
* Used real search API
* Fixed unfurl ppreview
* set active team in sidebar
* IMplemented navigation on changing team in sidebar
* Misc fixes
* close rows inside transaction (#2045)
* update syntax for mysql (#2044)
* Upadted mutator for new patchBlock API
* Updated patchBlock API to use new URL
* Listeining to correct event in plugin mode
* Implemented WS messages for category operations:
* Fix duplicated build tags on Makefile
* Sidebar enhancements
* Add missing prefix to SQLite migration and fix flaky tests
* Sidebar boards menu enhancement
* Fix board page interactions (#2144)
* Fix patch board card properties error
* Fix board interactions
* Fix insert blocks interactions
* Fix app tests (#2104)
* Add json1 tag to vscode launch (#2157)
* Fix add, delete and update boards and add board patch generation (#2146)
* Fix update boards and add board patch generation
* Make add board and add template work, as well as deleting a board
* Update the state on board deletion
* Delete unused variable
* Fix bad parenthesis
* Fix board creation inside plugin, options were coming null due websocket message serialization
* update property type mutators to use boards API (#2168)
* Add permissions modal (#2196)
* Initial integration
* Permissions modal, websocket updates and API tests implemented
* Avoid updating/removing user if there is only one admin left
* Fix duplicates on board search
* Adds integration test
* Addressing PR review comments
Co-authored-by: Jesús Espino <jespinog@gmail.com>
* Merge
* I'm able to compile now
* Some fixes around tests execution
* Fixing migrations
* Fixing migrations order
* WIP
* Fixing some other compilation problems on tests
* Some typescript tests fixed
* Fixing javascript tests
* Fixing compilation
* Fixing some problems to create boards
* Load the templates on initial load
* Improvements over initial team templates import
* Adding new fields in the database
* Working on adding duplicate board api
* Removing RootID concept entirely
* Improving a bit the subscriptions
* Fixing store tests for notificationHints
* Fixing more tests
* fixing tests
* Fixing tests
* Fixing tests
* Fixing some small bugs related to templates
* Fixing registration link generation/regeneration
* Fixing cypress tests
* Adding store tests for duplicateBoard and duplicateBlock
* Addressing some TODO comments
* Making the export api simpler
* Add redirect component for old workspace urls
* Removing Dashboard code
* Delete only the built-in templates on update
* fixing tests
* Adding users autocompletion
* Updating snapshots
* Fixing bad merge
* fix panic when creating new card in notifysubscriptions (#2352)
* fix lint errors (#2353)
* fix lint errors
* fix panic when creating new card in notifysubscriptions (#2352)
* fix lint errors
* fix unit test
* Revert "fix unit test"
This reverts commit 0ad78aed65
.
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
* fix sql syntax error for SearchUsersByTeam (#2357)
* Fix mentions delivery (#2358)
* fix sql syntax error for SearchUsersByTeam
* fix mentions delivery
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* update api for octoClient calls, pass correct variables to mutator (#2359)
* Fixing tests after merge
* Fix sidebar context menu UI issue (#2399)
* Fix notification diff for text blocks (#2386)
* fix notification diff for text blocks; fix various linter errors.
* fix URLs to cards
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Permissions branch: Fix card links (#2391)
* fix notification diff for text blocks; fix various linter errors.
* fix URLs to cards
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixing sqlite tests
* Fixing server tests
* Update migrations to create global templates. (#2397)
* fix duplicate templates
* revert migrate.go
* update UI for empty templates
* implement updating built-in templates as global (teamId = 0)
* handle error if board not found
* update unit test
* fix more tests
* Update blocks_test.go
Fix merge issue
* fix migration sql error (#2414)
* Fixing frontend tests
* Set target team ID when using a global template (#2419)
* Fix some server tests
* Fixing onboarding creation
* Permissions branch: Fix unit tests and CI errors (part 1) (#2425)
* Fixing some small memory leaks (#2400)
* Fixing some small memory leaks
* fixing tests
* passing the tags to all test targets
* Increasing the timeout of the tests
* Fix some type checkings
* Permissions branch: Fixes all the linter errors (#2429)
* fix linter errors
* Reestructuring the router and splitting in more subcomponents (#2403)
* Reestructuring the router and splitting in more subcomponents
* Removing console.log calls
* Removing unneeded selector
* Addressing PR comment
* Fix redirection to one team when you load directly the boards home path
* Using properly the lastTeamID to redirect the user if needed
* don't allow last admin change/deleted (#2416)
* don't allow last admin change/deleted
* update for i18-extract
* fixed en.json
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
* Splitting BoardPage component into simpler/smaller components (#2435)
* Splitting BoardPage component into simpler/smaller components
* Removing unneeded import
* Replace go migrate with morph permissions (#2424)
* merge origin/replace-go-migrate-with-morph
* run go mod tidy on mattermost-plugin and increase test timeout
* fix merge issue temprorarily
* remove some debug changes
* fixing the linter
* Allow always team 0 (global) templates fetch (#2472)
* Fix problem with viewId 0 in the URL (#2473)
* Migrate from binddata to goembed (#2471)
* Adding join logic to the board switcher (#2434)
* Adding join logic to the board switcher
* Using already existing client function and removing the joinBoard one
* Adding support for autojoin based on url
* Fixing frontend tests
* fix webapp compile error, missing enableSharedBoards (#2501)
* Fixing duplication on postgres
* Adding back views to the sidebar (#2494)
* Fix #2507. Update Swagger comments (#2508)
* Fix the flash of the template selector on board/team switch (#2490)
* Fix the flash of the template selector on board/team switch
* More fixes specially around error handling
* Fixing the bot badge (#2487)
* simplifying a bit the team store sync between channels and focalboard (#2481)
* Fix menu tests (#2528)
* fix failing menu tests
* fix lint error
* Added keyboard shortcut for boards switcher (#2407)
* Added keyboard shortcut for boards switcher
* Fixed a type error
* Added some inline comments
* Fixed lint
* Fixed bug with scroll jumping when the card is opened: (#2477)
- avoid remounting of `ScrollingComponent` for each render of `Kanban` component
- property `autoFocus` set to false for `CalculationOptions` because it triggers `blur` even for the button in Jest tests and closes the menu
- snapshots for tests with `CalculationOptions` updated
* Adding the frontend support for permissions and applying it to a big part of the interface. (#2536)
* Initial work on permissions gates
* Applying permissions gates in more places
* Adding more checks to the interface
* Adding more permissions gates and keeping the store up to date
* fixing some tests
* Fixing some more tests
* Fixing another test
* Fixing all tests and adding some more
* Adding no-permission snapshot tests
* Addressing PR review comments
* Fixing invert behavior
* Permissions branch: No sqlstore calls after app shutdown (#2530)
* fix webapp compile error, missing enableSharedBoards
* refactor app init wip
* - ensure all block change notifications are finished before shutting down app
- fix unit tests for mysql (insert_at only has 1 second resolution!)
* adjust logging
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixed migrations to allow upgrading from previous version (#2535)
* Added mechanism to check if schema migration is needed
* WIP
* WIP
* WIP
* WIP
* Fixed migration
* Fixed for SQLite
* minor cleaniup
* Deleted old schema migration table after running migrations
* Removed a debug log
* Fixed a bug where the code always tried to delete a table which may or may not exist
* Show properly the user avatar in the ShareBoard component (#2542)
* Fixing the last CI problems from the permissions-branch (#2541)
* Fix history ordering
* Giving some times to avoid possible race conditions
* Empty
* Reverting accidental change in the config.json
* Optimizing table view (#2540)
* Optimizing table view
* Reducing the amount of rendering for tables
* Some other performance improvements
* Improve the activeView updates
* Some extra simplifications
* Another small improvement
* Fixing tests
* Fixing linter errors
* Reducing a bit the amount of dependency with big objects in the store
* Small simplification
* Removing Commenter role from the user role selector (#2561)
* Shareboard cleanup (#2550)
* Initial work on permissions gates
* Applying permissions gates in more places
* Adding more checks to the interface
* Adding more permissions gates and keeping the store up to date
* fixing some tests
* Fixing some more tests
* Fixing another test
* Fixing all tests and adding some more
* Adding no-permission snapshot tests
* Addressing PR review comments
* cleanup some shareboard settings
* remove unused property, fix for user items being displayed for non admin
* revert change, allow users to show
Co-authored-by: Jesús Espino <jespinog@gmail.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixing comments and cards with the new optimizations in the store (#2560)
* Fixing property creation (#2563)
* Fix user selection in table view (#2565)
* Fixing focus new row in table view (#2567)
* Permissions branch: Fix sqlite table lock (CI) (#2568)
* fix sqlite table lock
* remove test db on teardown
* revert .gitignore
* fix goimport on migration code
* fix typo
* more linter fixes
* clean up tmp db for sqlstore tests
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
* Fixing snapshots
* Migrating center panel to functional component (#2562)
* Migrating center panel to functional component
* Fixing some tests
* Fixing another test
* Fixing linter errors
* Fixing types errors
* Fixing linter error
* Fixing cypress tests
* Fixing the last cypress test
* Simpliying a bit the code
* Making property insertion more robust
* Updating checkbox test
Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Chen-I Lim <46905241+chenilim@users.noreply.github.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com>
Co-authored-by: kamre <eremchenko@gmail.com>
217 lines
6.0 KiB
Go
217 lines
6.0 KiB
Go
package app
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"path"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/krolaw/zipstream"
|
|
|
|
"github.com/mattermost/focalboard/server/model"
|
|
"github.com/mattermost/focalboard/server/utils"
|
|
|
|
"github.com/mattermost/mattermost-server/v6/shared/mlog"
|
|
)
|
|
|
|
const (
|
|
archiveVersion = 2
|
|
legacyFileBegin = "{\"version\":1"
|
|
)
|
|
|
|
// ImportArchive imports an archive containing zero or more boards, plus all
|
|
// associated content, including cards, content blocks, views, and images.
|
|
//
|
|
// Archives are ZIP files containing a `version.json` file and zero or more
|
|
// directories, each containing a `board.jsonl` and zero or more image files.
|
|
func (a *App) ImportArchive(r io.Reader, opt model.ImportArchiveOptions) error {
|
|
// peek at the first bytes to see if this is a legacy archive format
|
|
br := bufio.NewReader(r)
|
|
peek, err := br.Peek(len(legacyFileBegin))
|
|
if err == nil && string(peek) == legacyFileBegin {
|
|
a.logger.Debug("importing legacy archive")
|
|
_, errImport := a.ImportBoardJSONL(br, opt)
|
|
return errImport
|
|
}
|
|
|
|
a.logger.Debug("importing archive")
|
|
zr := zipstream.NewReader(br)
|
|
|
|
boardMap := make(map[string]string) // maps old board ids to new
|
|
|
|
for {
|
|
hdr, err := zr.Next()
|
|
if err != nil {
|
|
if errors.Is(err, io.EOF) {
|
|
a.logger.Debug("import archive - done", mlog.Int("boards_imported", len(boardMap)))
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
|
|
dir, filename := path.Split(hdr.Name)
|
|
dir = path.Clean(dir)
|
|
|
|
switch filename {
|
|
case "version.json":
|
|
ver, errVer := parseVersionFile(zr)
|
|
if errVer != nil {
|
|
return errVer
|
|
}
|
|
if ver != archiveVersion {
|
|
return model.NewErrUnsupportedArchiveVersion(ver, archiveVersion)
|
|
}
|
|
case "board.jsonl":
|
|
boardID, err := a.ImportBoardJSONL(zr, opt)
|
|
if err != nil {
|
|
return fmt.Errorf("cannot import board %s: %w", dir, err)
|
|
}
|
|
boardMap[dir] = boardID
|
|
default:
|
|
// import file/image; dir is the old board id
|
|
boardID, ok := boardMap[dir]
|
|
if !ok {
|
|
a.logger.Error("skipping orphan image in archive",
|
|
mlog.String("dir", dir),
|
|
mlog.String("filename", filename),
|
|
)
|
|
continue
|
|
}
|
|
// save file with original filename so it matches name in image block.
|
|
filePath := filepath.Join(opt.TeamID, boardID, filename)
|
|
_, err := a.filesBackend.WriteFile(zr, filePath)
|
|
if err != nil {
|
|
return fmt.Errorf("cannot import file %s for board %s: %w", filename, dir, err)
|
|
}
|
|
}
|
|
|
|
a.logger.Trace("import archive file",
|
|
mlog.String("dir", dir),
|
|
mlog.String("filename", filename),
|
|
)
|
|
}
|
|
}
|
|
|
|
// ImportBoardJSONL imports a JSONL file containing blocks for one board. The resulting
|
|
// board id is returned.
|
|
func (a *App) ImportBoardJSONL(r io.Reader, opt model.ImportArchiveOptions) (string, error) {
|
|
// TODO: Stream this once `model.GenerateBlockIDs` can take a stream of blocks.
|
|
// We don't want to load the whole file in memory, even though it's a single board.
|
|
boardsAndBlocks := &model.BoardsAndBlocks{
|
|
Blocks: make([]model.Block, 0, 10),
|
|
Boards: make([]*model.Board, 0, 10),
|
|
}
|
|
lineReader := bufio.NewReader(r)
|
|
|
|
userID := opt.ModifiedBy
|
|
if userID == model.SingleUser {
|
|
userID = ""
|
|
}
|
|
now := utils.GetMillis()
|
|
|
|
lineNum := 1
|
|
for {
|
|
line, errRead := readLine(lineReader)
|
|
if len(line) != 0 {
|
|
var skip bool
|
|
if lineNum == 1 {
|
|
// first line might be a header tag (old archive format)
|
|
if strings.HasPrefix(string(line), legacyFileBegin) {
|
|
skip = true
|
|
}
|
|
}
|
|
|
|
if !skip {
|
|
var archiveLine model.ArchiveLine
|
|
if err := json.Unmarshal(line, &archiveLine); err != nil {
|
|
return "", fmt.Errorf("error parsing archive line %d: %w", lineNum, err)
|
|
}
|
|
switch archiveLine.Type {
|
|
case "block":
|
|
var block model.Block
|
|
if err2 := json.Unmarshal(archiveLine.Data, &block); err2 != nil {
|
|
return "", fmt.Errorf("invalid block in archive line %d: %w", lineNum, err2)
|
|
}
|
|
block.ModifiedBy = userID
|
|
block.UpdateAt = now
|
|
boardsAndBlocks.Blocks = append(boardsAndBlocks.Blocks, block)
|
|
case "board":
|
|
var board model.Board
|
|
if err2 := json.Unmarshal(archiveLine.Data, &board); err2 != nil {
|
|
return "", fmt.Errorf("invalid block in archive line %d: %w", lineNum, err2)
|
|
}
|
|
board.ModifiedBy = userID
|
|
board.UpdateAt = now
|
|
board.TeamID = opt.TeamID
|
|
boardsAndBlocks.Boards = append(boardsAndBlocks.Boards, &board)
|
|
default:
|
|
return "", model.NewErrUnsupportedArchiveLineType(lineNum, archiveLine.Type)
|
|
}
|
|
}
|
|
}
|
|
|
|
if errRead != nil {
|
|
if errors.Is(errRead, io.EOF) {
|
|
break
|
|
}
|
|
return "", fmt.Errorf("error reading archive line %d: %w", lineNum, errRead)
|
|
}
|
|
lineNum++
|
|
}
|
|
|
|
modInfoCache := make(map[string]interface{})
|
|
modBoards := make([]*model.Board, 0, len(boardsAndBlocks.Boards))
|
|
for _, board := range boardsAndBlocks.Boards {
|
|
b := *board
|
|
if opt.BoardModifier != nil && !opt.BoardModifier(&b, modInfoCache) {
|
|
a.logger.Debug("skipping insert block per block modifier",
|
|
mlog.String("blockID", board.ID),
|
|
)
|
|
continue
|
|
}
|
|
modBoards = append(modBoards, &b)
|
|
}
|
|
boardsAndBlocks.Boards = modBoards
|
|
|
|
var err error
|
|
boardsAndBlocks, err = model.GenerateBoardsAndBlocksIDs(boardsAndBlocks, a.logger)
|
|
if err != nil {
|
|
return "", fmt.Errorf("error inserting archive blocks: %w", err)
|
|
}
|
|
|
|
boardsAndBlocks, err = a.CreateBoardsAndBlocks(boardsAndBlocks, opt.ModifiedBy, false)
|
|
if err != nil {
|
|
return "", fmt.Errorf("error inserting archive blocks: %w", err)
|
|
}
|
|
|
|
// find new board id
|
|
for _, board := range boardsAndBlocks.Boards {
|
|
return board.ID, nil
|
|
}
|
|
return "", fmt.Errorf("missing board in archive: %w", model.ErrInvalidBoardBlock)
|
|
}
|
|
|
|
func parseVersionFile(r io.Reader) (int, error) {
|
|
file, err := io.ReadAll(r)
|
|
if err != nil {
|
|
return 0, fmt.Errorf("cannot read version.json: %w", err)
|
|
}
|
|
|
|
var header model.ArchiveHeader
|
|
if err := json.Unmarshal(file, &header); err != nil {
|
|
return 0, fmt.Errorf("cannot parse version.json: %w", err)
|
|
}
|
|
return header.Version, nil
|
|
}
|
|
|
|
func readLine(r *bufio.Reader) ([]byte, error) {
|
|
line, err := r.ReadBytes('\n')
|
|
line = bytes.TrimSpace(line)
|
|
return line, err
|
|
}
|