From 0a9b632e48f85653029eea915429d5277fd96941 Mon Sep 17 00:00:00 2001
From: Mert <101130780+mertalev@users.noreply.github.com>
Date: Fri, 15 Sep 2023 20:52:45 -0400
Subject: [PATCH] fix(server): use libopus for transcoding (#4102)

* updated audio codec enum

* added migration

* updated api

* fixed enum

* formatting

* simplified migration
---
 cli/src/api/open-api/api.ts                   |   2 +-
 mobile/openapi/lib/model/audio_codec.dart     | Bin 2625 -> 2640 bytes
 server/immich-openapi-specs.json              |   2 +-
 .../infra/entities/system-config.entity.ts    |   2 +-
 .../1694758412194-UpdateOpusCodecToLibopus.ts |  21 ++++++++++++++++++
 web/src/api/open-api/api.ts                   |   2 +-
 .../settings/ffmpeg/ffmpeg-settings.svelte    |   2 +-
 7 files changed, 26 insertions(+), 5 deletions(-)
 create mode 100644 server/src/infra/migrations/1694758412194-UpdateOpusCodecToLibopus.ts

diff --git a/cli/src/api/open-api/api.ts b/cli/src/api/open-api/api.ts
index 0d8d4ca543..f4c0315426 100644
--- a/cli/src/api/open-api/api.ts
+++ b/cli/src/api/open-api/api.ts
@@ -752,7 +752,7 @@ export type AssetTypeEnum = typeof AssetTypeEnum[keyof typeof AssetTypeEnum];
 export const AudioCodec = {
     Mp3: 'mp3',
     Aac: 'aac',
-    Opus: 'opus'
+    Libopus: 'libopus'
 } as const;
 
 export type AudioCodec = typeof AudioCodec[keyof typeof AudioCodec];
diff --git a/mobile/openapi/lib/model/audio_codec.dart b/mobile/openapi/lib/model/audio_codec.dart
index f5b50006a690eec22c2afcb9a1026c1a0759846b..25c8332b0cc3d4510adb107605f97279ec3e79a9 100644
GIT binary patch
delta 70
zcmX>oazSK63zJMvW>S7ZX|aN>f@5h)X1;TNN@}uRyhf2aP-5~dre<a!y;+v|2P->N
P<>Uh#qF_NiPGLp>gr68i

delta 48
zcmca0a!_PL3zJxWL20pqt%74|N@l)ueoAVxUc5$;`s4*n&70Mjf3Qwg<docO%PGtV
E0Hw+g+yDRo

diff --git a/server/immich-openapi-specs.json b/server/immich-openapi-specs.json
index b7dadbceca..ba935c82f6 100644
--- a/server/immich-openapi-specs.json
+++ b/server/immich-openapi-specs.json
@@ -5318,7 +5318,7 @@
         "enum": [
           "mp3",
           "aac",
-          "opus"
+          "libopus"
         ],
         "type": "string"
       },
diff --git a/server/src/infra/entities/system-config.entity.ts b/server/src/infra/entities/system-config.entity.ts
index ebcdcac07d..bd94e4d0c6 100644
--- a/server/src/infra/entities/system-config.entity.ts
+++ b/server/src/infra/entities/system-config.entity.ts
@@ -99,7 +99,7 @@ export enum VideoCodec {
 export enum AudioCodec {
   MP3 = 'mp3',
   AAC = 'aac',
-  OPUS = 'opus',
+  LIBOPUS = 'libopus',
 }
 
 export enum TranscodeHWAccel {
diff --git a/server/src/infra/migrations/1694758412194-UpdateOpusCodecToLibopus.ts b/server/src/infra/migrations/1694758412194-UpdateOpusCodecToLibopus.ts
new file mode 100644
index 0000000000..715b46550a
--- /dev/null
+++ b/server/src/infra/migrations/1694758412194-UpdateOpusCodecToLibopus.ts
@@ -0,0 +1,21 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class UpdateOpusCodecToLibopus1694758412194 implements MigrationInterface {
+  name = 'UpdateOpusCodecToLibopus1694758412194'
+
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+                UPDATE system_config
+                SET value = '"libopus"'
+                WHERE key = 'ffmpeg.targetAudioCodec' AND value = '"opus"'
+            `);
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+                UPDATE system_config
+                SET value = '"opus"'
+                WHERE key = 'ffmpeg.targetAudioCodec' AND value = '"libopus"'
+            `);
+  }
+}
diff --git a/web/src/api/open-api/api.ts b/web/src/api/open-api/api.ts
index 0d8d4ca543..f4c0315426 100644
--- a/web/src/api/open-api/api.ts
+++ b/web/src/api/open-api/api.ts
@@ -752,7 +752,7 @@ export type AssetTypeEnum = typeof AssetTypeEnum[keyof typeof AssetTypeEnum];
 export const AudioCodec = {
     Mp3: 'mp3',
     Aac: 'aac',
-    Opus: 'opus'
+    Libopus: 'libopus'
 } as const;
 
 export type AudioCodec = typeof AudioCodec[keyof typeof AudioCodec];
diff --git a/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte b/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
index a75b1ab0bf..fa46181db5 100644
--- a/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
+++ b/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
@@ -145,7 +145,7 @@
             options={[
               { value: AudioCodec.Aac, text: 'aac' },
               { value: AudioCodec.Mp3, text: 'mp3' },
-              { value: AudioCodec.Opus, text: 'opus' },
+              { value: AudioCodec.Libopus, text: 'opus' },
             ]}
             name="acodec"
             isEdited={ffmpegConfig.targetAudioCodec !== savedConfig.targetAudioCodec}