self-hosted/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-04-23 13:09:00 +02:00
Code Issues Releases Activity

fix(mobile): app crash when there is no object detection result on search page (#725)

Browse Source 
* fix(mobile): app crash when there is no data for object detection

* Up version for release

* Up version for release
This commit is contained in:
Alex 2022-09-19 11:03:51 -05:00 committed by GitHub
parent 242f10952d
commit 10239161fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mobile/android/fastlane/Fastfile
View File

@ -30,8 +30,8 @@ platform :android do
task: 'bundle', task: 'bundle',
build_type: 'Release', build_type: 'Release',
properties: { properties: {
"android.injected.version.code" => 43, "android.injected.version.code" => 44,
"android.injected.version.name" => "1.29.1", "android.injected.version.name" => "1.29.4",
} }
) )
upload_to_play_store(skip_upload_apk: true, skip_upload_images: true, skip_upload_screenshots: true, aab: '../build/app/outputs/bundle/release/app-release.aab') upload_to_play_store(skip_upload_apk: true, skip_upload_images: true, skip_upload_screenshots: true, aab: '../build/app/outputs/bundle/release/app-release.aab')

1
mobile/android/fastlane/metadata/android/en-US/changelogs/44.txt Normal file
View File

@ -0,0 +1 @@
* Fixed app crashes when there is no object detection result.

6
mobile/android/fastlane/report.xml
View File

@ -5,17 +5,17 @@
<testcase classname="fastlane.lanes" name="0: default_platform" time="0.00023"> <testcase classname="fastlane.lanes" name="0: default_platform" time="0.00043">
</testcase> </testcase>
<testcase classname="fastlane.lanes" name="1: bundleRelease" time="58.722434"> <testcase classname="fastlane.lanes" name="1: bundleRelease" time="71.114285">
</testcase> </testcase>
<testcase classname="fastlane.lanes" name="2: upload_to_play_store" time="36.768014"> <testcase classname="fastlane.lanes" name="2: upload_to_play_store" time="36.949677">
</testcase> </testcase>

2
mobile/ios/fastlane/Fastfile
View File

@ -19,7 +19,7 @@ platform :ios do
desc "iOS Beta" desc "iOS Beta"
lane :beta do lane :beta do
increment_version_number( increment_version_number(
version_number: "1.29.1" version_number: "1.29.4"
) )
increment_build_number( increment_build_number(
build_number: latest_testflight_build_number + 1, build_number: latest_testflight_build_number + 1,

9
mobile/lib/modules/search/views/search_page.dart
View File

@ -99,9 +99,9 @@ class SearchPage extends HookConsumerWidget {
_buildThings() { _buildThings() {
return curatedObjects.when( return curatedObjects.when(
loading: () => const SizedBox( loading: () => SizedBox(
height: 200, height: imageSize,
child: Center(child: ImmichLoadingIndicator()), child: const Center(child: ImmichLoadingIndicator()),
), ),
error: (err, stack) => Text('Error: $err'), error: (err, stack) => Text('Error: $err'),
data: (objects) { data: (objects) {
@ -133,8 +133,7 @@ class SearchPage extends HookConsumerWidget {
), ),
) )
: SizedBox( : SizedBox(
// height: imageSize, height: imageSize,
width: imageSize,
child: ListView.builder( child: ListView.builder(
padding: const EdgeInsets.only(left: 16), padding: const EdgeInsets.only(left: 16),
scrollDirection: Axis.horizontal, scrollDirection: Axis.horizontal,

2
mobile/pubspec.yaml
View File

@ -2,7 +2,7 @@ name: immich_mobile
description: Immich - selfhosted backup media file on mobile phone description: Immich - selfhosted backup media file on mobile phone
publish_to: "none" publish_to: "none"
version: 1.29.1+43 version: 1.29.4+44
environment: environment:
sdk: ">=2.17.0 <3.0.0" sdk: ">=2.17.0 <3.0.0"

4
server/apps/immich/src/constants/server_version.constant.ts
View File

@ -11,6 +11,6 @@ export interface IServerVersion {
export const serverVersion: IServerVersion = { export const serverVersion: IServerVersion = {
major: 1, major: 1,
minor: 29, minor: 29,
patch: 2, patch: 4,
build: 43, build: 44,
}; };