From 585330b17951bcabf931541d9bf77fc65e153790 Mon Sep 17 00:00:00 2001
From: Daniele Ricci <daniele@casaricci.it>
Date: Tue, 29 Aug 2023 20:54:06 +0200
Subject: [PATCH] Refer to FFmpeg documentation (#3908)

* Fix unsecure URL

* Some links to FFmpeg docs
---
 .../settings/ffmpeg/ffmpeg-settings.svelte       | 16 ++++++++++++++++
 .../settings/oauth/oauth-settings.svelte         |  2 +-
 .../routes/admin/system-settings/+page.svelte    |  2 +-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte b/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
index e840cd04de..59be28f135 100644
--- a/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
+++ b/web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
@@ -16,6 +16,7 @@
   import SettingInputField, { SettingInputFieldType } from '../setting-input-field.svelte';
   import SettingSelect from '../setting-select.svelte';
   import SettingSwitch from '../setting-switch.svelte';
+  import HelpCircleOutline from 'svelte-material-icons/HelpCircleOutline.svelte';
   import { isEqual } from 'lodash-es';
   import { fade } from 'svelte/transition';
 
@@ -89,6 +90,21 @@
     <div in:fade={{ duration: 500 }}>
       <form autocomplete="off" on:submit|preventDefault>
         <div class="ml-4 mt-4 flex flex-col gap-4">
+          <p class="text-sm dark:text-immich-dark-fg">
+            <HelpCircleOutline class="inline" size="15" />
+            To learn more about the terminology used here, refer to FFmpeg documentation for
+            <a href="https://trac.ffmpeg.org/wiki/Encode/H.264" class="underline" target="_blank" rel="noreferrer"
+              >H.264 codec</a
+            >,
+            <a href="https://trac.ffmpeg.org/wiki/Encode/H.265" class="underline" target="_blank" rel="noreferrer"
+              >HEVC codec</a
+            >
+            and
+            <a href="https://trac.ffmpeg.org/wiki/Encode/VP9" class="underline" target="_blank" rel="noreferrer"
+              >VP9 codec</a
+            >.
+          </p>
+
           <SettingInputField
             inputType={SettingInputFieldType.NUMBER}
             {disabled}
diff --git a/web/src/lib/components/admin-page/settings/oauth/oauth-settings.svelte b/web/src/lib/components/admin-page/settings/oauth/oauth-settings.svelte
index 0c6c4a5629..9e16b44f2a 100644
--- a/web/src/lib/components/admin-page/settings/oauth/oauth-settings.svelte
+++ b/web/src/lib/components/admin-page/settings/oauth/oauth-settings.svelte
@@ -111,7 +111,7 @@
       <form autocomplete="off" on:submit|preventDefault class="mx-4 flex flex-col gap-4 py-4">
         <p class="text-sm dark:text-immich-dark-fg">
           For more details about this feature, refer to the <a
-            href="http://immich.app/docs/administration/oauth#mobile-redirect-uri"
+            href="https://immich.app/docs/administration/oauth#mobile-redirect-uri"
             class="underline"
             target="_blank"
             rel="noreferrer">docs</a
diff --git a/web/src/routes/admin/system-settings/+page.svelte b/web/src/routes/admin/system-settings/+page.svelte
index f53ac49211..e7626148eb 100644
--- a/web/src/routes/admin/system-settings/+page.svelte
+++ b/web/src/routes/admin/system-settings/+page.svelte
@@ -62,7 +62,7 @@
     </SettingAccordion>
 
     <SettingAccordion
-      title="FFmpeg Settings"
+      title="Video Transcoding Settings"
       subtitle="Manage the resolution and encoding information of the video files"
     >
       <FFmpegSettings disabled={$featureFlags.configFile} ffmpegConfig={configs.ffmpeg} />