From 5e9a7b17d9d67d5d70b10c55ed725e02c888090b Mon Sep 17 00:00:00 2001
From: Daniel Dietzler <36593685+danieldietzler@users.noreply.github.com>
Date: Fri, 21 Jun 2024 01:02:05 +0200
Subject: [PATCH] fix(server): allow library id to be null in metadata search
 (#10512)

* fix: allow library id to be null in metadata search

* chore: open api
---
 e2e/src/api/specs/search.e2e-spec.ts          |   7 +++++++
 .../lib/model/metadata_search_dto.dart        | Bin 30685 -> 30336 bytes
 .../openapi/lib/model/smart_search_dto.dart   | Bin 22952 -> 22603 bytes
 open-api/immich-openapi-specs.json            |   2 ++
 open-api/typescript-sdk/src/fetch-client.ts   |   4 ++--
 server/src/dtos/search.dto.ts                 |   4 ++--
 server/src/interfaces/search.interface.ts     |   2 +-
 server/src/utils/database.ts                  |   5 +++++
 server/src/validation.ts                      |   6 +++---
 9 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/e2e/src/api/specs/search.e2e-spec.ts b/e2e/src/api/specs/search.e2e-spec.ts
index f46c07e0b8..b49dac642e 100644
--- a/e2e/src/api/specs/search.e2e-spec.ts
+++ b/e2e/src/api/specs/search.e2e-spec.ts
@@ -339,6 +339,13 @@ describe('/search', () => {
         should: 'should search by model',
         deferred: () => ({ dto: { model: 'Canon EOS 7D' }, assets: [assetDenali] }),
       },
+      {
+        should: 'should allow searching the upload library (libraryId: null)',
+        deferred: () => ({
+          dto: { libraryId: null, size: 1 },
+          assets: [assetLast],
+        }),
+      },
     ];
 
     for (const { should, deferred } of searchTests) {
diff --git a/mobile/openapi/lib/model/metadata_search_dto.dart b/mobile/openapi/lib/model/metadata_search_dto.dart
index 322373ee5815dcbb6b6a3824f2dbeaf85c6a6f48..d77f2e7736c69d6bd0998654eef54c6be646ad33 100644
GIT binary patch
delta 13
Ucmccnp0VLA<Aw&=#dqZ*0WtdqfB*mh

delta 19
bcmZp8%Xs%a<Aw&=&20jyjGH@Te?$NPU6%;p

diff --git a/mobile/openapi/lib/model/smart_search_dto.dart b/mobile/openapi/lib/model/smart_search_dto.dart
index 0ff8cf6115b5d096429fb14be27b7552ec5c9c23..25927f42445c032c0a2222ec9944ff1481379233 100644
GIT binary patch
delta 14
WcmZ3nnep@n#toOnHXBG(I067Oga#%6

delta 23
fcmX@TfpNuV#toOnHoJ1iGEPol<=A{%tiTZfc+v?d

diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
index e884b4fc29..17f74d33b0 100644
--- a/open-api/immich-openapi-specs.json
+++ b/open-api/immich-openapi-specs.json
@@ -9026,6 +9026,7 @@
           },
           "libraryId": {
             "format": "uuid",
+            "nullable": true,
             "type": "string"
           },
           "make": {
@@ -10140,6 +10141,7 @@
           },
           "libraryId": {
             "format": "uuid",
+            "nullable": true,
             "type": "string"
           },
           "make": {
diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.ts
index 43e24e939b..143ec74e65 100644
--- a/open-api/typescript-sdk/src/fetch-client.ts
+++ b/open-api/typescript-sdk/src/fetch-client.ts
@@ -697,7 +697,7 @@ export type MetadataSearchDto = {
     isOffline?: boolean;
     isVisible?: boolean;
     lensModel?: string;
-    libraryId?: string;
+    libraryId?: string | null;
     make?: string;
     model?: string;
     order?: AssetOrder;
@@ -768,7 +768,7 @@ export type SmartSearchDto = {
     isOffline?: boolean;
     isVisible?: boolean;
     lensModel?: string;
-    libraryId?: string;
+    libraryId?: string | null;
     make?: string;
     model?: string;
     page?: number;
diff --git a/server/src/dtos/search.dto.ts b/server/src/dtos/search.dto.ts
index 5927aa86fc..59bb95b475 100644
--- a/server/src/dtos/search.dto.ts
+++ b/server/src/dtos/search.dto.ts
@@ -9,8 +9,8 @@ import { GeodataPlacesEntity } from 'src/entities/geodata-places.entity';
 import { Optional, ValidateBoolean, ValidateDate, ValidateUUID } from 'src/validation';
 
 class BaseSearchDto {
-  @ValidateUUID({ optional: true })
-  libraryId?: string;
+  @ValidateUUID({ optional: true, nullable: true })
+  libraryId?: string | null;
 
   @IsString()
   @IsNotEmpty()
diff --git a/server/src/interfaces/search.interface.ts b/server/src/interfaces/search.interface.ts
index d5382a04fa..c84b56c62e 100644
--- a/server/src/interfaces/search.interface.ts
+++ b/server/src/interfaces/search.interface.ts
@@ -45,7 +45,7 @@ export interface SearchAssetIDOptions {
 
 export interface SearchUserIdOptions {
   deviceId?: string;
-  libraryId?: string;
+  libraryId?: string | null;
   userIds?: string[];
 }
 
diff --git a/server/src/utils/database.ts b/server/src/utils/database.ts
index 65456e8192..944978bddd 100644
--- a/server/src/utils/database.ts
+++ b/server/src/utils/database.ts
@@ -52,6 +52,11 @@ export function searchAssetBuilder(
   }
 
   const id = _.pick(options, ['checksum', 'deviceAssetId', 'deviceId', 'id', 'libraryId']);
+
+  if (id.libraryId === null) {
+    id.libraryId = IsNull() as unknown as string;
+  }
+
   builder.andWhere(_.omitBy(id, _.isUndefined));
 
   if (options.userIds) {
diff --git a/server/src/validation.ts b/server/src/validation.ts
index 6fb1684c06..4a8d8db866 100644
--- a/server/src/validation.ts
+++ b/server/src/validation.ts
@@ -80,13 +80,13 @@ export function Optional({ nullable, ...validationOptions }: OptionalOptions = {
   return ValidateIf((object: any, v: any) => v !== undefined, validationOptions);
 }
 
-type UUIDOptions = { optional?: boolean; each?: boolean };
+type UUIDOptions = { optional?: boolean; each?: boolean; nullable?: boolean };
 export const ValidateUUID = (options?: UUIDOptions) => {
-  const { optional, each } = { optional: false, each: false, ...options };
+  const { optional, each, nullable } = { optional: false, each: false, nullable: false, ...options };
   return applyDecorators(
     IsUUID('4', { each }),
     ApiProperty({ format: 'uuid' }),
-    optional ? Optional() : IsNotEmpty(),
+    optional ? Optional({ nullable }) : IsNotEmpty(),
     each ? IsArray() : IsString(),
   );
 };