self-hosted/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-08-10 23:22:22 +02:00
Code Issues Releases Activity

feat(all): ffmpeg quality options improvements (#2161)

Browse Source 
* feat: change target scaling to resolution in ffmpeg config

* feat(microservices): scale vertical video correctly, only scale if video is larger than target
This commit is contained in:
Zack Pollard
2023-04-04 02:42:53 +01:00
committed by GitHub
parent 9076f3e69e
commit 808d6423be
12 changed files with 76 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mobile/openapi/doc/SystemConfigFFmpegDto.md generated
View File

@@ -12,7 +12,7 @@ Name | Type | Description | Notes
**preset** | **String** | |
**targetVideoCodec** | **String** | |
**targetAudioCodec** | **String** | |
**targetScaling** | **String** | |
**targetResolution** | **String** | |
**transcode** | **String** | |
[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

16
mobile/openapi/lib/model/system_config_f_fmpeg_dto.dart generated
View File

@@ -17,7 +17,7 @@ class SystemConfigFFmpegDto {
required this.preset,
required this.targetVideoCodec,
required this.targetAudioCodec,
required this.targetScaling,
required this.targetResolution,
required this.transcode,
});
@@ -29,7 +29,7 @@ class SystemConfigFFmpegDto {
String targetAudioCodec;
String targetScaling;
String targetResolution;
SystemConfigFFmpegDtoTranscodeEnum transcode;
@@ -39,7 +39,7 @@ class SystemConfigFFmpegDto {
other.preset == preset &&
other.targetVideoCodec == targetVideoCodec &&
other.targetAudioCodec == targetAudioCodec &&
other.targetScaling == targetScaling &&
other.targetResolution == targetResolution &&
other.transcode == transcode;
@override
@@ -49,11 +49,11 @@ class SystemConfigFFmpegDto {
(preset.hashCode) +
(targetVideoCodec.hashCode) +
(targetAudioCodec.hashCode) +
(targetScaling.hashCode) +
(targetResolution.hashCode) +
(transcode.hashCode);
@override
String toString() => 'SystemConfigFFmpegDto[crf=$crf, preset=$preset, targetVideoCodec=$targetVideoCodec, targetAudioCodec=$targetAudioCodec, targetScaling=$targetScaling, transcode=$transcode]';
String toString() => 'SystemConfigFFmpegDto[crf=$crf, preset=$preset, targetVideoCodec=$targetVideoCodec, targetAudioCodec=$targetAudioCodec, targetResolution=$targetResolution, transcode=$transcode]';
Map<String, dynamic> toJson() {
final json = <String, dynamic>{};
@@ -61,7 +61,7 @@ class SystemConfigFFmpegDto {
json[r'preset'] = this.preset;
json[r'targetVideoCodec'] = this.targetVideoCodec;
json[r'targetAudioCodec'] = this.targetAudioCodec;
json[r'targetScaling'] = this.targetScaling;
json[r'targetResolution'] = this.targetResolution;
json[r'transcode'] = this.transcode;
return json;
}
@@ -89,7 +89,7 @@ class SystemConfigFFmpegDto {
preset: mapValueOfType<String>(json, r'preset')!,
targetVideoCodec: mapValueOfType<String>(json, r'targetVideoCodec')!,
targetAudioCodec: mapValueOfType<String>(json, r'targetAudioCodec')!,
targetScaling: mapValueOfType<String>(json, r'targetScaling')!,
targetResolution: mapValueOfType<String>(json, r'targetResolution')!,
transcode: SystemConfigFFmpegDtoTranscodeEnum.fromJson(json[r'transcode'])!,
);
}
@@ -144,7 +144,7 @@ class SystemConfigFFmpegDto {
'preset',
'targetVideoCodec',
'targetAudioCodec',
'targetScaling',
'targetResolution',
'transcode',
};
}

4
mobile/openapi/test/system_config_f_fmpeg_dto_test.dart generated
View File

@@ -36,8 +36,8 @@ void main() {
// TODO
});
// String targetScaling
test('to test the property `targetScaling`', () async {
// String targetResolution
test('to test the property `targetResolution`', () async {
// TODO
});