1
0
mirror of https://github.com/immich-app/immich.git synced 2025-04-25 13:24:51 +02:00

fix(web): reset search history after logout (#17534)

fix(web): reset search suggestions after logout
This commit is contained in:
Ben 2025-04-10 16:34:45 -04:00 committed by GitHub
parent 75c83cb704
commit 92f0973a46
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 41 additions and 28 deletions

View File

@ -6,7 +6,7 @@
import { assetViewingStore } from '$lib/stores/asset-viewing.store'; import { assetViewingStore } from '$lib/stores/asset-viewing.store';
import { AssetBucket, assetsSnapshot, AssetStore, isSelectingAllAssets } from '$lib/stores/assets-store.svelte'; import { AssetBucket, assetsSnapshot, AssetStore, isSelectingAllAssets } from '$lib/stores/assets-store.svelte';
import { showDeleteModal } from '$lib/stores/preferences.store'; import { showDeleteModal } from '$lib/stores/preferences.store';
import { isSearchEnabled } from '$lib/stores/search.store'; import { searchStore } from '$lib/stores/search.svelte';
import { featureFlags } from '$lib/stores/server-config.store'; import { featureFlags } from '$lib/stores/server-config.store';
import { handlePromiseError } from '$lib/utils'; import { handlePromiseError } from '$lib/utils';
import { deleteAssets, updateStackedAssetInTimeline, updateUnstackedAssetInTimeline } from '$lib/utils/actions'; import { deleteAssets, updateStackedAssetInTimeline, updateUnstackedAssetInTimeline } from '$lib/utils/actions';
@ -425,7 +425,7 @@
}; };
const onKeyDown = (event: KeyboardEvent) => { const onKeyDown = (event: KeyboardEvent) => {
if ($isSearchEnabled) { if (searchStore.isSearchEnabled) {
return; return;
} }
@ -436,7 +436,7 @@
}; };
const onKeyUp = (event: KeyboardEvent) => { const onKeyUp = (event: KeyboardEvent) => {
if ($isSearchEnabled) { if (searchStore.isSearchEnabled) {
return; return;
} }
@ -625,7 +625,7 @@
let shortcutList = $derived( let shortcutList = $derived(
(() => { (() => {
if ($isSearchEnabled || $showAssetViewer) { if (searchStore.isSearchEnabled || $showAssetViewer) {
return []; return [];
} }

View File

@ -1,7 +1,7 @@
<script lang="ts"> <script lang="ts">
import { AppRoute } from '$lib/constants'; import { AppRoute } from '$lib/constants';
import { goto } from '$app/navigation'; import { goto } from '$app/navigation';
import { isSearchEnabled, preventRaceConditionSearchBar, savedSearchTerms } from '$lib/stores/search.store'; import { searchStore } from '$lib/stores/search.svelte';
import { mdiClose, mdiMagnify, mdiTune } from '@mdi/js'; import { mdiClose, mdiMagnify, mdiTune } from '@mdi/js';
import SearchHistoryBox from './search-history-box.svelte'; import SearchHistoryBox from './search-history-box.svelte';
import SearchFilterModal from './search-filter-modal.svelte'; import SearchFilterModal from './search-filter-modal.svelte';
@ -40,41 +40,43 @@
closeDropdown(); closeDropdown();
showFilter = false; showFilter = false;
$isSearchEnabled = false; searchStore.isSearchEnabled = false;
await goto(`${AppRoute.SEARCH}?${params}`); await goto(`${AppRoute.SEARCH}?${params}`);
}; };
const clearSearchTerm = (searchTerm: string) => { const clearSearchTerm = (searchTerm: string) => {
input?.focus(); input?.focus();
$savedSearchTerms = $savedSearchTerms.filter((item) => item !== searchTerm); searchStore.savedSearchTerms = searchStore.savedSearchTerms.filter((item) => item !== searchTerm);
}; };
const saveSearchTerm = (saveValue: string) => { const saveSearchTerm = (saveValue: string) => {
const filteredSearchTerms = $savedSearchTerms.filter((item) => item.toLowerCase() !== saveValue.toLowerCase()); const filteredSearchTerms = searchStore.savedSearchTerms.filter(
$savedSearchTerms = [saveValue, ...filteredSearchTerms]; (item) => item.toLowerCase() !== saveValue.toLowerCase(),
);
searchStore.savedSearchTerms = [saveValue, ...filteredSearchTerms];
if ($savedSearchTerms.length > 5) { if (searchStore.savedSearchTerms.length > 5) {
$savedSearchTerms = $savedSearchTerms.slice(0, 5); searchStore.savedSearchTerms = searchStore.savedSearchTerms.slice(0, 5);
} }
}; };
const clearAllSearchTerms = () => { const clearAllSearchTerms = () => {
input?.focus(); input?.focus();
$savedSearchTerms = []; searchStore.savedSearchTerms = [];
}; };
const onFocusIn = () => { const onFocusIn = () => {
$isSearchEnabled = true; searchStore.isSearchEnabled = true;
}; };
const onFocusOut = () => { const onFocusOut = () => {
const focusOutTimer = setTimeout(() => { const focusOutTimer = setTimeout(() => {
if ($isSearchEnabled) { if (searchStore.isSearchEnabled) {
$preventRaceConditionSearchBar = true; searchStore.preventRaceConditionSearchBar = true;
} }
closeDropdown(); closeDropdown();
$isSearchEnabled = false; searchStore.isSearchEnabled = false;
showFilter = false; showFilter = false;
}, 100); }, 100);
@ -225,7 +227,9 @@
class="w-full transition-all border-2 px-14 py-4 max-md:py-2 text-immich-fg/75 dark:text-immich-dark-fg class="w-full transition-all border-2 px-14 py-4 max-md:py-2 text-immich-fg/75 dark:text-immich-dark-fg
{grayTheme ? 'dark:bg-immich-dark-gray' : 'dark:bg-immich-dark-bg'} {grayTheme ? 'dark:bg-immich-dark-gray' : 'dark:bg-immich-dark-bg'}
{showSuggestions && isSearchSuggestions ? 'rounded-t-3xl' : 'rounded-3xl bg-gray-200'} {showSuggestions && isSearchSuggestions ? 'rounded-t-3xl' : 'rounded-3xl bg-gray-200'}
{$isSearchEnabled && !showFilter ? 'border-gray-200 dark:border-gray-700 bg-white' : 'border-transparent'}" {searchStore.isSearchEnabled && !showFilter
? 'border-gray-200 dark:border-gray-700 bg-white'
: 'border-transparent'}"
placeholder={$t('search_your_photos')} placeholder={$t('search_your_photos')}
required required
pattern="^(?!m:$).*$" pattern="^(?!m:$).*$"

View File

@ -1,6 +1,6 @@
<script lang="ts"> <script lang="ts">
import Icon from '$lib/components/elements/icon.svelte'; import Icon from '$lib/components/elements/icon.svelte';
import { savedSearchTerms } from '$lib/stores/search.store'; import { searchStore } from '$lib/stores/search.svelte';
import { mdiMagnify, mdiClose } from '@mdi/js'; import { mdiMagnify, mdiClose } from '@mdi/js';
import { fly } from 'svelte/transition'; import { fly } from 'svelte/transition';
import { t } from 'svelte-i18n'; import { t } from 'svelte-i18n';
@ -29,7 +29,7 @@
}: Props = $props(); }: Props = $props();
let filteredSearchTerms = $derived( let filteredSearchTerms = $derived(
$savedSearchTerms.filter((term) => term.toLowerCase().includes(searchQuery.toLowerCase())), searchStore.savedSearchTerms.filter((term) => term.toLowerCase().includes(searchQuery.toLowerCase())),
); );
$effect(() => { $effect(() => {

View File

@ -1,6 +0,0 @@
import { persisted } from 'svelte-persisted-store';
import { writable } from 'svelte/store';
export const savedSearchTerms = persisted<string[]>('search-terms', [], {});
export const isSearchEnabled = writable<boolean>(false);
export const preventRaceConditionSearchBar = writable<boolean>(false);

View File

@ -0,0 +1,13 @@
class SearchStore {
savedSearchTerms = $state<string[]>([]);
isSearchEnabled = $state(false);
preventRaceConditionSearchBar = $state(false);
clearCache() {
this.savedSearchTerms = [];
this.isSearchEnabled = false;
this.preventRaceConditionSearchBar = false;
}
}
export const searchStore = new SearchStore();

View File

@ -3,6 +3,7 @@ import { goto } from '$app/navigation';
import { foldersStore } from '$lib/stores/folders.svelte'; import { foldersStore } from '$lib/stores/folders.svelte';
import { memoryStore } from '$lib/stores/memory.store.svelte'; import { memoryStore } from '$lib/stores/memory.store.svelte';
import { purchaseStore } from '$lib/stores/purchase.store'; import { purchaseStore } from '$lib/stores/purchase.store';
import { searchStore } from '$lib/stores/search.svelte';
import { preferences as preferences$, resetSavedUser, user as user$ } from '$lib/stores/user.store'; import { preferences as preferences$, resetSavedUser, user as user$ } from '$lib/stores/user.store';
import { resetUserInteraction, userInteraction } from '$lib/stores/user.svelte'; import { resetUserInteraction, userInteraction } from '$lib/stores/user.svelte';
import { getAboutInfo, getMyPreferences, getMyUser, getStorage } from '@immich/sdk'; import { getAboutInfo, getMyPreferences, getMyUser, getStorage } from '@immich/sdk';
@ -103,5 +104,6 @@ export const handleLogout = async (redirectUri: string) => {
resetUserInteraction(); resetUserInteraction();
foldersStore.clearCache(); foldersStore.clearCache();
memoryStore.clearCache(); memoryStore.clearCache();
searchStore.clearCache();
} }
}; };

View File

@ -19,7 +19,7 @@
import SearchBar from '$lib/components/shared-components/search-bar/search-bar.svelte'; import SearchBar from '$lib/components/shared-components/search-bar/search-bar.svelte';
import { AppRoute, QueryParameter } from '$lib/constants'; import { AppRoute, QueryParameter } from '$lib/constants';
import { assetViewingStore } from '$lib/stores/asset-viewing.store'; import { assetViewingStore } from '$lib/stores/asset-viewing.store';
import { preventRaceConditionSearchBar } from '$lib/stores/search.store'; import { searchStore } from '$lib/stores/search.svelte';
import { shortcut } from '$lib/actions/shortcut'; import { shortcut } from '$lib/actions/shortcut';
import { import {
type AlbumResponseDto, type AlbumResponseDto,
@ -88,10 +88,10 @@
assetInteraction.selectedAssets = []; assetInteraction.selectedAssets = [];
return; return;
} }
if (!$preventRaceConditionSearchBar) { if (!searchStore.preventRaceConditionSearchBar) {
handlePromiseError(goto(previousRoute)); handlePromiseError(goto(previousRoute));
} }
$preventRaceConditionSearchBar = false; searchStore.preventRaceConditionSearchBar = false;
}; };
$effect(() => { $effect(() => {