From b77646129735cb8e5b1716f9b045d5c68719f67d Mon Sep 17 00:00:00 2001
From: Alex <alex.tran1502@gmail.com>
Date: Wed, 17 May 2023 21:13:54 -0500
Subject: [PATCH] fix(web): unable to change person name (#2458)

* fix(web): unable to change person name

* name changed

* chore: strongly-typed dispatcher

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
---
 .../lib/components/faces-page/edit-name-input.svelte | 12 ++++++++----
 web/src/routes/(user)/people/[personId]/+page.svelte |  2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/web/src/lib/components/faces-page/edit-name-input.svelte b/web/src/lib/components/faces-page/edit-name-input.svelte
index 9eca6402b3..ba9a7eb5c4 100644
--- a/web/src/lib/components/faces-page/edit-name-input.svelte
+++ b/web/src/lib/components/faces-page/edit-name-input.svelte
@@ -3,16 +3,21 @@
 	import { createEventDispatcher } from 'svelte';
 	import ImageThumbnail from '../assets/thumbnail/image-thumbnail.svelte';
 	import Button from '../elements/buttons/button.svelte';
+	import { clickOutside } from '$lib/utils/click-outside';
 
 	export let person: PersonResponseDto;
 	let name = person.name;
 
-	const dispatch = createEventDispatcher<{ change: string }>();
-	const handleNameChange = () => dispatch('change', name);
+	const dispatch = createEventDispatcher<{
+		change: string;
+		cancel: void;
+	}>();
 </script>
 
 <div
 	class="flex place-items-center max-w-lg rounded-lg border dark:border-transparent p-2 bg-gray-100 dark:bg-gray-700"
+	use:clickOutside
+	on:outclick={() => dispatch('cancel')}
 >
 	<ImageThumbnail
 		circle
@@ -25,7 +30,7 @@
 	<form
 		class="ml-4 flex justify-between w-full gap-16"
 		autocomplete="off"
-		on:submit|preventDefault={handleNameChange}
+		on:submit|preventDefault={() => dispatch('change', name)}
 	>
 		<!-- svelte-ignore a11y-autofocus -->
 		<input
@@ -35,7 +40,6 @@
 			placeholder="New name or nickname"
 			required
 			bind:value={name}
-			on:blur
 		/>
 		<Button size="sm" type="submit">Done</Button>
 	</form>
diff --git a/web/src/routes/(user)/people/[personId]/+page.svelte b/web/src/routes/(user)/people/[personId]/+page.svelte
index 7c22215396..3b0cbe75fd 100644
--- a/web/src/routes/(user)/people/[personId]/+page.svelte
+++ b/web/src/routes/(user)/people/[personId]/+page.svelte
@@ -70,7 +70,7 @@
 		<EditNameInput
 			person={data.person}
 			on:change={(event) => handleNameChange(event.detail)}
-			on:blur={() => (isEditName = false)}
+			on:cancel={() => (isEditName = false)}
 		/>
 	{:else}
 		<ImageThumbnail