self-hosted/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-08-08 23:07:06 +02:00
Code Issues Releases Activity

fix(mobile): fix text search (#14873)

Browse Source 
* fix(mobile): fix text search

* chore(mobile): add tests for SearchPage

* fix(mobile): fix render overflow for small screens

Needed for SearchPage test to not throw overflow error

* chore(mobile): update import_rule_openapi

* styling

* preserve styling and skip a test

---------

Co-authored-by: Alex <alex.tran1502@gmail.com>
This commit is contained in:
John Stef
2025-01-07 18:26:14 +02:00
committed by GitHub
parent 776be7d205
commit c148a28a82
9 changed files with 215 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mobile/test/dto.mocks.dart Normal file
View File

@ -0,0 +1,6 @@
import 'package:mocktail/mocktail.dart';
import 'package:openapi/api.dart';
class MockSmartSearchDto extends Mock implements SmartSearchDto {}
class MockMetadataSearchDto extends Mock implements MetadataSearchDto {}

189
mobile/test/pages/search/search.page_test.dart Normal file
View File

@ -0,0 +1,189 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:immich_mobile/entities/store.entity.dart';
import 'package:immich_mobile/pages/search/search.page.dart';
import 'package:immich_mobile/providers/api.provider.dart';
import 'package:immich_mobile/providers/db.provider.dart';
import 'package:immich_mobile/providers/search/paginated_search.provider.dart';
import 'package:immich_mobile/widgets/asset_grid/asset_grid_data_structure.dart';
import 'package:isar/isar.dart';
import 'package:mocktail/mocktail.dart';
import 'package:openapi/api.dart';
import '../../dto.mocks.dart';
import '../../service.mocks.dart';
import '../../test_utils.dart';
import '../../widget_tester_extensions.dart';
void main() {
late List<Override> overrides;
late Isar db;
late MockApiService mockApiService;
late MockSearchApi mockSearchApi;
setUpAll(() async {
TestUtils.init();
db = await TestUtils.initIsar();
Store.init(db);
mockApiService = MockApiService();
mockSearchApi = MockSearchApi();
when(() => mockApiService.searchApi).thenReturn(mockSearchApi);
registerFallbackValue(MockSmartSearchDto());
registerFallbackValue(MockMetadataSearchDto());
overrides = [
paginatedSearchRenderListProvider
.overrideWithValue(AsyncValue.data(RenderList.empty())),
dbProvider.overrideWithValue(db),
apiServiceProvider.overrideWithValue(mockApiService),
];
});
final emptyTextSearch = isA<MetadataSearchDto>()
.having((s) => s.originalFileName, 'originalFileName', null);
testWidgets('contextual search with/without text', (tester) async {
await tester.pumpConsumerWidget(
const SearchPage(),
overrides: overrides,
);
await tester.pumpAndSettle();
expect(
find.byIcon(Icons.abc_rounded),
findsOneWidget,
reason: 'Should have contextual search icon',
);
final searchField = find.byKey(const Key('search_text_field'));
expect(searchField, findsOneWidget);
await tester.enterText(searchField, 'test');
await tester.testTextInput.receiveAction(TextInputAction.search);
var captured = verify(
() => mockSearchApi.searchSmart(captureAny()),
).captured;
expect(
captured.first,
isA<SmartSearchDto>().having((s) => s.query, 'query', 'test'),
);
await tester.enterText(searchField, '');
await tester.testTextInput.receiveAction(TextInputAction.search);
captured = verify(() => mockSearchApi.searchAssets(captureAny())).captured;
expect(captured.first, emptyTextSearch);
});
testWidgets('not contextual search with/without text', (tester) async {
await tester.pumpConsumerWidget(
const SearchPage(),
overrides: overrides,
);
await tester.pumpAndSettle();
await tester.tap(find.byKey(const Key('contextual_search_button')));
await tester.pumpAndSettle();
expect(
find.byIcon(Icons.image_search_rounded),
findsOneWidget,
reason: 'Should not have contextual search icon',
);
final searchField = find.byKey(const Key('search_text_field'));
expect(searchField, findsOneWidget);
await tester.enterText(searchField, 'test');
await tester.testTextInput.receiveAction(TextInputAction.search);
var captured = verify(
() => mockSearchApi.searchAssets(captureAny()),
).captured;
expect(
captured.first,
isA<MetadataSearchDto>()
.having((s) => s.originalFileName, 'originalFileName', 'test'),
);
await tester.enterText(searchField, '');
await tester.testTextInput.receiveAction(TextInputAction.search);
captured = verify(() => mockSearchApi.searchAssets(captureAny())).captured;
expect(captured.first, emptyTextSearch);
});
// COME BACK LATER
// testWidgets('contextual search with text combined with media type',
// (tester) async {
// await tester.pumpConsumerWidget(
// const SearchPage(),
// overrides: overrides,
// );
// await tester.pumpAndSettle();
// expect(
// find.byIcon(Icons.abc_rounded),
// findsOneWidget,
// reason: 'Should have contextual search icon',
// );
// final searchField = find.byKey(const Key('search_text_field'));
// expect(searchField, findsOneWidget);
// await tester.enterText(searchField, 'test');
// await tester.testTextInput.receiveAction(TextInputAction.search);
// var captured = verify(
// () => mockSearchApi.searchSmart(captureAny()),
// ).captured;
// expect(
// captured.first,
// isA<SmartSearchDto>().having((s) => s.query, 'query', 'test'),
// );
// await tester.dragUntilVisible(
// find.byKey(const Key('media_type_chip')),
// find.byKey(const Key('search_filter_chip_list')),
// const Offset(-100, 0),
// );
// await tester.pumpAndSettle();
// await tester.tap(find.byKey(const Key('media_type_chip')));
// await tester.pumpAndSettle();
// await tester.tap(find.byKey(const Key('search_filter_media_type_image')));
// await tester.pumpAndSettle();
// await tester.tap(find.byKey(const Key('search_filter_apply')));
// await tester.pumpAndSettle();
// captured = verify(() => mockSearchApi.searchSmart(captureAny())).captured;
// expect(
// captured.first,
// isA<SmartSearchDto>()
// .having((s) => s.query, 'query', 'test')
// .having((s) => s.type, 'type', AssetTypeEnum.IMAGE),
// );
// await tester.enterText(searchField, '');
// await tester.testTextInput.receiveAction(TextInputAction.search);
// captured = verify(() => mockSearchApi.searchAssets(captureAny())).captured;
// expect(
// captured.first,
// isA<MetadataSearchDto>()
// .having((s) => s.originalFileName, 'originalFileName', null)
// .having((s) => s.type, 'type', AssetTypeEnum.IMAGE),
// );
// });
}

3
mobile/test/service.mocks.dart
View File

@ -5,6 +5,7 @@ import 'package:immich_mobile/services/network.service.dart';
import 'package:immich_mobile/services/sync.service.dart';
import 'package:immich_mobile/services/user.service.dart';
import 'package:mocktail/mocktail.dart';
import 'package:openapi/api.dart';
class MockApiService extends Mock implements ApiService {}
@ -17,3 +18,5 @@ class MockHashService extends Mock implements HashService {}
class MockEntityService extends Mock implements EntityService {}
class MockNetworkService extends Mock implements NetworkService {}
class MockSearchApi extends Mock implements SearchApi {}