self-hosted/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-08-10 23:22:22 +02:00
Code Issues Releases Activity

fix(server): cannot share album to owner (#18802)

Browse Source 
* fix(server): create shared album

* add test

* trigger ci

* resolve conversation
This commit is contained in:
Daimolean
2025-06-02 09:58:07 +08:00
committed by GitHub
parent daf1a48b54
commit c89ac5b5e5
3 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/src/services/album.service.spec.ts
View File

@@ -210,6 +210,17 @@ describe(AlbumService.name, () => {
false,
);
});
it('should throw an error if the userId is the ownerId', async () => {
mocks.user.get.mockResolvedValue(userStub.admin);
await expect(
sut.create(authStub.admin, {
albumName: 'Empty album',
albumUsers: [{ userId: userStub.admin.id, role: AlbumUserRole.EDITOR }],
}),
).rejects.toBeInstanceOf(BadRequestException);
expect(mocks.album.create).not.toHaveBeenCalled();
});
});
describe('update', () => {

4
server/src/services/album.service.ts
View File

@@ -93,6 +93,10 @@ export class AlbumService extends BaseService {
if (!exists) {
throw new BadRequestException('User not found');
}
if (userId == auth.user.id) {
throw new BadRequestException('Cannot share album with owner');
}
}
const allowedAssetIdsSet = await this.checkAccess({