From e3e8fe25c9a2ddeb3e69fbbb664250b807f644c5 Mon Sep 17 00:00:00 2001 From: Yonathan Randolph Date: Sun, 13 Oct 2024 02:35:59 -0700 Subject: [PATCH] chore: respond to PR: don't add dev target web/Dockerfile is only used by docker-compose.dev.yml so a dev target is redundant. Instead, just remove the copy --- docker/docker-compose.dev.yml | 1 - web/Dockerfile | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/docker/docker-compose.dev.yml b/docker/docker-compose.dev.yml index bc187455a9..60685d84d6 100644 --- a/docker/docker-compose.dev.yml +++ b/docker/docker-compose.dev.yml @@ -55,7 +55,6 @@ services: image: immich-web-dev:latest build: context: ../web - target: dev command: ['/usr/src/app/bin/immich-web'] env_file: - .env diff --git a/web/Dockerfile b/web/Dockerfile index fbefbbec1b..7be16ae01b 100644 --- a/web/Dockerfile +++ b/web/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20.17.0-alpine3.20@sha256:2d07db07a2df6830718ae2a47db6fedce6745f5bcd174c398f2acdda90a11c03 AS dev +FROM node:20.17.0-alpine3.20@sha256:2d07db07a2df6830718ae2a47db6fedce6745f5bcd174c398f2acdda90a11c03 RUN apk add --no-cache tini USER node @@ -9,6 +9,3 @@ ENV CHOKIDAR_USEPOLLING=true EXPOSE 24678 EXPOSE 3000 ENTRYPOINT ["/sbin/tini", "--", "/bin/sh"] - -FROM dev -COPY --chown=node:node . . \ No newline at end of file