From e58131492d2647b88e1680fff5678b56cc7198f8 Mon Sep 17 00:00:00 2001 From: Mert <101130780+mertalev@users.noreply.github.com> Date: Tue, 18 Jun 2024 19:02:33 -0400 Subject: [PATCH] fix(server): consider all I-frames for video thumbnails (#10471) nointra instead of nokey --- server/src/services/media.service.spec.ts | 6 +++--- server/src/utils/media.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/src/services/media.service.spec.ts b/server/src/services/media.service.spec.ts index d7addef737..0003a7490c 100644 --- a/server/src/services/media.service.spec.ts +++ b/server/src/services/media.service.spec.ts @@ -344,7 +344,7 @@ describe(MediaService.name, () => { '/original/path.ext', 'upload/thumbs/user-id/as/se/asset-id-preview.jpeg', { - inputOptions: ['-skip_frame nokey', '-sws_flags accurate_rnd+full_chroma_int'], + inputOptions: ['-skip_frame nointra', '-sws_flags accurate_rnd+full_chroma_int'], outputOptions: [ '-fps_mode vfr', '-frames:v 1', @@ -371,7 +371,7 @@ describe(MediaService.name, () => { '/original/path.ext', 'upload/thumbs/user-id/as/se/asset-id-preview.jpeg', { - inputOptions: ['-skip_frame nokey', '-sws_flags accurate_rnd+full_chroma_int'], + inputOptions: ['-skip_frame nointra', '-sws_flags accurate_rnd+full_chroma_int'], outputOptions: [ '-fps_mode vfr', '-frames:v 1', @@ -400,7 +400,7 @@ describe(MediaService.name, () => { '/original/path.ext', 'upload/thumbs/user-id/as/se/asset-id-preview.jpeg', { - inputOptions: ['-skip_frame nokey', '-sws_flags accurate_rnd+full_chroma_int'], + inputOptions: ['-skip_frame nointra', '-sws_flags accurate_rnd+full_chroma_int'], outputOptions: [ '-fps_mode vfr', '-frames:v 1', diff --git a/server/src/utils/media.ts b/server/src/utils/media.ts index 1fefd23ce6..f55a1abdd9 100644 --- a/server/src/utils/media.ts +++ b/server/src/utils/media.ts @@ -384,7 +384,7 @@ export class ThumbnailConfig extends BaseConfig { } getBaseInputOptions(): string[] { - return ['-skip_frame nokey', '-sws_flags accurate_rnd+full_chroma_int']; + return ['-skip_frame nointra', '-sws_flags accurate_rnd+full_chroma_int']; } getBaseOutputOptions() {