From f99f289f74061d7489cba386c5e4046e2087d287 Mon Sep 17 00:00:00 2001
From: Michel Heusschen <59014050+michelheusschen@users.noreply.github.com>
Date: Wed, 12 Jun 2024 13:13:10 +0200
Subject: [PATCH] fix(web): small translation issues + remove unused (#10200)

* fix(web): small translation issues + remove unused

* more unused keys

* formatting

* fix(web): incorrectly used translations

* fix and remove unused translations

---------

Co-authored-by: Zack Pollard <zackpollard@ymail.com>
---
 .../storage-template-settings.svelte          |  2 +-
 .../asset-viewer/asset-viewer-nav-bar.svelte  |  4 ++--
 .../asset-viewer/photo-viewer.svelte          |  4 ++--
 .../faces-page/person-side-panel.svelte       |  6 +++---
 .../forms/admin-registration-form.svelte      |  4 ++--
 .../photos-page/actions/archive-action.svelte |  2 +-
 .../actions/favorite-action.svelte            |  2 +-
 web/src/lib/i18n/en.json                      | 20 +++----------------
 .../(user)/sharing/sharedlinks/+page.svelte   |  2 +-
 .../[[assetId=id]]/+page.svelte               |  2 +-
 10 files changed, 17 insertions(+), 31 deletions(-)

diff --git a/web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte b/web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte
index cef0f6c96c..fbbf6b7b68 100644
--- a/web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte
+++ b/web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte
@@ -55,7 +55,7 @@
     const substitutions: Record<string, string> = {
       filename: 'IMAGE_56437',
       ext: 'jpg',
-      filetype: $t('img').toUpperCase(),
+      filetype: 'IMG',
       filetypefull: 'IMAGE',
       assetId: 'a8312960-e277-447d-b4ea-56717ccba856',
       album: $t('album_name'),
diff --git a/web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte b/web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte
index 746871516f..9656da0f24 100644
--- a/web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte
+++ b/web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte
@@ -177,7 +177,7 @@
         color="opaque"
         icon={asset.isFavorite ? mdiHeart : mdiHeartOutline}
         on:click={() => dispatch('favorite')}
-        title={asset.isFavorite ? $t('unfavorite') : $t('favorite')}
+        title={asset.isFavorite ? $t('unfavorite') : $t('to_favorite')}
       />
     {/if}
 
@@ -242,7 +242,7 @@
               <MenuOption
                 on:click={() => onMenuClick('toggleArchive')}
                 icon={asset.isArchived ? mdiArchiveArrowUpOutline : mdiArchiveArrowDownOutline}
-                text={asset.isArchived ? $t('unarchive') : $t('archive')}
+                text={asset.isArchived ? $t('unarchive') : $t('to_archive')}
               />
               <MenuOption
                 icon={mdiUpload}
diff --git a/web/src/lib/components/asset-viewer/photo-viewer.svelte b/web/src/lib/components/asset-viewer/photo-viewer.svelte
index 5ef9e99421..384b3ebc19 100644
--- a/web/src/lib/components/asset-viewer/photo-viewer.svelte
+++ b/web/src/lib/components/asset-viewer/photo-viewer.svelte
@@ -97,7 +97,7 @@
   };
 
   const onCopyShortcut = (event: KeyboardEvent) => {
-    if (window.getSelection()?.type === $t('range')) {
+    if (window.getSelection()?.type === 'Range') {
       return;
     }
     event.preventDefault();
@@ -112,7 +112,7 @@
   ]}
 />
 {#if imageError}
-  <div class="h-full flex items-center justify-center">Error loading image</div>
+  <div class="h-full flex items-center justify-center">{$t('error_loading_image')}</div>
 {/if}
 <div bind:this={element} class="relative h-full select-none">
   <img
diff --git a/web/src/lib/components/faces-page/person-side-panel.svelte b/web/src/lib/components/faces-page/person-side-panel.svelte
index f8f9b2bc3d..a25e303103 100644
--- a/web/src/lib/components/faces-page/person-side-panel.svelte
+++ b/web/src/lib/components/faces-page/person-side-panel.svelte
@@ -225,8 +225,8 @@
                     curve
                     shadow
                     url={selectedPersonToCreate[face.id]}
-                    altText={'New person'}
-                    title={'New person'}
+                    altText={$t('new_person')}
+                    title={$t('new_person')}
                     widthStyle={thumbnailWidth}
                     heightStyle={thumbnailWidth}
                   />
@@ -309,7 +309,7 @@
                   <CircleIconButton
                     color="primary"
                     icon={mdiMinus}
-                    title="Select new face"
+                    title={$t('select_new_face')}
                     size="18"
                     padding="1"
                     class="absolute left-1/2 top-1/2 translate-x-[-50%] translate-y-[-50%] transform"
diff --git a/web/src/lib/components/forms/admin-registration-form.svelte b/web/src/lib/components/forms/admin-registration-form.svelte
index 5cb1e79d18..54667cd300 100644
--- a/web/src/lib/components/forms/admin-registration-form.svelte
+++ b/web/src/lib/components/forms/admin-registration-form.svelte
@@ -33,8 +33,8 @@
         await signUpAdmin({ signUpDto: { email, password, name } });
         await goto(AppRoute.AUTH_LOGIN);
       } catch (error) {
-        handleError(error, 'errors.errors.unable_to_create_admin_account');
-        errorMessage = $t('errors.errors.unable_to_create_admin_account');
+        handleError(error, 'errors.unable_to_create_admin_account');
+        errorMessage = $t('errors.unable_to_create_admin_account');
       }
     }
   }
diff --git a/web/src/lib/components/photos-page/actions/archive-action.svelte b/web/src/lib/components/photos-page/actions/archive-action.svelte
index e6384d8569..59b0916064 100644
--- a/web/src/lib/components/photos-page/actions/archive-action.svelte
+++ b/web/src/lib/components/photos-page/actions/archive-action.svelte
@@ -12,7 +12,7 @@
   export let menuItem = false;
   export let unarchive = false;
 
-  $: text = unarchive ? $t('unarchive') : $t('archive');
+  $: text = unarchive ? $t('unarchive') : $t('to_archive');
   $: icon = unarchive ? mdiArchiveArrowUpOutline : mdiArchiveArrowDownOutline;
 
   let loading = false;
diff --git a/web/src/lib/components/photos-page/actions/favorite-action.svelte b/web/src/lib/components/photos-page/actions/favorite-action.svelte
index 9f70751bf1..3e5583bf58 100644
--- a/web/src/lib/components/photos-page/actions/favorite-action.svelte
+++ b/web/src/lib/components/photos-page/actions/favorite-action.svelte
@@ -17,7 +17,7 @@
   export let menuItem = false;
   export let removeFavorite: boolean;
 
-  $: text = removeFavorite ? $t('remove_from_favorites') : $t('favorite');
+  $: text = removeFavorite ? $t('remove_from_favorites') : $t('to_favorite');
   $: icon = removeFavorite ? mdiHeartMinusOutline : mdiHeartOutline;
 
   let loading = false;
diff --git a/web/src/lib/i18n/en.json b/web/src/lib/i18n/en.json
index 85d088cc70..c2aa7d1bb8 100644
--- a/web/src/lib/i18n/en.json
+++ b/web/src/lib/i18n/en.json
@@ -206,7 +206,6 @@
     "these_files_matched_by_checksum": "These files are matched by their checksums",
     "thumbnail_generation_job": "Generate Thumbnails",
     "thumbnail_generation_job_description": "Generate large, small and blurred thumbnails for each asset, as well as thumbnails for each person",
-    "transcode_policy_description": "Policy for when a video should be transcoded. HDR videos will always be transcoded (except if transcoding is disabled).",
     "transcoding_acceleration_api": "Acceleration API",
     "transcoding_acceleration_api_description": "The API that will interact with your device to accelerate transcoding. This setting is 'best effort': it will fallback to software transcoding on failure. VP9 may or may not work depending on your hardware.",
     "transcoding_acceleration_nvenc": "NVENC (requires NVIDIA GPU)",
@@ -258,6 +257,7 @@
     "transcoding_tone_mapping_npl": "TONE-MAPPING NPL",
     "transcoding_tone_mapping_npl_description": "Colors will be adjusted to look normal for a display of this brightness. Counter-intuitively, lower values increase the brightness of the video and vice versa since it compensates for the brightness of the display. 0 sets this value automatically.",
     "transcoding_transcode_policy": "Transcode policy",
+    "transcoding_transcode_policy_description": "Policy for when a video should be transcoded. HDR videos will always be transcoded (except if transcoding is disabled).",
     "transcoding_two_pass_encoding": "TWO-PASS ENCODING",
     "transcoding_two_pass_encoding_setting_description": "Transcode in two passes to produce better encoded videos. When max bitrate is enabled (required for it to work with H.264 and HEVC), this mode uses a bitrate range based on the max bitrate and ignores CRF. For VP9, CRF can be used if max bitrate is disabled.",
     "transcoding_video_codec": "Video Codec",
@@ -431,7 +431,6 @@
   "edited": "Edited",
   "editor": "Editor",
   "email": "Email",
-  "empty": "Empty",
   "empty_album": "Empty Album",
   "empty_trash": "Empty trash",
   "enable": "Enable",
@@ -457,7 +456,6 @@
     "unable_to_change_location": "Unable to change location",
     "unable_to_change_password": "Unable to change password",
     "unable_to_copy_to_clipboard": "Cannot copy to clipboard, make sure you are accessing the page through https",
-    "unable_to_create_admin_account": "Unable to create admin account",
     "unable_to_create_api_key": "Unable to create a new API Key",
     "unable_to_create_library": "Unable to create library",
     "unable_to_create_user": "Unable to create user",
@@ -481,12 +479,10 @@
     "unable_to_refresh_user": "Unable to refresh user",
     "unable_to_remove_album_users": "Unable to remove albums users",
     "unable_to_remove_api_key": "Unable to remove API Key",
-    "unable_to_remove_comment": "Unable to remove comment",
     "unable_to_remove_library": "Unable to remove library",
     "unable_to_remove_offline_files": "nable to remove offline files",
     "unable_to_remove_partner": "Unable to remove partner",
     "unable_to_remove_reaction": "Unable to remove reaction",
-    "unable_to_remove_user": "Unable to remove user",
     "unable_to_repair_items": "Unable to repair items",
     "unable_to_reset_password": "Unable to reset password",
     "unable_to_resolve_duplicate": "Unable to resolve duplicate",
@@ -510,10 +506,6 @@
     "unable_to_update_timeline_display_status": "Unable to update timeline display status",
     "unable_to_update_user": "Unable to update user"
   },
-  "every_day_at_onepm": "Every day at 1pm",
-  "every_night_at_midnight": "Every night at midnight",
-  "every_night_at_twoam": "Every night at 2am",
-  "every_six_hours": "Every 6 hours",
   "exit_slideshow": "Exit Slideshow",
   "expand_all": "Expand all",
   "expire_after": "Expire after",
@@ -527,9 +519,7 @@
   "favorite": "Favorite",
   "favorite_or_unfavorite_photo": "Favorite or unfavorite photo",
   "favorites": "Favorites",
-  "feature": "Feature",
   "feature_photo_updated": "Feature photo updated",
-  "featurecollection": "FeatureCollection",
   "file_name": "File name",
   "file_name_or_extension": "File name or extension",
   "filename": "Filename",
@@ -552,7 +542,6 @@
   "host": "Host",
   "hour": "Hour",
   "image": "Image",
-  "img": "Img",
   "immich_logo": "Immich Logo",
   "import_from_json": "Import from JSON",
   "import_path": "Import path",
@@ -570,7 +559,6 @@
   },
   "invite_people": "Invite People",
   "invite_to_album": "Invite to album",
-  "job_settings_description": "Manage job concurrency",
   "jobs": "Jobs",
   "keep": "Keep",
   "keyboard_shortcuts": "Keyboard shortcuts",
@@ -611,7 +599,6 @@
   "memories": "Memories",
   "memories_setting_description": "Manage what you see in your memories",
   "menu": "Menu",
-  "merge": "Merge",
   "merge_people": "Merge people",
   "merge_people_successfully": "Merge people successfully",
   "minimize": "Minimize",
@@ -699,7 +686,6 @@
   "play_memories": "Play memories",
   "play_motion_photo": "Play Motion Photo",
   "play_or_pause_video": "Play or pause video",
-  "point": "Point",
   "port": "Port",
   "preset": "Preset",
   "preview": "Preview",
@@ -709,8 +695,6 @@
   "primary": "Primary",
   "profile_picture_set": "Profile picture set.",
   "public_share": "Public Share",
-  "range": "Range",
-  "raw": "Raw",
   "reaction_options": "Reaction options",
   "read_changelog": "Read Changelog",
   "recent": "Recent",
@@ -836,6 +820,8 @@
   "theme_selection_description": "Automatically set the theme to light or dark based on your browser's system preference",
   "time_based_memories": "Time-based memories",
   "timezone": "Timezone",
+  "to_archive": "Archive",
+  "to_favorite": "Favorite",
   "toggle_settings": "Toggle settings",
   "toggle_theme": "Toggle theme",
   "toggle_visibility": "Toggle visibility",
diff --git a/web/src/routes/(user)/sharing/sharedlinks/+page.svelte b/web/src/routes/(user)/sharing/sharedlinks/+page.svelte
index d89ece120d..47decdd395 100644
--- a/web/src/routes/(user)/sharing/sharedlinks/+page.svelte
+++ b/web/src/routes/(user)/sharing/sharedlinks/+page.svelte
@@ -32,7 +32,7 @@
   const handleDeleteLink = async (id: string) => {
     const isConfirmed = await dialogController.show({
       id: 'delete-shared-link',
-      title: 'Delete shared link',
+      title: $t('delete_shared_link'),
       prompt: 'Are you sure you want to delete this shared link?',
       confirmText: 'Delete',
     });
diff --git a/web/src/routes/(user)/trash/[[photos=photos]]/[[assetId=id]]/+page.svelte b/web/src/routes/(user)/trash/[[photos=photos]]/[[assetId=id]]/+page.svelte
index 4f8c0a6ad4..624698334d 100644
--- a/web/src/routes/(user)/trash/[[photos=photos]]/[[assetId=id]]/+page.svelte
+++ b/web/src/routes/(user)/trash/[[photos=photos]]/[[assetId=id]]/+page.svelte
@@ -107,7 +107,7 @@
       <LinkButton on:click={() => handleEmptyTrash()} disabled={$isMultiSelectState}>
         <div class="flex place-items-center gap-2 text-sm">
           <Icon path={mdiDeleteForeverOutline} size="18" />
-          Empty trash
+          {$t('empty_trash')}
         </div>
       </LinkButton>
     </div>