mirror of
https://github.com/immich-app/immich.git
synced 2024-12-23 02:06:15 +02:00
4e9b96ff1a
* Allow building and installing cli * feat: add format fix * docs: remove cli folder * feat: use immich scoped package * feat: rewrite cli readme * docs: add info on running without building * cleanup * chore: remove import functionality from cli * feat: add logout to cli * docs: add todo for file format from server * docs: add compilation step to cli * fix: success message spacing * feat: can create albums * fix: add check step to cli * fix: typos * feat: pull file formats from server * chore: use crawl service from server * chore: fix lint * docs: add cli documentation * chore: rename ignore pattern * chore: add version number to cli * feat: use sdk * fix: cleanup * feat: album name on windows * chore: remove skipped asset field * feat: add more info to server-info command * chore: cleanup * wip * chore: remove unneeded packages * e2e test can start * git ignore for geocode in cli * add cli e2e to github actions * can do e2e tests in the cli * simplify e2e test * cleanup * set matrix strategy in workflow * run npm ci in server * choose different working directory * check out submodules too * increase test timeout * set node version * cli docker e2e tests * fix cli docker file * run cli e2e in correct folder * set docker context * correct docker build * remove cli from dockerignore * chore: fix docs links * feat: add cli v2 milestone * fix: set correct cli date * remove submodule * chore: add npmignore * chore(cli): push to npm * fix: server e2e * run npm ci in server * remove state from e2e * run npm ci in server * reshuffle docker compose files * use new e2e composes in makefile * increase test timeout to 10 minutes * make github actions run makefile e2e tests * cleanup github test names * assert on server version * chore: split cli e2e tests into one file per command * chore: set cli release working dir * chore: add repo url to npmjs * chore: bump node setup to v4 * chore: normalize the github url * check e2e code in lint * fix lint * test key login flow * feat: allow configurable config dir * fix session service tests * create missing dir * cleanup * bump cli version to 2.0.4 * remove form-data * feat: allow single files as argument * add version option * bump dependencies * fix lint * wip use axios as upload * version bump * cApiTALiZaTiON * don't touch package lock * wip: don't use job queues * don't use make for cli e2e * fix server e2e * chore: remove old gha step * add npm ci to server --------- Co-authored-by: Alex <alex.tran1502@gmail.com> Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
300 lines
10 KiB
TypeScript
300 lines
10 KiB
TypeScript
import { LoginResponseDto, UserResponseDto, UserService } from '@app/domain';
|
|
import { AppModule, UserController } from '@app/immich';
|
|
import { UserEntity } from '@app/infra/entities';
|
|
import { INestApplication } from '@nestjs/common';
|
|
import { getRepositoryToken } from '@nestjs/typeorm';
|
|
import { api } from '@test/api';
|
|
import { errorStub, userDto, userSignupStub, userStub } from '@test/fixtures';
|
|
import { testApp } from '@test/test-utils';
|
|
import request from 'supertest';
|
|
import { Repository } from 'typeorm';
|
|
|
|
describe(`${UserController.name}`, () => {
|
|
let app: INestApplication;
|
|
let server: any;
|
|
let loginResponse: LoginResponseDto;
|
|
let accessToken: string;
|
|
let userService: UserService;
|
|
let userRepository: Repository<UserEntity>;
|
|
|
|
beforeAll(async () => {
|
|
app = await testApp.create();
|
|
server = app.getHttpServer();
|
|
userRepository = app.select(AppModule).get(getRepositoryToken(UserEntity));
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await testApp.teardown();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await testApp.reset();
|
|
await api.authApi.adminSignUp(server);
|
|
loginResponse = await api.authApi.adminLogin(server);
|
|
accessToken = loginResponse.accessToken;
|
|
|
|
userService = app.get<UserService>(UserService);
|
|
});
|
|
|
|
describe('GET /user', () => {
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).get('/user');
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
it('should start with the admin', async () => {
|
|
const { status, body } = await request(server).get('/user').set('Authorization', `Bearer ${accessToken}`);
|
|
expect(status).toEqual(200);
|
|
expect(body).toHaveLength(1);
|
|
expect(body[0]).toMatchObject({ email: 'admin@immich.app' });
|
|
});
|
|
|
|
it('should hide deleted users', async () => {
|
|
const user1 = await api.userApi.create(server, accessToken, {
|
|
email: `user1@immich.app`,
|
|
password: 'Password123',
|
|
name: `User 1`,
|
|
});
|
|
|
|
await api.userApi.delete(server, accessToken, user1.id);
|
|
|
|
const { status, body } = await request(server)
|
|
.get(`/user`)
|
|
.query({ isAll: true })
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
expect(status).toBe(200);
|
|
expect(body).toHaveLength(1);
|
|
expect(body[0]).toMatchObject({ email: 'admin@immich.app' });
|
|
});
|
|
|
|
it('should include deleted users', async () => {
|
|
const user1 = await api.userApi.create(server, accessToken, userDto.user1);
|
|
|
|
await api.userApi.delete(server, accessToken, user1.id);
|
|
|
|
const { status, body } = await request(server)
|
|
.get(`/user`)
|
|
.query({ isAll: false })
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(status).toBe(200);
|
|
expect(body).toHaveLength(2);
|
|
expect(body[0]).toMatchObject({ id: user1.id, email: 'user1@immich.app', deletedAt: expect.any(String) });
|
|
expect(body[1]).toMatchObject({ id: loginResponse.userId, email: 'admin@immich.app' });
|
|
});
|
|
});
|
|
|
|
describe('GET /user/info/:id', () => {
|
|
it('should require authentication', async () => {
|
|
const { status } = await request(server).get(`/user/info/${loginResponse.userId}`);
|
|
expect(status).toEqual(401);
|
|
});
|
|
|
|
it('should get the user info', async () => {
|
|
const { status, body } = await request(server)
|
|
.get(`/user/info/${loginResponse.userId}`)
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
expect(status).toBe(200);
|
|
expect(body).toMatchObject({ id: loginResponse.userId, email: 'admin@immich.app' });
|
|
});
|
|
});
|
|
|
|
describe('GET /user/me', () => {
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).get(`/user/me`);
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
it('should get my info', async () => {
|
|
const { status, body } = await request(server).get(`/user/me`).set('Authorization', `Bearer ${accessToken}`);
|
|
expect(status).toBe(200);
|
|
expect(body).toMatchObject({ id: loginResponse.userId, email: 'admin@immich.app' });
|
|
});
|
|
});
|
|
|
|
describe('POST /user', () => {
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).post(`/user`).send(userSignupStub);
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
for (const key of Object.keys(userSignupStub)) {
|
|
it(`should not allow null ${key}`, async () => {
|
|
const { status, body } = await request(server)
|
|
.post(`/user`)
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.send({ ...userSignupStub, [key]: null });
|
|
expect(status).toBe(400);
|
|
expect(body).toEqual(errorStub.badRequest());
|
|
});
|
|
}
|
|
|
|
it('should ignore `isAdmin`', async () => {
|
|
const { status, body } = await request(server)
|
|
.post(`/user`)
|
|
.send({
|
|
isAdmin: true,
|
|
email: 'user1@immich.app',
|
|
password: 'Password123',
|
|
name: 'Immich',
|
|
})
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
expect(body).toMatchObject({
|
|
email: 'user1@immich.app',
|
|
isAdmin: false,
|
|
shouldChangePassword: true,
|
|
});
|
|
expect(status).toBe(201);
|
|
});
|
|
|
|
it('should create a user without memories enabled', async () => {
|
|
const { status, body } = await request(server)
|
|
.post(`/user`)
|
|
.send({
|
|
email: 'no-memories@immich.app',
|
|
password: 'Password123',
|
|
name: 'No Memories',
|
|
memoriesEnabled: false,
|
|
})
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
expect(body).toMatchObject({
|
|
email: 'no-memories@immich.app',
|
|
memoriesEnabled: false,
|
|
});
|
|
expect(status).toBe(201);
|
|
});
|
|
});
|
|
|
|
describe('DELETE /user/:id', () => {
|
|
let userToDelete: UserResponseDto;
|
|
|
|
beforeEach(async () => {
|
|
userToDelete = await api.userApi.create(server, accessToken, {
|
|
email: userStub.user1.email,
|
|
name: userStub.user1.name,
|
|
password: 'superSecurePassword',
|
|
});
|
|
});
|
|
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).delete(`/user/${userToDelete.id}`);
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
it('should delete user', async () => {
|
|
const deleteRequest = await request(server)
|
|
.delete(`/user/${userToDelete.id}`)
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(deleteRequest.status).toBe(200);
|
|
expect(deleteRequest.body).toEqual({
|
|
...userToDelete,
|
|
updatedAt: expect.any(String),
|
|
deletedAt: expect.any(String),
|
|
});
|
|
|
|
await userRepository.save({ id: deleteRequest.body.id, deletedAt: new Date('1970-01-01').toISOString() });
|
|
|
|
await userService.handleUserDelete({ id: userToDelete.id });
|
|
|
|
const { status, body } = await request(server)
|
|
.get('/user')
|
|
.query({ isAll: false })
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(status).toBe(200);
|
|
expect(body).toHaveLength(1);
|
|
});
|
|
});
|
|
|
|
describe('PUT /user', () => {
|
|
it('should require authentication', async () => {
|
|
const { status, body } = await request(server).put(`/user`);
|
|
expect(status).toBe(401);
|
|
expect(body).toEqual(errorStub.unauthorized);
|
|
});
|
|
|
|
for (const key of Object.keys(userStub.admin)) {
|
|
it(`should not allow null ${key}`, async () => {
|
|
const { status, body } = await request(server)
|
|
.put(`/user`)
|
|
.set('Authorization', `Bearer ${accessToken}`)
|
|
.send({ ...userStub.admin, [key]: null });
|
|
expect(status).toBe(400);
|
|
expect(body).toEqual(errorStub.badRequest());
|
|
});
|
|
}
|
|
|
|
it('should not allow a non-admin to become an admin', async () => {
|
|
const user = await api.userApi.create(server, accessToken, {
|
|
email: 'user1@immich.app',
|
|
password: 'Password123',
|
|
name: 'Immich User',
|
|
});
|
|
|
|
const { status, body } = await request(server)
|
|
.put(`/user`)
|
|
.send({ isAdmin: true, id: user.id })
|
|
.set('Authorization', `Bearer ${accessToken}`);
|
|
|
|
expect(status).toBe(400);
|
|
expect(body).toEqual(errorStub.alreadyHasAdmin);
|
|
});
|
|
|
|
it('ignores updates to profileImagePath', async () => {
|
|
const user = await api.userApi.update(server, accessToken, {
|
|
id: loginResponse.userId,
|
|
profileImagePath: 'invalid.jpg',
|
|
} as any);
|
|
|
|
expect(user).toMatchObject({ id: loginResponse.userId, profileImagePath: '' });
|
|
});
|
|
|
|
it('should ignore updates to createdAt, updatedAt and deletedAt', async () => {
|
|
const before = await api.userApi.get(server, accessToken, loginResponse.userId);
|
|
const after = await api.userApi.update(server, accessToken, {
|
|
id: loginResponse.userId,
|
|
createdAt: '2023-01-01T00:00:00.000Z',
|
|
updatedAt: '2023-01-01T00:00:00.000Z',
|
|
deletedAt: '2023-01-01T00:00:00.000Z',
|
|
} as any);
|
|
|
|
expect(after).toStrictEqual(before);
|
|
});
|
|
|
|
it('should update first and last name', async () => {
|
|
const before = await api.userApi.get(server, accessToken, loginResponse.userId);
|
|
const after = await api.userApi.update(server, accessToken, {
|
|
id: before.id,
|
|
name: 'Name',
|
|
});
|
|
|
|
expect(after).toEqual({
|
|
...before,
|
|
updatedAt: expect.any(String),
|
|
name: 'Name',
|
|
});
|
|
expect(before.updatedAt).not.toEqual(after.updatedAt);
|
|
});
|
|
|
|
it('should update memories enabled', async () => {
|
|
const before = await api.userApi.get(server, accessToken, loginResponse.userId);
|
|
const after = await api.userApi.update(server, accessToken, {
|
|
id: before.id,
|
|
memoriesEnabled: false,
|
|
});
|
|
|
|
expect(after).toMatchObject({
|
|
...before,
|
|
updatedAt: expect.anything(),
|
|
memoriesEnabled: false,
|
|
});
|
|
expect(before.updatedAt).not.toEqual(after.updatedAt);
|
|
});
|
|
});
|
|
});
|