2020-08-02 13:28:50 +02:00
import { Dirnames } from './utils/types' ;
2020-11-05 18:58:23 +02:00
import shim from '../../shim' ;
2021-05-13 18:57:37 +02:00
import JoplinError from '../../JoplinError' ;
2021-01-22 19:41:11 +02:00
import time from '../../time' ;
2021-11-03 14:26:26 +02:00
import { FileApi } from '../../file-api' ;
2021-12-13 11:32:22 +02:00
import { AppType } from '../../models/Setting' ;
2020-11-05 18:58:23 +02:00
const { fileExtension , filename } = require ( '../../path-utils' ) ;
2020-08-02 13:28:50 +02:00
export enum LockType {
2021-11-03 14:26:26 +02:00
None = 0 ,
Sync = 1 ,
Exclusive = 2 ,
}
export enum LockClientType {
Desktop = 1 ,
Mobile = 2 ,
Cli = 3 ,
2020-08-02 13:28:50 +02:00
}
export interface Lock {
2021-11-03 14:26:26 +02:00
id? : string ;
2020-11-12 21:29:22 +02:00
type : LockType ;
2021-11-03 14:26:26 +02:00
clientType : LockClientType ;
2020-11-12 21:29:22 +02:00
clientId : string ;
updatedTime? : number ;
2020-08-02 13:28:50 +02:00
}
2021-11-03 14:26:26 +02:00
function lockIsActive ( lock : Lock , currentDate : Date , lockTtl : number ) : boolean {
return currentDate . getTime ( ) - lock . updatedTime < lockTtl ;
}
export function lockNameToObject ( name : string , updatedTime : number = null ) : Lock {
const p = name . split ( '_' ) ;
const lock : Lock = {
id : null ,
type : Number ( p [ 0 ] ) as LockType ,
clientType : Number ( p [ 1 ] ) as LockClientType ,
clientId : p [ 2 ] ,
updatedTime ,
} ;
if ( isNaN ( lock . clientType ) ) throw new Error ( ` Invalid lock client type: ${ name } ` ) ;
if ( isNaN ( lock . type ) ) throw new Error ( ` Invalid lock type: ${ name } ` ) ;
return lock ;
}
2021-12-13 11:32:22 +02:00
export function appTypeToLockType ( appType : AppType ) : LockClientType {
if ( appType === AppType . Desktop ) return LockClientType . Desktop ;
if ( appType === AppType . Mobile ) return LockClientType . Mobile ;
if ( appType === AppType . Cli ) return LockClientType . Cli ;
throw new Error ( ` Invalid app type: ${ appType } ` ) ;
}
2021-11-03 14:26:26 +02:00
export function hasActiveLock ( locks : Lock [ ] , currentDate : Date , lockTtl : number , lockType : LockType , clientType : LockClientType = null , clientId : string = null ) {
const lock = activeLock ( locks , currentDate , lockTtl , lockType , clientType , clientId ) ;
return ! ! lock ;
}
// Finds if there's an active lock for this clientType and clientId and returns it.
// If clientType and clientId are not specified, returns the first active lock
// of that type instead.
export function activeLock ( locks : Lock [ ] , currentDate : Date , lockTtl : number , lockType : LockType , clientType : LockClientType = null , clientId : string = null ) {
if ( lockType === LockType . Exclusive ) {
const activeLocks = locks
. slice ( )
. filter ( ( lock : Lock ) = > lockIsActive ( lock , currentDate , lockTtl ) && lock . type === lockType )
. sort ( ( a : Lock , b : Lock ) = > {
if ( a . updatedTime === b . updatedTime ) {
return a . clientId < b . clientId ? - 1 : + 1 ;
}
return a . updatedTime < b . updatedTime ? - 1 : + 1 ;
} ) ;
if ( ! activeLocks . length ) return null ;
const lock = activeLocks [ 0 ] ;
if ( clientType && clientType !== lock . clientType ) return null ;
if ( clientId && clientId !== lock . clientId ) return null ;
return lock ;
} else if ( lockType === LockType . Sync ) {
for ( const lock of locks ) {
if ( lock . type !== lockType ) continue ;
if ( clientType && lock . clientType !== clientType ) continue ;
if ( clientId && lock . clientId !== clientId ) continue ;
if ( lockIsActive ( lock , currentDate , lockTtl ) ) return lock ;
}
return null ;
}
throw new Error ( ` Unsupported lock type: ${ lockType } ` ) ;
}
2021-08-18 16:49:43 +02:00
export interface AcquireLockOptions {
// In theory, a client that tries to acquire an exclusive lock shouldn't
// also have a sync lock. It can however happen when the app is closed
// before the end of the sync process, and then the user tries to upgrade
// the sync target.
//
// So maybe we could always automatically clear the sync locks (that belongs
// to the current client) when acquiring an exclusive lock, but to be safe
// we make the behaviour explicit via this option. It is used for example
// when migrating a sync target.
//
// https://discourse.joplinapp.org/t/error-upgrading-to-2-3-3/19549/4?u=laurent
clearExistingSyncLocksFromTheSameClient? : boolean ;
timeoutMs? : number ;
}
function defaultAcquireLockOptions ( ) : AcquireLockOptions {
return {
clearExistingSyncLocksFromTheSameClient : false ,
timeoutMs : 0 ,
} ;
}
2020-08-02 13:28:50 +02:00
interface RefreshTimer {
2020-11-12 21:29:22 +02:00
id : any ;
inProgress : boolean ;
2020-08-02 13:28:50 +02:00
}
interface RefreshTimers {
2020-11-12 21:13:28 +02:00
[ key : string ] : RefreshTimer ;
2020-08-02 13:28:50 +02:00
}
export interface LockHandlerOptions {
2020-11-12 21:29:22 +02:00
autoRefreshInterval? : number ;
lockTtl? : number ;
2020-08-02 13:28:50 +02:00
}
2021-11-03 14:26:26 +02:00
export const defaultLockTtl = 1000 * 60 * 3 ;
2020-08-02 13:28:50 +02:00
export default class LockHandler {
2021-11-03 14:26:26 +02:00
private api_ : FileApi = null ;
2020-11-12 21:13:28 +02:00
private refreshTimers_ : RefreshTimers = { } ;
private autoRefreshInterval_ : number = 1000 * 60 ;
2021-11-03 14:26:26 +02:00
private lockTtl_ : number = defaultLockTtl ;
2020-08-02 13:28:50 +02:00
2021-11-03 14:26:26 +02:00
public constructor ( api : FileApi , options : LockHandlerOptions = null ) {
2020-08-02 13:28:50 +02:00
if ( ! options ) options = { } ;
this . api_ = api ;
if ( 'lockTtl' in options ) this . lockTtl_ = options . lockTtl ;
if ( 'autoRefreshInterval' in options ) this . autoRefreshInterval_ = options . autoRefreshInterval ;
}
2020-11-12 21:13:28 +02:00
public get lockTtl ( ) : number {
2020-08-02 13:28:50 +02:00
return this . lockTtl_ ;
}
// Should only be done for testing purposes since all clients should
// use the same lock max age.
2020-11-12 21:13:28 +02:00
public set lockTtl ( v : number ) {
2020-08-02 13:28:50 +02:00
this . lockTtl_ = v ;
}
2021-11-03 14:26:26 +02:00
public get useBuiltInLocks() {
return this . api_ . supportsLocks ;
}
2020-11-12 21:13:28 +02:00
private lockFilename ( lock : Lock ) {
2020-08-02 13:28:50 +02:00
return ` ${ [ lock . type , lock . clientType , lock . clientId ] . join ( '_' ) } .json ` ;
}
2020-11-12 21:13:28 +02:00
private lockTypeFromFilename ( name : string ) : LockType {
2020-08-02 13:28:50 +02:00
const ext = fileExtension ( name ) ;
if ( ext !== 'json' ) return LockType . None ;
2021-11-03 14:26:26 +02:00
if ( name . indexOf ( LockType . Sync . toString ( ) ) === 0 ) return LockType . Sync ;
if ( name . indexOf ( LockType . Exclusive . toString ( ) ) === 0 ) return LockType . Exclusive ;
2020-08-02 13:28:50 +02:00
return LockType . None ;
}
2020-11-12 21:13:28 +02:00
private lockFilePath ( lock : Lock ) {
2020-08-02 13:28:50 +02:00
return ` ${ Dirnames . Locks } / ${ this . lockFilename ( lock ) } ` ;
}
2020-11-12 21:13:28 +02:00
private lockFileToObject ( file : any ) : Lock {
2021-11-03 14:26:26 +02:00
return lockNameToObject ( filename ( file . path ) , file . updated_time ) ;
2020-08-02 13:28:50 +02:00
}
2020-11-12 21:13:28 +02:00
async locks ( lockType : LockType = null ) : Promise < Lock [ ] > {
2021-11-03 14:26:26 +02:00
if ( this . useBuiltInLocks ) {
const locks = ( await this . api_ . listLocks ( ) ) . items ;
return locks ;
}
2020-08-02 13:28:50 +02:00
const result = await this . api_ . list ( Dirnames . Locks ) ;
if ( result . hasMore ) throw new Error ( 'hasMore not handled' ) ; // Shouldn't happen anyway
const output = [ ] ;
for ( const file of result . items ) {
const type = this . lockTypeFromFilename ( file . path ) ;
if ( type === LockType . None ) continue ;
if ( lockType && type !== lockType ) continue ;
const lock = this . lockFileToObject ( file ) ;
output . push ( lock ) ;
}
return output ;
}
2020-11-12 21:13:28 +02:00
private async saveLock ( lock : Lock ) {
2020-08-02 13:28:50 +02:00
await this . api_ . put ( this . lockFilePath ( lock ) , JSON . stringify ( lock ) ) ;
}
// This is for testing only
2020-11-12 21:13:28 +02:00
public async saveLock_ ( lock : Lock ) {
2020-08-02 13:28:50 +02:00
return this . saveLock ( lock ) ;
}
2021-11-03 14:26:26 +02:00
private async acquireSyncLock ( clientType : LockClientType , clientId : string ) : Promise < Lock > {
if ( this . useBuiltInLocks ) return this . api_ . acquireLock ( LockType . Sync , clientType , clientId ) ;
2020-08-02 13:28:50 +02:00
try {
let isFirstPass = true ;
while ( true ) {
2021-11-03 14:26:26 +02:00
const locks = await this . locks ( ) ;
const currentDate = await this . currentDate ( ) ;
2020-08-02 13:28:50 +02:00
const [ exclusiveLock , syncLock ] = await Promise . all ( [
2021-11-03 14:26:26 +02:00
activeLock ( locks , currentDate , this . lockTtl , LockType . Exclusive ) ,
activeLock ( locks , currentDate , this . lockTtl , LockType . Sync , clientType , clientId ) ,
2020-08-02 13:28:50 +02:00
] ) ;
if ( exclusiveLock ) {
throw new JoplinError ( ` Cannot acquire sync lock because the following client has an exclusive lock on the sync target: ${ this . lockToClientString ( exclusiveLock ) } ` , 'hasExclusiveLock' ) ;
}
if ( syncLock ) {
// Normally the second pass should happen immediately afterwards, but if for some reason
// (slow network, etc.) it took more than 10 seconds then refresh the lock.
if ( isFirstPass || Date . now ( ) - syncLock . updatedTime > 1000 * 10 ) {
await this . saveLock ( syncLock ) ;
}
return syncLock ;
}
// Something wrong happened, which means we saved a lock but we didn't read
// it back. Could be application error or server issue.
if ( ! isFirstPass ) throw new Error ( 'Cannot acquire sync lock: either the lock could be written but not read back. Or it was expired before it was read again.' ) ;
await this . saveLock ( {
type : LockType . Sync ,
clientType : clientType ,
clientId : clientId ,
} ) ;
isFirstPass = false ;
}
} catch ( error ) {
await this . releaseLock ( LockType . Sync , clientType , clientId ) ;
throw error ;
}
}
2020-11-12 21:13:28 +02:00
private lockToClientString ( lock : Lock ) : string {
2020-08-02 13:28:50 +02:00
return ` ( ${ lock . clientType } # ${ lock . clientId } ) ` ;
}
2021-11-03 14:26:26 +02:00
private async acquireExclusiveLock ( clientType : LockClientType , clientId : string , options : AcquireLockOptions = null ) : Promise < Lock > {
if ( this . useBuiltInLocks ) return this . api_ . acquireLock ( LockType . Exclusive , clientType , clientId ) ;
2020-08-02 13:28:50 +02:00
// The logic to acquire an exclusive lock, while avoiding race conditions is as follow:
//
// - Check if there is a lock file present
//
// - If there is a lock file, see if I'm the one owning it by checking that its content has my identifier.
// - If that's the case, just write to the data file then delete the lock file.
// - If that's not the case, just wait a second or a small random length of time and try the whole cycle again-.
//
// -If there is no lock file, create one with my identifier and try the whole cycle again to avoid race condition (re-check that the lock file is really mine)-.
2021-08-18 16:49:43 +02:00
options = {
. . . defaultAcquireLockOptions ( ) ,
. . . options ,
} ;
2020-08-02 13:28:50 +02:00
const startTime = Date . now ( ) ;
async function waitForTimeout() {
2021-08-18 16:49:43 +02:00
if ( ! options . timeoutMs ) return false ;
2020-08-02 13:28:50 +02:00
const elapsed = Date . now ( ) - startTime ;
2021-08-18 16:49:43 +02:00
if ( options . timeoutMs && elapsed < options . timeoutMs ) {
2020-08-02 13:28:50 +02:00
await time . sleep ( 2 ) ;
return true ;
}
return false ;
}
try {
while ( true ) {
2021-11-03 14:26:26 +02:00
const locks = await this . locks ( ) ;
const currentDate = await this . currentDate ( ) ;
2020-08-02 13:28:50 +02:00
const [ activeSyncLock , activeExclusiveLock ] = await Promise . all ( [
2021-11-03 14:26:26 +02:00
activeLock ( locks , currentDate , this . lockTtl , LockType . Sync ) ,
activeLock ( locks , currentDate , this . lockTtl , LockType . Exclusive ) ,
2020-08-02 13:28:50 +02:00
] ) ;
if ( activeSyncLock ) {
2021-08-18 16:49:43 +02:00
if ( options . clearExistingSyncLocksFromTheSameClient && activeSyncLock . clientId === clientId && activeSyncLock . clientType === clientType ) {
await this . releaseLock ( LockType . Sync , clientType , clientId ) ;
} else {
if ( await waitForTimeout ( ) ) continue ;
throw new JoplinError ( ` Cannot acquire exclusive lock because the following clients have a sync lock on the target: ${ this . lockToClientString ( activeSyncLock ) } ` , 'hasSyncLock' ) ;
}
2020-08-02 13:28:50 +02:00
}
if ( activeExclusiveLock ) {
if ( activeExclusiveLock . clientId === clientId ) {
// Save it again to refresh the timestamp
await this . saveLock ( activeExclusiveLock ) ;
return activeExclusiveLock ;
} else {
// If there's already an exclusive lock, wait for it to be released
if ( await waitForTimeout ( ) ) continue ;
throw new JoplinError ( ` Cannot acquire exclusive lock because the following client has an exclusive lock on the sync target: ${ this . lockToClientString ( activeExclusiveLock ) } ` , 'hasExclusiveLock' ) ;
}
} else {
// If there's not already an exclusive lock, acquire one
// then loop again to check that we really got the lock
// (to prevent race conditions)
await this . saveLock ( {
type : LockType . Exclusive ,
clientType : clientType ,
clientId : clientId ,
} ) ;
await time . msleep ( 100 ) ;
}
}
} catch ( error ) {
await this . releaseLock ( LockType . Exclusive , clientType , clientId ) ;
throw error ;
}
}
2020-11-12 21:13:28 +02:00
private autoLockRefreshHandle ( lock : Lock ) {
2020-08-02 13:28:50 +02:00
return [ lock . type , lock . clientType , lock . clientId ] . join ( '_' ) ;
}
2021-11-03 14:26:26 +02:00
public async currentDate() {
return this . api_ . remoteDate ( ) ;
}
public startAutoLockRefresh ( lock : Lock , errorHandler : Function ) : string {
2020-08-02 13:28:50 +02:00
const handle = this . autoLockRefreshHandle ( lock ) ;
if ( this . refreshTimers_ [ handle ] ) {
throw new Error ( ` There is already a timer refreshing this lock: ${ handle } ` ) ;
}
this . refreshTimers_ [ handle ] = {
id : null ,
inProgress : false ,
} ;
2020-10-09 19:35:46 +02:00
this . refreshTimers_ [ handle ] . id = shim . setInterval ( async ( ) = > {
2020-08-02 13:28:50 +02:00
if ( this . refreshTimers_ [ handle ] . inProgress ) return ;
const defer = ( ) = > {
if ( ! this . refreshTimers_ [ handle ] ) return ;
this . refreshTimers_ [ handle ] . inProgress = false ;
} ;
this . refreshTimers_ [ handle ] . inProgress = true ;
let error = null ;
if ( ! this . refreshTimers_ [ handle ] ) return defer ( ) ; // Timeout has been cleared
2021-11-03 14:26:26 +02:00
const locks = await this . locks ( lock . type ) ;
if ( ! hasActiveLock ( locks , await this . currentDate ( ) , this . lockTtl , lock . type , lock . clientType , lock . clientId ) ) {
2020-09-11 12:26:07 +02:00
// If the previous lock has expired, we shouldn't try to acquire a new one. This is because other clients might have performed
// in the meantime operations that invalidates the current operation. For example, another client might have upgraded the
// sync target in the meantime, so any active operation should be cancelled here. Or if the current client was upgraded
// the sync target, another client might have synced since then, making any cached data invalid.
// In some cases it should be safe to re-acquire a lock but adding support for this would make the algorithm more complex
// without much benefits.
2020-08-02 13:28:50 +02:00
error = new JoplinError ( 'Lock has expired' , 'lockExpired' ) ;
} else {
try {
await this . acquireLock ( lock . type , lock . clientType , lock . clientId ) ;
if ( ! this . refreshTimers_ [ handle ] ) return defer ( ) ; // Timeout has been cleared
} catch ( e ) {
error = e ;
}
}
if ( error ) {
if ( this . refreshTimers_ [ handle ] ) {
2020-10-09 19:35:46 +02:00
shim . clearInterval ( this . refreshTimers_ [ handle ] . id ) ;
2020-08-02 13:28:50 +02:00
delete this . refreshTimers_ [ handle ] ;
}
errorHandler ( error ) ;
}
defer ( ) ;
} , this . autoRefreshInterval_ ) ;
return handle ;
}
2020-11-12 21:13:28 +02:00
stopAutoLockRefresh ( lock : Lock ) {
2020-08-02 13:28:50 +02:00
const handle = this . autoLockRefreshHandle ( lock ) ;
if ( ! this . refreshTimers_ [ handle ] ) {
// Should not throw an error because lock may have been cleared in startAutoLockRefresh
// if there was an error.
// throw new Error(`There is no such lock being auto-refreshed: ${this.lockToString(lock)}`);
return ;
}
2020-10-09 19:35:46 +02:00
shim . clearInterval ( this . refreshTimers_ [ handle ] . id ) ;
2020-08-02 13:28:50 +02:00
delete this . refreshTimers_ [ handle ] ;
}
2021-11-03 14:26:26 +02:00
public async acquireLock ( lockType : LockType , clientType : LockClientType , clientId : string , options : AcquireLockOptions = null ) : Promise < Lock > {
2021-08-18 16:49:43 +02:00
options = {
. . . defaultAcquireLockOptions ( ) ,
. . . options ,
} ;
2020-08-02 13:28:50 +02:00
if ( lockType === LockType . Sync ) {
return this . acquireSyncLock ( clientType , clientId ) ;
} else if ( lockType === LockType . Exclusive ) {
2021-08-18 16:49:43 +02:00
return this . acquireExclusiveLock ( clientType , clientId , options ) ;
2020-08-02 13:28:50 +02:00
} else {
throw new Error ( ` Invalid lock type: ${ lockType } ` ) ;
}
}
2021-11-03 14:26:26 +02:00
public async releaseLock ( lockType : LockType , clientType : LockClientType , clientId : string ) {
if ( this . useBuiltInLocks ) {
await this . api_ . releaseLock ( lockType , clientType , clientId ) ;
return ;
}
2020-08-02 13:28:50 +02:00
await this . api_ . delete ( this . lockFilePath ( {
type : lockType ,
clientType : clientType ,
clientId : clientId ,
} ) ) ;
}
}