self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-13 00:10:37 +02:00
Code Issues Releases Activity

Mobile: Resolves #10360: Make most plugins default to being desktop-only (#10376)

Browse Source
This commit is contained in:
Henry Heino
2024-04-27 03:43:25 -07:00
committed by GitHub
parent 034e568d26
commit 03617eb8a7
8 changed files with 64 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/lib/services/plugins/utils/isCompatible/index.test.ts
View File

@ -8,7 +8,7 @@ describe('isCompatible', () => {
manifest: { app_min_version: '2.0' },
appVersion: '2.1.0',
shouldSupportDesktop: true,
shouldSupportMobile: true,
shouldSupportMobile: false,
},
{
manifest: { app_min_version: '2.0' },
@ -20,7 +20,7 @@ describe('isCompatible', () => {
manifest: { app_min_version: '3.0.2' },
appVersion: '3.0.2',
shouldSupportDesktop: true,
shouldSupportMobile: true,
shouldSupportMobile: false,
},
// Should support the case where only one platform is provided, with no version
@ -83,9 +83,13 @@ describe('isCompatible', () => {
shouldSupportMobile: true,
},
])('should correctly return whether a plugin is compatible with a given version of Joplin (case %#: %j)', ({ manifest, appVersion, shouldSupportDesktop, shouldSupportMobile }) => {
const mobileCompatible = isCompatible(appVersion, AppType.Mobile, manifest);
const fullManifest = {
id: 'com.example.id',
...manifest,
};
const mobileCompatible = isCompatible(appVersion, AppType.Mobile, fullManifest);
expect(mobileCompatible).toBe(shouldSupportMobile);
const desktopCompatible = isCompatible(appVersion, AppType.Desktop, manifest);
const desktopCompatible = isCompatible(appVersion, AppType.Desktop, fullManifest);
expect(desktopCompatible).toBe(shouldSupportDesktop);
});
});