self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-13 00:10:37 +02:00
Code Issues Releases Activity

Tools: Apply rule github/array-foreach

Browse Source
This commit is contained in:
Laurent Cozic
2023-06-30 09:39:21 +01:00
parent c6a15b3186
commit 0c4ba592f6
32 changed files with 473 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/lib/services/KeymapService.test.js
View File

@ -30,8 +30,10 @@ describe('services_KeymapService', () => {
],
};
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
Object.entries(testCases).forEach(([platform, accelerators]) => {
keymapService.initialize([], platform);
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
accelerators.forEach(accelerator => {
expect(() => keymapService.validateAccelerator(accelerator)).not.toThrow();
});
@ -68,8 +70,10 @@ describe('services_KeymapService', () => {
],
};
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
Object.entries(testCases).forEach(([platform, accelerators]) => {
keymapService.initialize([], platform);
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
accelerators.forEach(accelerator => {
expect(() => keymapService.validateAccelerator(accelerator)).toThrow();
});
@ -142,6 +146,7 @@ describe('services_KeymapService', () => {
{ command: 'focusElementNoteBody', accelerator: 'Ctrl+Option+Shift+Cmd+B' },
];
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
testCases_Darwin.forEach(({ command, accelerator }) => {
keymapService.setAccelerator(command, accelerator);
expect(keymapService.getAccelerator(command)).toEqual(accelerator);
@ -159,6 +164,7 @@ describe('services_KeymapService', () => {
{ command: 'focusElementNoteBody', accelerator: 'Ctrl+Alt+Shift+B' },
];
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
testCases_Linux.forEach(({ command, accelerator }) => {
keymapService.setAccelerator(command, accelerator);
expect(keymapService.getAccelerator(command)).toEqual(accelerator);
@ -181,6 +187,7 @@ describe('services_KeymapService', () => {
{ command: 'focusElementNoteBody', accelerator: 'Ctrl+Alt+Shift+B' },
];
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
testCases.forEach(({ command, accelerator }) => {
// Remember the real default Accelerator value
const defaultAccelerator = keymapService.getAccelerator(command);
@ -212,6 +219,7 @@ describe('services_KeymapService', () => {
];
expect(() => keymapService.overrideKeymap(customKeymapItems_Darwin)).not.toThrow();
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
customKeymapItems_Darwin.forEach(({ command, accelerator }) => {
// Also check if keymap is updated or not
expect(keymapService.getAccelerator(command)).toEqual(accelerator);
@ -233,6 +241,7 @@ describe('services_KeymapService', () => {
];
expect(() => keymapService.overrideKeymap(customKeymapItems_Win32)).not.toThrow();
// eslint-disable-next-line github/array-foreach -- Old code before rule was applied
customKeymapItems_Win32.forEach(({ command, accelerator }) => {
// Also check if keymap is updated or not
expect(keymapService.getAccelerator(command)).toEqual(accelerator);