self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-11-30 08:26:59 +02:00
Code Issues Releases Activity

Desktop: Fixes #7499: Random crash when searching

Browse Source
This commit is contained in:
Laurent Cozic 2022-12-30 23:51:39 +00:00
parent 5fb01b5c7a
commit 0db0a565b7
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/utils/useEditorSearch.ts
View File

@ -1,5 +1,8 @@
import { useEffect, useRef, useState } from 'react';
import shim from '@joplin/lib/shim';
import Logger from '@joplin/lib/Logger';
const logger = Logger.create('useEditorSearch');
export default function useEditorSearch(CodeMirror: any) {
@ -23,7 +26,16 @@ export default function useEditorSearch(CodeMirror: any) {
function clearOverlay(cm: any) {
if (overlay) cm.removeOverlay(overlay);
if (scrollbarMarks) scrollbarMarks.clear();
if (scrollbarMarks) {
try {
scrollbarMarks.clear();
} catch (error) {
// This can randomly crash the app so just print a warning since
// it's probably not critical.
// https://github.com/laurent22/joplin/issues/7499
logger.error('useEditorSearch: Could not clear scrollbar marks:', error);
}
}
if (overlayTimeout) shim.clearTimeout(overlayTimeout);