self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-11-26 22:41:17 +02:00
Code Issues Releases Activity

Desktop: Fix "Open" option for attachments shown in context menu for web links (#12215)

Browse Source
This commit is contained in:
Henry Heino
2025-05-19 15:00:15 -07:00
committed by GitHub
parent dc786e8178
commit 1780a530c9
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/utils/useContextMenu.ts
View File

@@ -17,6 +17,7 @@ import { EditDialogControl } from './useEditDialog';
import { Dispatch } from 'redux';
import { _ } from '@joplin/lib/locale';
import type { MenuItem as MenuItemType } from 'electron';
import isItemId from '@joplin/lib/models/utils/isItemId';
const Menu = bridge().Menu;
const MenuItem = bridge().MenuItem;
@@ -40,11 +41,16 @@ export default function(editor: Editor, plugins: PluginStates, dispatch: Dispatc
let resourceId = '';
let linkToCopy = null;
const pathToId = (path: string) => {
const id = Resource.pathToId(path);
return isItemId(id) ? id : '';
};
if (element.nodeName === 'IMG') {
itemType = ContextMenuItemType.Image;
resourceId = Resource.pathToId((element as HTMLImageElement).src);
resourceId = pathToId((element as HTMLImageElement).src);
} else if (element.nodeName === 'A') {
resourceId = Resource.pathToId((element as HTMLAnchorElement).href);
resourceId = pathToId((element as HTMLAnchorElement).href);
itemType = resourceId ? ContextMenuItemType.Resource : ContextMenuItemType.Link;
linkToCopy = element.getAttribute('href') || '';
} else {