self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-08-13 22:12:50 +02:00
Code Issues Releases Activity

Added comment

Browse Source
This commit is contained in:
Laurent Cozic
2018-11-07 22:22:26 +00:00
parent 18717bac79
commit 19f5a144e5
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ElectronClient/app/gui/NoteText.jsx
View File

@@ -466,6 +466,13 @@ class NoteTextComponent extends React.Component {
this.setState(newState); this.setState(newState);
// https://github.com/laurent22/joplin/pull/893#discussion_r228025210
// @Abijeet: Had to add this check. If not, was going into an infinite loop where state was getting updated repeatedly.
// Since I'm updating the state, the componentWillReceiveProps was getting triggered again, where nextProps.newNote was still true, causing reloadNote to trigger again and again.
// Notes from Laurent: The selected note tags are part of the global Redux state because they need to be updated whenever tags are changed or deleted
// anywhere in the app. Thus it's not possible simple to load the tags here (as we won't have a way to know if they're updated afterwards).
// Perhaps a better way would be to move that code in the middleware, check for TAGS_DELETE, TAGS_UPDATE, etc. actions and update the
// selected note tags accordingly.
if (!this.props.newNote) { if (!this.props.newNote) {
this.props.dispatch({ this.props.dispatch({
type: "SET_NOTE_TAGS", type: "SET_NOTE_TAGS",